From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] mm: use filemap_range_needs_writeback() for O_DIRECT reads
Date: Tue, 9 Feb 2021 07:27:11 -0700 [thread overview]
Message-ID: <07f67e83-ddfa-19f9-e4d5-f06a939b8840@kernel.dk> (raw)
In-Reply-To: <20210209074814.GB1696555@infradead.org>
On 2/9/21 12:48 AM, Christoph Hellwig wrote:
> On Mon, Feb 08, 2021 at 07:30:07PM -0700, Jens Axboe wrote:
>> For the generic page cache read helper, use the better variant of checking
>> for the need to call filemap_write_and_wait_range() when doing O_DIRECT
>> reads. This avoids falling back to the slow path for IOCB_NOWAIT, if there
>> are no pages to wait for (or write out).
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>> ---
>> mm/filemap.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/filemap.c b/mm/filemap.c
>> index 6a58d50fbd31..c80acb80e8f7 100644
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -2643,8 +2643,8 @@ generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter)
>>
>> size = i_size_read(inode);
>> if (iocb->ki_flags & IOCB_NOWAIT) {
>> - if (filemap_range_has_page(mapping, iocb->ki_pos,
>> - iocb->ki_pos + count - 1))
>> + if (filemap_range_needs_writeback(mapping, iocb->ki_pos,
>> + iocb->ki_pos + count - 1))
>
> Please avoid the overy long line, which is trivial to do by using the
> normal two tab indent for the continuation.
Sure, fixed.
--
Jens Axboe
next prev parent reply other threads:[~2021-02-09 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 2:30 [PATCHSET v2 0/3] Improve IOCB_NOWAIT O_DIRECT reads Jens Axboe
2021-02-09 2:30 ` [PATCH 1/3] mm: provide filemap_range_needs_writeback() helper Jens Axboe
2021-02-09 7:47 ` Christoph Hellwig
2021-02-09 14:30 ` Jens Axboe
2021-02-09 2:30 ` [PATCH 2/3] mm: use filemap_range_needs_writeback() for O_DIRECT reads Jens Axboe
2021-02-09 7:48 ` Christoph Hellwig
2021-02-09 14:27 ` Jens Axboe [this message]
2021-02-09 2:30 ` [PATCH 3/3] iomap: " Jens Axboe
2021-02-09 7:51 ` Christoph Hellwig
2021-02-09 14:29 ` Jens Axboe
2021-02-09 19:55 ` [PATCHSET v2 0/3] Improve IOCB_NOWAIT " Andrew Morton
2021-02-09 20:11 ` Jens Axboe
2021-02-10 8:07 ` Sedat Dilek
2021-02-10 14:47 ` Jens Axboe
2021-02-24 16:44 [PATCHSET v3 " Jens Axboe
2021-02-24 16:44 ` [PATCH 2/3] mm: use filemap_range_needs_writeback() for " Jens Axboe
2021-02-24 16:57 ` Matthew Wilcox
2021-02-24 17:23 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f67e83-ddfa-19f9-e4d5-f06a939b8840@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).