From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E330FC433E1 for ; Mon, 25 May 2020 08:31:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D5F32068D for ; Mon, 25 May 2020 08:31:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="u22PWsRg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D5F32068D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E4EB680022; Mon, 25 May 2020 04:31:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E25D28E0003; Mon, 25 May 2020 04:31:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D13E980022; Mon, 25 May 2020 04:31:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id B417F8E0003 for ; Mon, 25 May 2020 04:31:19 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 74B16180AD820 for ; Mon, 25 May 2020 08:31:19 +0000 (UTC) X-FDA: 76854571878.27.jar44_45bbb689dd314 X-HE-Tag: jar44_45bbb689dd314 X-Filterd-Recvd-Size: 5270 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 May 2020 08:31:19 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id e125so10079733lfd.1 for ; Mon, 25 May 2020 01:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UN2FWfxtmTvTgPTJlbLtgk/SxaHl1REeGMaSieqXqSI=; b=u22PWsRgh+Pany9OAxyDn2k94bv97PI6epfpRyZTQ+fViTRdQoEWDoPfZzo00mjeQ+ sSXDFsUPY11Hq37eVFahHLar+m4navcmilAJ6lHVJr14/NAxtb7uol3s8fenjfX69Tid tyFdSa1jyTlsTjKnVHLKq35ReM2tiKILhe5V/NnN9/lF/Vutj+6IRjqxiN9dpU1gIPy1 qE0hDBb/efmwgpzi9WSf+D6vKPRbM1zWt3Mmoz9wW9CiFwbEqv2fkxQ+n1VUqotExZeA kTL9MH9VOsFLthgd6KICtDowzmrYhtgfVWs7pVjlgE/eP2AL6Jb0clDxgGunf26jpRko dYXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UN2FWfxtmTvTgPTJlbLtgk/SxaHl1REeGMaSieqXqSI=; b=TMI0WvzBj0Eq8O+3oBf+8drbRbuIMUYvQsIRZ6NYEPF8YAsUx08MBL7M0Cm24yyptE n47PZblDeRFs20VBeU+Xr4ySAyEs0M+y0W9431oGanZPB45LgCNDQnxm198gliFVBaLw YakFx8A7me7J64ihoUAGS0S+teOP79IpBIAJJmHjU6JGdAXm6a1LJ167i0TWRogIG89m sFn2jP+L1SMMTClM0FgYHdN0quVC/aCJ1AJ21zv7WiXjTgUgAK7HzUUthgUqPJveZKJU mv7Rd8DOC3TNwyTVrKxnDuh5uMnc0v7Z0N+c5S5JWIB3j7ZJ4EhTgPlEf0rJcJ5p4GeO BD7g== X-Gm-Message-State: AOAM533uwZJKRnu3RHgBfk3EqHjYR9Rl2YrCXmYdCVhBme1kG/xeh4LI OYOLjZ/06zsMQOmjHBs4oC5yAw== X-Google-Smtp-Source: ABdhPJyR5fkxUwkWlOiAAx7vI6e0PEUGQvedASQSlIpBX120GGr9MWkesmZ8ZC1n5xD0Ynqz+r28HQ== X-Received: by 2002:a19:8447:: with SMTP id g68mr14007451lfd.132.1590395477604; Mon, 25 May 2020 01:31:17 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:425b:15e7:251c:5b3:d625:2d43? ([2a00:1fa0:425b:15e7:251c:5b3:d625:2d43]) by smtp.gmail.com with ESMTPSA id b15sm4643322lfa.74.2020.05.25.01.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2020 01:31:16 -0700 (PDT) Subject: Re: [PATCH v6 1/4] MIPS: Do not flush tlb page when updating PTE entry From: Sergei Shtylyov To: Bibo Mao , Thomas Bogendoerfer , Jiaxun Yang , Huacai Chen , Andrew Morton , Paul Burton , Dmitry Korotin , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Stafford Horne , Steven Price , Anshuman Khandual Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , "Maciej W. Rozycki" , linux-mm@kvack.org, David Hildenbrand References: <1590375160-6997-1-git-send-email-maobibo@loongson.cn> <79778fc3-c029-272b-358e-4f8f8e5772d3@cogentembedded.com> Message-ID: <0a38f25d-dba0-688f-4588-345c861325aa@cogentembedded.com> Date: Mon, 25 May 2020 11:31:10 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <79778fc3-c029-272b-358e-4f8f8e5772d3@cogentembedded.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.05.2020 11:12, Sergei Shtylyov wrote: >> It is not necessary to flush tlb page on all CPUs if suitable PTE >> entry exists already during page fault handling, just updating >> TLB is fine. >> >> Here redefine flush_tlb_fix_spurious_fault as empty on MIPS system. >=20 > =C2=A0=C2=A0 Need empty line here. >=20 >> V6: >> - Add update_mmu_tlb function as empty on all platform except mips >> =C2=A0=C2=A0 system, we use this function to update local tlb for page= fault >> =C2=A0=C2=A0 smp-race handling >> V5: >> - define update_mmu_cache function specified on MIPS platform, and >> =C2=A0=C2=A0 add page fault smp-race stats info >> V4: >> - add pte_sw_mkyoung function to implement readable privilege, and >> =C2=A0=C2=A0 this function is=C2=A0 only in effect on MIPS system. >> - add page valid bit judgement in function pte_modify >> V3: >> - add detailed changelog, modify typo issue in patch V2 >> v2: >> - split flush_tlb_fix_spurious_fault and tlb update into two patches >> - comments typo modification >> - separate tlb update and add pte readable privilege into two patches >=20 > =C2=A0 It was a bad idea to keep the version change log in the 1st pat= ch only, > we have either cover letter for that, or all the individual patches... Sorry for noticing this only now. With 4 patches, you should have a c= over=20 letter anyway... >> Signed-off-by: Bibo Mao > [...] MBR, Sergei