From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31A8CC77B6E for ; Thu, 13 Apr 2023 20:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 633C76B0072; Thu, 13 Apr 2023 16:39:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E21C6B0074; Thu, 13 Apr 2023 16:39:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A9F46B0075; Thu, 13 Apr 2023 16:39:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3B3476B0072 for ; Thu, 13 Apr 2023 16:39:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ED7F2A0400 for ; Thu, 13 Apr 2023 20:39:33 +0000 (UTC) X-FDA: 80677533426.19.01BB776 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 265C61C0004 for ; Thu, 13 Apr 2023 20:39:30 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SkfWrwbU; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681418371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Quj1iiD9LgkSGI0NKmJzsno1BF3Rj6KCB6GiyGlg2P0=; b=282Tp+zgTjo7ORktMzUfYVEumYafM5j6VXV7mnw71XUxsXBL0iNDXm+q0la6UYnGzwXYoq sJmSYZTcwKmJuwC7GNfaHdiTpAQSsZ8AwYKjTOUO5opnRPv5t0btP11k2s2VMQD33ZnH+X cdaagXqas43I/uydK6d9ZCm65ejoJyo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SkfWrwbU; spf=pass (imf18.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681418371; a=rsa-sha256; cv=none; b=3qs5xR65RBCzceg8XFho03sARHArfNGS6RHl7EQOJGuNUffXOvO1e8G8yplnMD/5Nb+DMW C4/znRnRsiuJklfBCbove5datJKbmBgvuSGzr25EVp5/9sWYDtdIYT7dW+I9DEb8SDkVNF ASkjBPiwv+3JC0Wn0LIIwf7NwEds+Io= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681418370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Quj1iiD9LgkSGI0NKmJzsno1BF3Rj6KCB6GiyGlg2P0=; b=SkfWrwbU5PBZGmVI5IZ5/80nHv7CbK+tZoUcCRbu9AFSm3cZ3k9oxhUpjF5LWJpxuXBc+O AelTi2tnKfVHgakY24tHtWvdYcwpE0VZkZrsdYI+C8ysSE2xVZX4rwCEcE73JjBnRmj+h5 /TYm4EkEna7E9iO8P6onHOatDkiJjis= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-U6VXJyF_P7SHq6_28nlFzw-1; Thu, 13 Apr 2023 16:39:27 -0400 X-MC-Unique: U6VXJyF_P7SHq6_28nlFzw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BA11C2814255; Thu, 13 Apr 2023 20:39:25 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CA6340C6E70; Thu, 13 Apr 2023 20:39:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230413042917.GA3390869@ZenIV> References: <20230413042917.GA3390869@ZenIV> <20230411160902.4134381-1-dhowells@redhat.com> <20230411160902.4134381-2-dhowells@redhat.com> <20230413005129.GZ3390869@ZenIV> To: Al Viro Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Willem de Bruijn Subject: Re: [PATCH net-next v6 01/18] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1147765.1681418362.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 13 Apr 2023 21:39:22 +0100 Message-ID: <1147766.1681418362@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Queue-Id: 265C61C0004 X-Stat-Signature: mnekefekszgmripu5y4igo3ha7bj84od X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681418370-868019 X-HE-Meta: U2FsdGVkX1/2x4y0FGiHR6qEeE0zpl4DZMq3kklaRYNPHt07UCwY+lDRLsNBLrTcLyfLjEFYYqJIim1VyfnmK6TC0HACAmWaFJE8N7LW4O0NgMDwutLawysYM66gEMYXT/2exmSDgNEFxTF4Xrv5EYeEZDwduikyAF1lJgjQRSinKmxiGM5KJZ3bHUuJqt+cPj9GR2c4FbMAEirqJvQcrW+1SN/TYrSrUb2STwYQ1vMHJItNJms5f+cIC25xKH+ay4UzYsIPAIMfadYGClBeibXaWSKehIc81p7ddjBJWijPsOZBbnEFFG5/ixk8B2Mtl4bXcYGyOpl6s7+L5OXt588SDxuUfczb1tyKYK0eDJwycV5AUgwjfVRQCi2Pd94HNe/nd/B7y9AXQco3LHddbwRTqkDWj/YdjojPnVktx80uDoU3JxYEgiA2RdR296Cs3um5FTbRwV0cyK/EPS3XGogczzBBRwdKcZkGhLefpRK2AIPG0KgTzpGDu0ync7twhTLBqBfoxb/6MZrAbDOlUomnIL151f6Ci1UIB505rora3DJJ/RgCYbW8nw8BWZtEi7on+LDpCN6M9qSMJllDsKKVQle/AThJysLxT6QZ/UtXhn+RQUPrqBeSpLW61AC61fnBfceksa2mMSE+QNbWJg84YykYBG07xzqotXUEKnp1npi9DcqDDjGoP7yznB387oEs579sY71NBb3TlkNCuMIw60LC4r/isVtssUTxT8Zbk160p9MWfNLtPQDLKRxw/DIXKx53JrHD7Nwu8HMqJh6gW7zYQJvkKDICt2cBJxY5DuUyRPZYF7Gfo9F3W9CquBhBgakeyRLkta9oSvnbBbtp/wGqx6Yrc45gFQGNg2fupM8PwqZfKDD00PfFcSBbZVbyrOTyhninlwiQF3VQk/MByU2MESU5DtF4McBO8fM5a/UyS/PgxyRLN8kyln8doobxnOE8Q+n63gtPQ7c IS9F6KtU +Xb3RfWD7ay0y3N0FLFhcmEGTlb7aKSLwcPlYHz+ufkyFIW6Q5y1Wo2Ig1uq2NgIZtbhu0U4OMa+FtwNCvFZAUFHO954UtuWDVnbBHmARFMLtmtzc1VFlEKxILXrNouoxWCTrns25WJnJu82Zp4aGLDXzCPKCFvKmoRCuR+0HaqZxppqF7K2758u9fKqjxe827dAthdCp/bpMA+featDp+zV4PurQstJ4Jh7Q8KuRPXP//RAvMzQKIEEFLBas1+0FUi3pE95nSWB0VK5rqDXNAvn3y+DjlO5ZWcvRvIZYVlSP1Dban+XyzDin1e2wdOgteQZcoxB/TxqHJ8pF/MvGmsh/H5aNShpssHvF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Al Viro wrote: > Note that io_sendmsg_prep() handles both IORING_OP_SENDMSG and IORING_OP= _SEND, > so this pair of functions can hit the same request. And sqe->msg_flags = is > not sanitized at all - it comes straight from user buffer. Assuming ____sys_sendmsg() is fixed, I think it should be sufficient to ma= ke io_send() and io_send_zc(). io_sendmsg() and io_sendmsg_zc() will go thro= ugh ____sys_sendmsg(). David