linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: Dave Chinner <david@fromorbit.com>,
	linux-mm@kvack.org, Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [bug, 5.2.16] kswapd/compaction null pointer crash [was Re: xfs_inode not reclaimed/memory leak on 5.2.16]
Date: Mon, 21 Oct 2019 10:13:57 +0200	[thread overview]
Message-ID: <1320f774-f9ca-cd4e-b515-7431feaddc20@suse.cz> (raw)
In-Reply-To: <87sgnqc5ta.fsf@mid.deneb.enyo.de>

On 10/18/19 7:38 PM, Florian Weimer wrote:
> * Vlastimil Babka:
> 
>> Thanks. Looks like it's indeed here in the page_to_pfn() embedded in the
>> clear_pageblock_skip() expansion. We've got a wrong struct page pointer,
>> so page_to_section gives us a bogus value, __nr_to_section() a null
>> pointer, and __section_mem_map_addr then accesses it.
>>
>> Hopefully the commit [1] should address the reason why we got a wrong
>> page pointer. You could try cherry-picking it to your stable tree, or
>> wait until it appears in a (hopefully near) future stable 5.3.y (5.2 is
>> EOL, so it won't appear there).
> 
> The commit reference appears to be missing. 8->

Oops, it was this:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2e9a5afce080226edbf1882d63d99bf32070e9e

> Due to hardware changes, I've switched back to a distribution kernel
> for now, so I won't see the issue in a while even if it is present in
> newer kernels, too.  Sorry.

I see. Let's hope it was the correct fix then.


      reply	other threads:[~2019-10-21  8:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87pnji8cpw.fsf@mid.deneb.enyo.de>
     [not found] ` <20190930085406.GP16973@dread.disaster.area>
     [not found]   ` <87o8z1fvqu.fsf@mid.deneb.enyo.de>
2019-09-30 21:17     ` [bug, 5.2.16] kswapd/compaction null pointer crash [was Re: xfs_inode not reclaimed/memory leak on 5.2.16] Dave Chinner
2019-09-30 21:42       ` Florian Weimer
2019-10-01  9:10       ` Vlastimil Babka
2019-10-01 19:40         ` Florian Weimer
2019-10-07 13:28           ` Vlastimil Babka
2019-10-07 13:56             ` Vlastimil Babka
2019-10-08  8:52               ` Mel Gorman
2019-10-16 19:38         ` Florian Weimer
2019-10-16 20:03           ` Vlastimil Babka
2019-10-18 17:38             ` Florian Weimer
2019-10-21  8:13               ` Vlastimil Babka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320f774-f9ca-cd4e-b515-7431feaddc20@suse.cz \
    --to=vbabka@suse.cz \
    --cc=david@fromorbit.com \
    --cc=fw@deneb.enyo.de \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).