From: David Hildenbrand <david@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-perf-users@vger.kernel.org,
selinux@vger.kernel.org,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>
Subject: Re: [PATCH v2 2/4] drm/amdkfd: use vma_is_initial_stack() and vma_is_initial_heap()
Date: Wed, 19 Jul 2023 10:18:37 +0200 [thread overview]
Message-ID: <149bdc44-eba1-1615-dd12-c3c324426dca@redhat.com> (raw)
In-Reply-To: <20230719075127.47736-3-wangkefeng.wang@huawei.com>
On 19.07.23 09:51, Kefeng Wang wrote:
> Use the helpers to simplify code.
>
> Cc: Felix Kuehling <Felix.Kuehling@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 5ff1a5a89d96..0b7bfbd0cb66 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -2621,10 +2621,7 @@ svm_range_get_range_boundaries(struct kfd_process *p, int64_t addr,
> return -EFAULT;
> }
>
> - *is_heap_stack = (vma->vm_start <= vma->vm_mm->brk &&
> - vma->vm_end >= vma->vm_mm->start_brk) ||
> - (vma->vm_start <= vma->vm_mm->start_stack &&
> - vma->vm_end >= vma->vm_mm->start_stack);
> + *is_heap_stack = vma_is_initial_heap(vma) || vma_is_initial_stack(vma);
>
> start_limit = max(vma->vm_start >> PAGE_SHIFT,
> (unsigned long)ALIGN_DOWN(addr, 2UL << 8));
Certainly a valid refactoring, although questionable if such code should
care about that.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-19 8:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 7:51 [PATCH v2 0/4] mm: convert to vma_is_initial_heap/stack() Kefeng Wang
2023-07-19 7:51 ` [PATCH v2 1/4] mm: factor out VMA stack and heap checks Kefeng Wang
2023-07-19 8:18 ` David Hildenbrand
2023-07-19 7:51 ` [PATCH v2 2/4] drm/amdkfd: use vma_is_initial_stack() and vma_is_initial_heap() Kefeng Wang
2023-07-19 8:18 ` David Hildenbrand [this message]
2023-07-19 14:24 ` Felix Kuehling
2023-07-19 7:51 ` [PATCH v2 3/4] selinux: " Kefeng Wang
2023-07-19 8:18 ` David Hildenbrand
2023-07-19 9:02 ` Christian Göttsche
2023-07-19 10:22 ` Kefeng Wang
2023-07-19 15:25 ` Paul Moore
2023-07-20 8:28 ` Kefeng Wang
2023-07-20 21:16 ` Paul Moore
2023-07-19 7:51 ` [PATCH v2 4/4] perf/core: " Kefeng Wang
2023-07-19 8:21 ` David Hildenbrand
2023-07-19 9:29 ` Peter Zijlstra
2023-07-19 10:26 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149bdc44-eba1-1615-dd12-c3c324426dca@redhat.com \
--to=david@redhat.com \
--cc=Felix.Kuehling@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=selinux@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).