From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C241C433DF for ; Tue, 26 May 2020 22:01:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 508C92088E for ; Tue, 26 May 2020 22:01:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="K9gsZ8zT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 508C92088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F20FD800B7; Tue, 26 May 2020 18:01:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF88680010; Tue, 26 May 2020 18:01:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0EF0800B7; Tue, 26 May 2020 18:01:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id C7B3380010 for ; Tue, 26 May 2020 18:01:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8E646180AD81D for ; Tue, 26 May 2020 22:01:11 +0000 (UTC) X-FDA: 76860241542.20.wool40_2b1858826d4d X-HE-Tag: wool40_2b1858826d4d X-Filterd-Recvd-Size: 4001 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 22:01:10 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id n15so426652pjt.4 for ; Tue, 26 May 2020 15:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zZVgy2vaY7jEFsggwCG3LBMwvCBMjEaLZHkHxTnDDvk=; b=K9gsZ8zT3cxt3GfgIQHanpf/B7CYXSinl0fcm7TRKezmf7jNWFWuXK+2GFdvo43dDr of6KBrANKEoFtQEfW+djWPeH0LH0Zm5gZVqc5NlYGuR8lsDDUg7oBlRqifrDnq48XVov upxTuDkTmsiG1WqlkzqjLLUjlrUNGDYqVlHzuP6bFTEV2/moAaELS2MB1SlvtcOat8mW 0JI/GSptTLODrg0ShTKIf4XF/8jQEDrlqDGYM9Gp71cATmHJkoAYvxo9V1kYEFn3wmFb 8cxmiU5tvOI7O2/Z7M3F2d7B4v1eVkWH/NXTE+aCVDQHPP7DS3JXcwP0CA8UziWFDWE8 pISA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zZVgy2vaY7jEFsggwCG3LBMwvCBMjEaLZHkHxTnDDvk=; b=toekp1zl9JODPhapJZUgd1iINIkd/mw1BpFwbwSsFMTyrwZ5P0HdBc6pKrGM5a+Fhd yDqdUZn+0FEo//V361u27Vt1evPNre0hf/FdhafD3JXN4Df+7nUXsNPQOpm1miZt8KL1 zB/TjfkSoRjh82QEXyM31fb0q8iNEyx+SzsW35ywi36v7F/1MO3EXO9nCeEIVPgnJQ7I NhqjpDf5x2ybR4VIpCThLjiczq1sJIdo5zq4GpK1dyTG2OgNav02JRVeWDxFhZ490q8X 9Esk0dhYDqRen3gbiYscsr8yKJOGeMOgNgmJg7RQTN2QwZDN9tpu5vpLMX8CWSjTFwI2 uIMQ== X-Gm-Message-State: AOAM532u5qw+jB4eTUCKZ1ceifWLVeOGx2q9V/Kt3bj65OM63CIXR3Tz 2CrHbqQx6E82wt16bEDx0kmgQw== X-Google-Smtp-Source: ABdhPJxLoWUFI2rzzX/tNrCylqa6XrMiWoTpJfv3EtVvMY4+UBWsKa7NQ24TWARybP1JK1WaB1gM2A== X-Received: by 2002:a17:90a:8404:: with SMTP id j4mr1339430pjn.12.1590530469655; Tue, 26 May 2020 15:01:09 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:8c61:4922:2226:8cd7:a61e? ([2605:e000:100e:8c61:4922:2226:8cd7:a61e]) by smtp.gmail.com with ESMTPSA id d195sm442643pfd.52.2020.05.26.15.01.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 15:01:09 -0700 (PDT) Subject: Re: [PATCH 04/12] mm: add support for async page locking To: Johannes Weiner Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org References: <20200526195123.29053-1-axboe@kernel.dk> <20200526195123.29053-5-axboe@kernel.dk> <20200526215925.GC6781@cmpxchg.org> From: Jens Axboe Message-ID: <152529a5-adb4-fd7b-52ac-967500c011c9@kernel.dk> Date: Tue, 26 May 2020 16:01:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200526215925.GC6781@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/26/20 3:59 PM, Johannes Weiner wrote: > On Tue, May 26, 2020 at 01:51:15PM -0600, Jens Axboe wrote: >> Normally waiting for a page to become unlocked, or locking the page, >> requires waiting for IO to complete. Add support for lock_page_async() >> and wait_on_page_locked_async(), which are callback based instead. This > > wait_on_page_locked_async() is actually in the next patch, requiring > some back and forth to review. I wonder if this and the next patch > could be merged to have the new API and callers introduced together? I'm fine with that, if that is preferable. Don't feel strongly about that at all, just tried to do it as piecemeal as possible to make it easier to review. -- Jens Axboe