From: David Rientjes <rientjes@google.com>
To: Julian Pidancet <julian.pidancet@oracle.com>
Cc: Christoph Lameter <cl@linux.com>,
"Lameter, Christopher" <cl@os.amperecomputing.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH v2] mm/slub: disable slab merging in the default configuration
Date: Thu, 6 Jul 2023 00:38:31 -0700 (PDT) [thread overview]
Message-ID: <17349901-df3a-494e-fa71-2584d92526b5@google.com> (raw)
In-Reply-To: <8813897d-4a52-37a0-fe44-a9157716be9b@google.com>
On Mon, 3 Jul 2023, David Rientjes wrote:
> hackbench
Running hackbench on Skylake with v6.1.30 (A) and v6.1.30 + your patch
(B), for example:
LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV | DIRECTION
--------------------------------+-------+------------+------------+------------+------------+-----------+----------------
SReclaimable | | | | | | |
(A) v6.1.30 | 11 | 129480.000 | 233208.000 | 189936.364 | 204316.000 | 31465.625 |
(B) <same sha> | 11 | 139084.000 | 236772.000 | 198931.273 | 213672.000 | 30013.204 |
| | +7.42% | +1.53% | +4.74% | +4.58% | -4.62% | <not defined>
SUnreclaim | | | | | | |
(A) v6.1.30 | 11 | 305400.000 | 538744.000 | 422148.000 | 449344.000 | 65005.045 |
(B) <same sha> | 11 | 305780.000 | 518300.000 | 422219.636 | 450252.000 | 61245.137 |
| | +0.12% | -3.79% | +0.02% | +0.20% | -5.78% | <not defined>
Amount of reclaimable slab significantly increases which is likely not a
problem because, well, it's reclaimable. But I suspect we'll find other
interesting data points with the other suggested benchmarks.
And benchmark results:
LABEL | COUNT | MIN | MAX | MEAN | MEDIAN | STDDEV | DIRECTION
--------------------------------+-------+------------+------------+------------+------------+-----------+----------------
hackbench_process_pipes_234 | | | | | | |
(A) v6.1.30 | 7 | 1.735 | 1.979 | 1.831 | 1.835 | 0.086291 |
(B) <same sha> | 7 | 1.687 | 2.023 | 1.886 | 1.911 | 0.10276 |
| | -2.77% | +2.22% | +3.00% | +4.14% | +19.09% | <not defined>
hackbench_process_pipes_max | | | | | | |
(A) v6.1.30 | 7 | 1.735 | 1.979 | 1.831 | 1.835 | 0.086291 |
(B) <same sha> | 7 | 1.687 | 2.023 | 1.886 | 1.911 | 0.10276 |
| | -2.77% | +2.22% | +3.00% | +4.14% | +19.09% | - is good
hackbench_process_sockets_234 | | | | | | |
(A) v6.1.30 | 7 | 7.883 | 7.909 | 7.899 | 7.899 | 0.0087808 |
(B) <same sha> | 7 | 7.872 | 7.961 | 7.907 | 7.904 | 0.028019 |
| | -0.14% | +0.66% | +0.10% | +0.06% | +219.09% | <not defined>
hackbench_process_sockets_max | | | | | | |
(A) v6.1.30 | 7 | 7.883 | 7.909 | 7.899 | 7.899 | 0.0087808 |
(B) <same sha> | 7 | 7.872 | 7.961 | 7.907 | 7.904 | 0.028019 |
| | -0.14% | +0.66% | +0.10% | +0.06% | +219.09% | - is good
hackbench_thread_pipes_234 | | | | | | |
(A) v6.1.30 | 7 | 2.146 | 2.677 | 2.410 | 2.418 | 0.18143 |
(B) <same sha> | 7 | 2.016 | 2.514 | 2.268 | 2.241 | 0.17474 |
| | -6.06% | -6.09% | -5.88% | -7.32% | -3.69% | <not defined>
hackbench_thread_pipes_max | | | | | | |
(A) v6.1.30 | 7 | 2.146 | 2.677 | 2.410 | 2.418 | 0.18143 |
(B) <same sha> | 7 | 2.016 | 2.514 | 2.268 | 2.241 | 0.17474 |
| | -6.06% | -6.09% | -5.88% | -7.32% | -3.69% | - is good
hackbench_thread_sockets_234 | | | | | | |
(A) v6.1.30 | 7 | 8.025 | 8.127 | 8.084 | 8.085 | 0.029755 |
(B) <same sha> | 7 | 7.990 | 8.093 | 8.042 | 8.035 | 0.035152 |
| | -0.44% | -0.42% | -0.53% | -0.62% | +18.14% | <not defined>
hackbench_thread_sockets_max | | | | | | |
(A) v6.1.30 | 7 | 8.025 | 8.127 | 8.084 | 8.085 | 0.029755 |
(B) <same sha> | 7 | 7.990 | 8.093 | 8.042 | 8.035 | 0.035152 |
| | -0.44% | -0.42% | -0.53% | -0.62% | +18.14% | - is good
next prev parent reply other threads:[~2023-07-06 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 22:19 [PATCH v2] mm/slub: disable slab merging in the default configuration Julian Pidancet
2023-07-03 0:09 ` David Rientjes
2023-07-03 10:33 ` Julian Pidancet
2023-07-03 18:38 ` Kees Cook
2023-07-03 20:17 ` David Rientjes
2023-07-06 7:38 ` David Rientjes [this message]
2023-07-09 8:55 ` David Rientjes
2023-07-10 2:40 ` David Rientjes
2023-07-18 12:08 ` Julian Pidancet
2023-07-25 23:25 ` David Rientjes
2023-07-26 8:34 ` Vlastimil Babka
2023-07-10 14:56 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17349901-df3a-494e-fa71-2584d92526b5@google.com \
--to=rientjes@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=cl@linux.com \
--cc=cl@os.amperecomputing.com \
--cc=corbet@lwn.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=julian.pidancet@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).