From: Gang Li <gang.li@linux.dev>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
David Rientjes <rientjes@google.com>,
Muchun Song <muchun.song@linux.dev>,
Tim Chen <tim.c.chen@linux.intel.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Jane Chu <jane.chu@oracle.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ligang.bdlg@bytedance.com
Subject: Re: [PATCH v6 8/8] hugetlb: parallelize 1G hugetlb initialization
Date: Tue, 12 Mar 2024 10:26:07 +0800 [thread overview]
Message-ID: <1c6f90d0-ef3a-4ea4-8de6-ad93c93ed3da@linux.dev> (raw)
In-Reply-To: <vbj76pzf5mvooydne5fg2ewgjiducgficskq7hcsdxwywsda7l@qisdlq5q2n3o>
Thanks for your review :)
On 2024/3/9 01:35, Daniel Jordan wrote:
> On Thu, Feb 22, 2024 at 10:04:21PM +0800, Gang Li wrote:
>> Optimizing the initialization speed of 1G huge pages through
>> parallelization.
>>
>> 1G hugetlbs are allocated from bootmem, a process that is already
>> very fast and does not currently require optimization. Therefore,
>> we focus on parallelizing only the initialization phase in
>> `gather_bootmem_prealloc`.
>>
>> Here are some test results:
>> test case no patch(ms) patched(ms) saved
>> ------------------- -------------- ------------- --------
>> 256c2T(4 node) 1G 4745 2024 57.34%
>> 128c1T(2 node) 1G 3358 1712 49.02%
>> 12T 1G 77000 18300 76.23%
>
> Another great improvement.
>
>> +static void __init gather_bootmem_prealloc_parallel(unsigned long start,
>> + unsigned long end, void *arg)
>> +{
>> + int nid;
>> +
>> + for (nid = start; nid < end; nid++)
>> + gather_bootmem_prealloc_node(nid);
>> +}
>> +
>> +static void __init gather_bootmem_prealloc(void)
>> +{
>> + struct padata_mt_job job = {
>> + .thread_fn = gather_bootmem_prealloc_parallel,
>> + .fn_arg = NULL,
>> + .start = 0,
>> + .size = num_node_state(N_MEMORY),
>> + .align = 1,
>> + .min_chunk = 1,
>> + .max_threads = num_node_state(N_MEMORY),
>> + .numa_aware = true,
>> + };
>> +
>> + padata_do_multithreaded(&job);
>> +}
>
> Looks fine from the padata side.
>
> Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com> # padata
prev parent reply other threads:[~2024-03-12 2:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 14:04 [PATCH v6 0/8] hugetlb: parallelize hugetlb page init on boot Gang Li
2024-02-22 14:04 ` [PATCH v6 1/8] hugetlb: code clean for hugetlb_hstate_alloc_pages Gang Li
2024-02-22 14:04 ` [PATCH v6 2/8] hugetlb: split hugetlb_hstate_alloc_pages Gang Li
2024-02-22 14:04 ` [PATCH v6 3/8] hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc Gang Li
2024-02-22 14:04 ` [PATCH v6 4/8] padata: dispatch works on different nodes Gang Li
2024-02-27 21:24 ` Daniel Jordan
2024-03-05 2:49 ` Gang Li
2024-03-08 15:42 ` Daniel Jordan
2024-02-22 14:04 ` [PATCH v6 5/8] padata: downgrade padata_do_multithreaded to serial execution for non-SMP Gang Li
2024-02-27 21:26 ` Daniel Jordan
2024-03-05 3:24 ` Gang Li
2024-02-22 14:04 ` [PATCH v6 6/8] hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA Gang Li
2024-02-27 21:26 ` Daniel Jordan
2024-02-22 14:04 ` [PATCH v6 7/8] hugetlb: parallelize 2M hugetlb allocation and initialization Gang Li
2024-03-08 17:11 ` Daniel Jordan
2024-02-22 14:04 ` [PATCH v6 8/8] hugetlb: parallelize 1G hugetlb initialization Gang Li
2024-03-08 17:35 ` Daniel Jordan
2024-03-12 2:26 ` Gang Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c6f90d0-ef3a-4ea4-8de6-ad93c93ed3da@linux.dev \
--to=gang.li@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=david@redhat.com \
--cc=jane.chu@oracle.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=paulmck@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=steffen.klassert@secunet.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).