From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>,
n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/memory-failure.c: PageHuge is handled at the beginning of memory_failure
Date: Tue, 19 Nov 2019 13:23:54 +0100 [thread overview]
Message-ID: <1e61c115-5787-9ef4-a449-2e490c53fca7@redhat.com> (raw)
In-Reply-To: <20191118082003.26240-1-richardw.yang@linux.intel.com>
On 18.11.19 09:20, Wei Yang wrote:
> PageHuge is handled by memory_failure_hugetlb(), so this case could be
> removed.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> mm/memory-failure.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 3151c87dff73..392ac277b17d 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1359,10 +1359,7 @@ int memory_failure(unsigned long pfn, int flags)
> * page_remove_rmap() in try_to_unmap_one(). So to determine page status
> * correctly, we save a copy of the page flags at this time.
> */
> - if (PageHuge(p))
> - page_flags = hpage->flags;
> - else
> - page_flags = p->flags;
> + page_flags = p->flags;
>
> /*
> * unpoison always clear PG_hwpoison inside page lock
>
I somewhat miss a proper explanation why this is safe to do. We access
page flags here, so why is it safe to refer to the ones of the sub-page?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-11-19 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 8:20 [PATCH 1/2] mm/memory-failure.c: PageHuge is handled at the beginning of memory_failure Wei Yang
2019-11-18 8:20 ` [PATCH 2/2] mm/memory-failure.c: not necessary to recalculate hpage Wei Yang
2019-11-20 15:07 ` David Hildenbrand
2019-11-21 1:05 ` Wei Yang
2019-12-02 22:28 ` Wei Yang
2019-12-05 15:06 ` David Hildenbrand
2019-12-06 1:48 ` Wei Yang
2020-01-08 12:20 ` David Hildenbrand
2020-01-09 1:58 ` Wei Yang
2019-11-19 12:23 ` David Hildenbrand [this message]
2019-11-20 0:46 ` [PATCH 1/2] mm/memory-failure.c: PageHuge is handled at the beginning of memory_failure Wei Yang
2019-11-20 15:04 ` David Hildenbrand
2019-11-21 1:07 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e61c115-5787-9ef4-a449-2e490c53fca7@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).