From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Vlastimil Babka <vbabka@suse.cz>,
dri-devel@lists.freedesktop.org, Hugh Dickins <hughd@google.com>,
John Einar Reitan <john.reitan@foss.arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Mel Gorman <mgorman@suse.de>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Rafael Aquini <aquini@redhat.com>, Rik van Riel <riel@redhat.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
virtualization@lists.linux-foundation.org,
Gioh Kim <gi-oh.kim@profitbricks.com>,
Chan Gyun Jeong <chan.jeong@lge.com>,
Sangseok Lee <sangseok.lee@lge.com>,
Kyeongdon Kim <kyeongdon.kim@lge.com>,
Chulmin Kim <cmlaika.kim@samsung.com>
Subject: Re: [PATCH v7 00/12] Support non-lru page migration
Date: Thu, 16 Jun 2016 11:58:00 +0900 [thread overview]
Message-ID: <20160616025800.GO17127@bbox> (raw)
In-Reply-To: <20160616024827.GA497@swordfish>
On Thu, Jun 16, 2016 at 11:48:27AM +0900, Sergey Senozhatsky wrote:
> Hi,
>
> On (06/16/16 08:12), Minchan Kim wrote:
> > > [ 315.146533] kasan: CONFIG_KASAN_INLINE enabled
> > > [ 315.146538] kasan: GPF could be caused by NULL-ptr deref or user memory access
> > > [ 315.146546] general protection fault: 0000 [#1] PREEMPT SMP KASAN
> > > [ 315.146576] Modules linked in: lzo zram zsmalloc mousedev coretemp hwmon crc32c_intel r8169 i2c_i801 mii snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hda_core acpi_cpufreq snd_pcm snd_timer snd soundcore lpc_ich mfd_core processor sch_fq_codel sd_mod hid_generic usbhid hid ahci libahci libata ehci_pci ehci_hcd scsi_mod usbcore usb_common
> > > [ 315.146785] CPU: 3 PID: 38 Comm: khugepaged Not tainted 4.7.0-rc3-next-20160614-dbg-00004-ga1c2cbc-dirty #488
> > > [ 315.146841] task: ffff8800bfaf2900 ti: ffff880112468000 task.ti: ffff880112468000
> > > [ 315.146859] RIP: 0010:[<ffffffffa02c413d>] [<ffffffffa02c413d>] zs_page_migrate+0x355/0xaa0 [zsmalloc]
> >
> > Thanks for the report!
> >
> > zs_page_migrate+0x355? Could you tell me what line is it?
> >
> > It seems to be related to obj_to_head.
>
> reproduced. a bit different call stack this time. but the problem is
> still the same.
>
> zs_compact()
> ...
> 6371: e8 00 00 00 00 callq 6376 <zs_compact+0x22b>
> 6376: 0f 0b ud2
> 6378: 48 8b 95 a8 fe ff ff mov -0x158(%rbp),%rdx
> 637f: 4d 8d 74 24 78 lea 0x78(%r12),%r14
> 6384: 4c 89 ee mov %r13,%rsi
> 6387: 4c 89 e7 mov %r12,%rdi
> 638a: e8 86 c7 ff ff callq 2b15 <get_first_obj_offset>
> 638f: 41 89 c5 mov %eax,%r13d
> 6392: 4c 89 f0 mov %r14,%rax
> 6395: 48 c1 e8 03 shr $0x3,%rax
> 6399: 8a 04 18 mov (%rax,%rbx,1),%al
> 639c: 84 c0 test %al,%al
> 639e: 0f 85 f2 02 00 00 jne 6696 <zs_compact+0x54b>
> 63a4: 41 8b 44 24 78 mov 0x78(%r12),%eax
> 63a9: 41 0f af c7 imul %r15d,%eax
> 63ad: 41 01 c5 add %eax,%r13d
> 63b0: 4c 89 f0 mov %r14,%rax
> 63b3: 48 c1 e8 03 shr $0x3,%rax
> 63b7: 48 01 d8 add %rbx,%rax
> 63ba: 48 89 85 88 fe ff ff mov %rax,-0x178(%rbp)
> 63c1: 41 81 fd ff 0f 00 00 cmp $0xfff,%r13d
> 63c8: 0f 87 1a 03 00 00 ja 66e8 <zs_compact+0x59d>
> 63ce: 49 63 f5 movslq %r13d,%rsi
> 63d1: 48 03 b5 98 fe ff ff add -0x168(%rbp),%rsi
> 63d8: 48 8b bd a8 fe ff ff mov -0x158(%rbp),%rdi
> 63df: e8 67 d9 ff ff callq 3d4b <obj_to_head>
> 63e4: a8 01 test $0x1,%al
> 63e6: 0f 84 d9 02 00 00 je 66c5 <zs_compact+0x57a>
> 63ec: 48 83 e0 fe and $0xfffffffffffffffe,%rax
> 63f0: bf 01 00 00 00 mov $0x1,%edi
> 63f5: 48 89 85 b0 fe ff ff mov %rax,-0x150(%rbp)
> 63fc: e8 00 00 00 00 callq 6401 <zs_compact+0x2b6>
> 6401: 48 8b 85 b0 fe ff ff mov -0x150(%rbp),%rax
RAX: 2065676162726166 so rax is totally garbage, I think.
It means obj_to_head returns garbage because get_first_obj_offset is
utter crab because (page_idx / class->pages_per_zspage) was totally
wrong.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 6408: f0 0f ba 28 00 lock btsl $0x0,(%rax)
<snip>
> > Could you test with [zsmalloc: keep first object offset in struct page]
> > in mmotm?
>
> sure, I can. will it help, tho? we have a race condition here I think.
I guess root cause is caused by get_first_obj_offset.
Please test with it.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-16 2:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 23:21 [PATCH v7 00/12] Support non-lru page migration Minchan Kim
2016-05-31 23:21 ` [PATCH v7 01/12] mm: use put_page to free page instead of putback_lru_page Minchan Kim
2016-05-31 23:21 ` [PATCH v7 02/12] mm: migrate: support non-lru movable page migration Minchan Kim
2016-05-31 23:21 ` [PATCH v7 03/12] mm: balloon: use general non-lru movable page feature Minchan Kim
2016-05-31 23:21 ` [PATCH v7 04/12] zsmalloc: keep max_object in size_class Minchan Kim
2016-05-31 23:21 ` [PATCH v7 05/12] zsmalloc: use bit_spin_lock Minchan Kim
2016-05-31 23:21 ` [PATCH v7 06/12] zsmalloc: use accessor Minchan Kim
2016-05-31 23:21 ` [PATCH v7 07/12] zsmalloc: factor page chain functionality out Minchan Kim
2016-05-31 23:21 ` [PATCH v7 08/12] zsmalloc: introduce zspage structure Minchan Kim
2016-05-31 23:21 ` [PATCH v7 09/12] zsmalloc: separate free_zspage from putback_zspage Minchan Kim
2016-05-31 23:21 ` [PATCH v7 10/12] zsmalloc: use freeobj for index Minchan Kim
2016-05-31 23:21 ` [PATCH v7 11/12] zsmalloc: page migration support Minchan Kim
2016-06-01 14:09 ` Vlastimil Babka
2016-06-02 0:25 ` Minchan Kim
2016-06-02 11:44 ` Vlastimil Babka
2016-06-01 21:39 ` Andrew Morton
2016-06-02 0:15 ` Minchan Kim
[not found] ` <CGME20170119001317epcas1p188357c77e1f4ff08b6d3dcb76dedca06@epcas1p1.samsung.com>
2017-01-19 0:13 ` Chulmin Kim
2017-01-19 2:44 ` Minchan Kim
2017-01-19 3:39 ` Chulmin Kim
2017-01-19 6:21 ` Minchan Kim
2017-01-19 8:16 ` Chulmin Kim
2017-01-23 5:22 ` Minchan Kim
2017-01-23 5:30 ` Sergey Senozhatsky
2017-01-23 5:40 ` Minchan Kim
2017-01-25 4:06 ` Chulmin Kim
2017-01-25 4:25 ` Sergey Senozhatsky
2017-01-25 5:26 ` Minchan Kim
2017-01-26 17:04 ` Dan Streetman
2017-01-31 0:10 ` Minchan Kim
2017-01-31 13:09 ` Dan Streetman
2017-02-01 6:51 ` Minchan Kim
2017-02-01 19:38 ` Dan Streetman
2017-02-02 8:48 ` Minchan Kim
2016-05-31 23:21 ` [PATCH v7 12/12] zram: use __GFP_MOVABLE for memory allocation Minchan Kim
2016-06-01 21:41 ` [PATCH v7 00/12] Support non-lru page migration Andrew Morton
2016-06-01 22:40 ` Daniel Vetter
2016-06-02 0:36 ` Minchan Kim
2016-06-15 7:59 ` Sergey Senozhatsky
2016-06-15 23:12 ` Minchan Kim
2016-06-16 2:48 ` Sergey Senozhatsky
2016-06-16 2:58 ` Minchan Kim [this message]
2016-06-16 4:23 ` Sergey Senozhatsky
2016-06-16 4:47 ` Minchan Kim
2016-06-16 5:22 ` Sergey Senozhatsky
2016-06-16 6:47 ` Minchan Kim
2016-06-16 8:42 ` Sergey Senozhatsky
2016-06-16 10:09 ` Minchan Kim
2016-06-17 7:28 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160616025800.GO17127@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=chan.jeong@lge.com \
--cc=cmlaika.kim@samsung.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gi-oh.kim@profitbricks.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=john.reitan@foss.arm.com \
--cc=koct9i@gmail.com \
--cc=kyeongdon.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=sangseok.lee@lge.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).