From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
linux-mm@kvack.org, mike.kravetz@Oracle.com, mhocko@suse.com,
n-horiguchi@ah.jp.nec.com, aneesh.kumar@linux.vnet.ibm.com,
gerald.schaefer@de.ibm.com, zhongjiang@huawei.com,
aarcange@redhat.com, kirill.shutemov@linux.intel.com--dry-run
Subject: Re: [PATCH] mm/hugetlb: Warn the user when issues arise on boot due to hugepages
Date: Tue, 6 Jun 2017 12:03:50 -0700 [thread overview]
Message-ID: <20170606190350.GA20010@bombadil.infradead.org> (raw)
In-Reply-To: <20170605153819.9c86969a73926e4269e77976@linux-foundation.org>
On Mon, Jun 05, 2017 at 03:38:19PM -0700, Andrew Morton wrote:
> It's better to just move memfmt() to the right place. After all, you
> have revealed that it was in the wrong place, no?
>
> (Am a bit surprised that something as general as memfmt is private to
> hugetlb.c)
Oh, hey, look, memory management people and storage people have
their own ideas about "general" code. Storage people have been using
string_get_size() for a while. It feels a bit over-engineered to me,
but since we already have it, we should use it.
---- 8< ----
Subject: [PATCH] Replace memfmt with string_get_size
The hugetlb code has its own function to report human-readable sizes.
Convert it to use the shared string_get_size function. This will lead
to a minor difference in user visible output (MiB/GiB instead of MB/GB),
but some would argue that's desirable anyway.
Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index e5828875f7bb..7f2b7d9f1f45 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -20,6 +20,7 @@
#include <linux/slab.h>
#include <linux/sched/signal.h>
#include <linux/rmap.h>
+#include <linux/string_helpers.h>
#include <linux/swap.h>
#include <linux/swapops.h>
#include <linux/page-isolation.h>
@@ -2207,26 +2208,15 @@ static void __init hugetlb_init_hstates(void)
VM_BUG_ON(minimum_order == UINT_MAX);
}
-static char * __init memfmt(char *buf, unsigned long n)
-{
- if (n >= (1UL << 30))
- sprintf(buf, "%lu GB", n >> 30);
- else if (n >= (1UL << 20))
- sprintf(buf, "%lu MB", n >> 20);
- else
- sprintf(buf, "%lu KB", n >> 10);
- return buf;
-}
-
static void __init report_hugepages(void)
{
struct hstate *h;
for_each_hstate(h) {
char buf[32];
+ string_get_size(huge_page_size(h), 1, STRING_UNITS_2, buf, 32);
pr_info("HugeTLB registered %s page size, pre-allocated %ld pages\n",
- memfmt(buf, huge_page_size(h)),
- h->free_huge_pages);
+ buf, h->free_huge_pages);
}
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-06-06 19:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 0:54 [PATCH] mm/hugetlb: Warn the user when issues arise on boot due to hugepages Liam R. Howlett
2017-06-05 4:57 ` Michal Hocko
2017-06-05 15:15 ` Liam R. Howlett
2017-06-06 5:49 ` Michal Hocko
2017-06-06 6:01 ` Michal Hocko
2017-06-12 17:28 ` Liam R. Howlett
2017-06-12 17:49 ` Michal Hocko
2017-06-12 18:37 ` Liam R. Howlett
2017-06-12 18:52 ` Michal Hocko
2017-06-13 1:35 ` Liam R. Howlett
2017-06-13 5:42 ` Michal Hocko
2017-06-13 15:25 ` Liam R. Howlett
2017-06-13 16:26 ` Mike Kravetz
2017-06-14 7:27 ` Michal Hocko
2017-06-14 17:02 ` Mike Kravetz
2017-06-14 7:25 ` Michal Hocko
2017-06-16 19:07 ` Andrew Morton
2017-06-17 0:25 ` Mike Kravetz
2017-06-17 6:51 ` Michal Hocko
2017-06-19 19:59 ` Liam R. Howlett
2017-06-05 22:38 ` Andrew Morton
2017-06-06 19:03 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606190350.GA20010@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@Oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com--dry-run \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@Oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).