Re: [RFC PATCH 0/4] mm/hotplug: make hotplug memory_block alligned

[Michal Hocko <mhocko@suse.com>]

On Sun 25-06-17 10:52:23, Wei Yang wrote:
> Michal & all
> 
> Previously we found the hotplug range is mem_section aligned instead of
> memory_block.
> 
> Here is several draft patches to fix that. To make sure I am getting your
> point correctly, I post it here before further investigation.

This description doesn't explain what the problem is and why do we want
to fix it. Before diving into the code and review changes it would help
a lot to give a short introduction and explain your intention and your
assumptions you base your changes on.

So please start with a highlevel description first.

> Willing to see your comments. :-)
> 
> Wei Yang (4):
>   mm/hotplug: aligne the hotplugable range with memory_block
>   mm/hotplug: walk_memroy_range on memory_block uit
>   mm/hotplug: make __add_pages() iterate on memory_block and split
>     __add_section()
>   base/memory: pass start_section_nr to init_memory_block()
> 
>  drivers/base/memory.c  | 34 ++++++++++++----------------------
>  include/linux/memory.h |  4 +++-
>  mm/memory_hotplug.c    | 48 +++++++++++++++++++++++++-----------------------
>  3 files changed, 40 insertions(+), 46 deletions(-)
> 
> -- 
> 2.11.0
> 

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>