linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org,
	kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	kasan-dev@googlegroups.com, xen-devel@lists.xen.org,
	linux-mm@kvack.org, iommu@lists.linux-foundation.org
Cc: "Brijesh Singh" <brijesh.singh@amd.com>,
	"Toshimitsu Kani" <toshi.kani@hpe.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Matt Fleming" <matt@codeblueprint.co.uk>,
	"Alexander Potapenko" <glider@google.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Larry Woodman" <lwoodman@redhat.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
	"Dave Young" <dyoung@redhat.com>,
	"Rik van Riel" <riel@redhat.com>, "Arnd Bergmann" <arnd@arndb.de>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Andy Lutomirski" <luto@kernel.org>,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	"Dmitry Vyukov" <dvyukov@google.com>,
	"Juergen Gross" <jgross@suse.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v8 RESEND 11/38] x86/mm: Add SME support for read_cr3_pa()
Date: Tue, 27 Jun 2017 10:09:14 -0500	[thread overview]
Message-ID: <20170627150914.17428.14700.stgit@tlendack-t1.amdoffice.net> (raw)
In-Reply-To: <20170627150718.17428.81813.stgit@tlendack-t1.amdoffice.net>

The cr3 register entry can contain the SME encryption mask that indicates
the PGD is encrypted.  The encryption mask should not be used when
creating a virtual address from the cr3 register, so remove the SME
encryption mask in the read_cr3_pa() function.

During early boot SME will need to use a native version of read_cr3_pa(),
so create native_read_cr3_pa().

Reviewed-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 arch/x86/include/asm/processor-flags.h |    5 +++--
 arch/x86/include/asm/processor.h       |    5 +++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/processor-flags.h b/arch/x86/include/asm/processor-flags.h
index 79aa2f9..f5d3e50 100644
--- a/arch/x86/include/asm/processor-flags.h
+++ b/arch/x86/include/asm/processor-flags.h
@@ -2,6 +2,7 @@
 #define _ASM_X86_PROCESSOR_FLAGS_H
 
 #include <uapi/asm/processor-flags.h>
+#include <linux/mem_encrypt.h>
 
 #ifdef CONFIG_VM86
 #define X86_VM_MASK	X86_EFLAGS_VM
@@ -32,8 +33,8 @@
  * CR3_ADDR_MASK is the mask used by read_cr3_pa().
  */
 #ifdef CONFIG_X86_64
-/* Mask off the address space ID bits. */
-#define CR3_ADDR_MASK 0x7FFFFFFFFFFFF000ull
+/* Mask off the address space ID and SME encryption bits. */
+#define CR3_ADDR_MASK __sme_clr(0x7FFFFFFFFFFFF000ull)
 #define CR3_PCID_MASK 0xFFFull
 #else
 /*
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 8010c97..ab878bd 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -240,6 +240,11 @@ static inline unsigned long read_cr3_pa(void)
 	return __read_cr3() & CR3_ADDR_MASK;
 }
 
+static inline unsigned long native_read_cr3_pa(void)
+{
+	return __native_read_cr3() & CR3_ADDR_MASK;
+}
+
 static inline void load_cr3(pgd_t *pgdir)
 {
 	write_cr3(__sme_pa(pgdir));

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-06-27 15:09 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 15:07 [PATCH v8 RESEND 00/38] x86: Secure Memory Encryption (AMD) Tom Lendacky
2017-06-27 15:07 ` [PATCH v8 RESEND 01/38] x86: Document AMD Secure Memory Encryption (SME) Tom Lendacky
2017-06-27 15:07 ` [PATCH v8 RESEND 02/38] x86/mm/pat: Set write-protect cache mode for full PAT support Tom Lendacky
2017-06-27 15:07 ` [PATCH v8 RESEND 03/38] x86, mpparse, x86/acpi, x86/PCI, x86/dmi, SFI: Use memremap for RAM mappings Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 04/38] x86/CPU/AMD: Add the Secure Memory Encryption CPU feature Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 05/38] x86/CPU/AMD: Handle SME reduction in physical address size Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 06/38] x86/mm: Add Secure Memory Encryption (SME) support Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 07/38] x86/mm: Remove phys_to_virt() usage in ioremap() Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 08/38] x86/mm: Add support to enable SME in early boot processing Tom Lendacky
2017-06-27 15:08 ` [PATCH v8 RESEND 09/38] x86/mm: Simplify p[g4um]d_page() macros Tom Lendacky
2017-06-27 15:09 ` [PATCH v8 RESEND 10/38] x86/mm: Provide general kernel support for memory encryption Tom Lendacky
2017-06-27 15:09 ` Tom Lendacky [this message]
2017-06-27 15:09 ` [PATCH v8 RESEND 12/38] x86/mm: Extend early_memremap() support with additional attrs Tom Lendacky
2017-06-27 15:09 ` [PATCH v8 RESEND 13/38] x86/mm: Add support for early encrypt/decrypt of memory Tom Lendacky
2017-06-27 15:09 ` [PATCH v8 RESEND 14/38] x86/mm: Insure that boot memory areas are mapped properly Tom Lendacky
2017-06-27 15:09 ` [PATCH v8 RESEND 15/38] x86/boot/e820: Add support to determine the E820 type of an address Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 16/38] efi: Add an EFI table address match function Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 17/38] efi: Update efi_mem_type() to return an error rather than 0 Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 18/38] x86/efi: Update EFI pagetable creation to work with SME Tom Lendacky
2017-06-27 15:10 ` [PATCH v8 RESEND 19/38] x86/mm: Add support to access boot related data in the clear Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 20/38] x86, mpparse: Use memremap to map the mpf and mpc data Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 21/38] x86/mm: Add support to access persistent memory in the clear Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 22/38] x86/mm: Add support for changing the memory encryption attribute Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 23/38] x86/realmode: Decrypt trampoline area if memory encryption is active Tom Lendacky
2017-06-27 15:11 ` [PATCH v8 RESEND 24/38] x86, swiotlb: Add memory encryption support Tom Lendacky
2017-06-27 15:12 ` [PATCH v8 RESEND 25/38] swiotlb: Add warnings for use of bounce buffers with SME Tom Lendacky
2017-06-27 15:12 ` [PATCH v8 RESEND 26/38] x86/CPU/AMD: Make the microcode level available earlier in the boot Tom Lendacky
2017-06-27 15:12 ` [PATCH v8 RESEND 27/38] iommu/amd: Allow the AMD IOMMU to work with memory encryption Tom Lendacky
2017-06-28  9:36   ` Joerg Roedel
2017-06-28 14:05     ` Tom Lendacky
2017-06-27 15:12 ` [PATCH v8 RESEND 28/38] x86, realmode: Check for memory encryption on the APs Tom Lendacky
2017-06-27 15:12 ` [PATCH v8 RESEND 29/38] x86, drm, fbdev: Do not specify encrypted memory for video mappings Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 30/38] kvm: x86: svm: Support Secure Memory Encryption within KVM Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 31/38] x86/mm, kexec: Allow kexec to be used with SME Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 32/38] xen/x86: Remove SME feature in PV guests Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 33/38] x86/mm: Use proper encryption attributes with /dev/mem Tom Lendacky
2017-06-27 15:13 ` [PATCH v8 RESEND 34/38] x86/mm: Create native_make_p4d() for PGTABLE_LEVELS <= 4 Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 35/38] x86/mm: Add support to encrypt the kernel in-place Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 36/38] x86/boot: Add early cmdline parsing for options with arguments Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 37/38] compiler-gcc.h: Introduce __nostackp function attribute Tom Lendacky
2017-06-27 15:14 ` [PATCH v8 RESEND 38/38] x86/mm: Add support to make use of Secure Memory Encryption Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627150914.17428.14700.stgit@tlendack-t1.amdoffice.net \
    --to=thomas.lendacky@amd.com \
    --cc=arnd@arndb.de \
    --cc=aryabinin@virtuozzo.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=corbet@lwn.net \
    --cc=dvyukov@google.com \
    --cc=dyoung@redhat.com \
    --cc=glider@google.com \
    --cc=hpa@zytor.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jgross@suse.com \
    --cc=joro@8bytes.org \
    --cc=kasan-dev@googlegroups.com \
    --cc=kexec@lists.infradead.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=lwoodman@redhat.com \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=riel@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hpe.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).