From: Dennis Zhou <dennisz@fb.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
kernel-team@fb.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Dennis Zhou <dennisszhou@gmail.com>
Subject: Re: [PATCH 09/10] percpu: replace area map allocator with bitmap allocator
Date: Wed, 19 Jul 2017 18:19:02 -0400 [thread overview]
Message-ID: <20170719221901.GA99179@dennisz-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20170719191105.GC23135@li70-116.members.linode.com>
Hi Josef,
On Wed, Jul 19, 2017 at 07:11:06PM +0000, Josef Bacik wrote:
>
> This was a bear to review, I feel like it could be split into a few smaller
> pieces. You are changing hinting, allocating/freeing, and how you find chunks.
> Those seem like good logical divisions to me. Overall the design seems sound
> and I didn't spot any major problems. Once you've split them up I'll do another
> thorough comb through and then add my reviewed by. Thanks,
Yeah.. Thanks for taking the time. I'm currently working on responding
to Tejun's feedback and will do my best to split it down further. I've
done a bit of refactoring which should help readability and hopefully
make it easier in the next pass.
Thanks,
Dennis
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-19 22:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 2:23 [PATCH 00/10] percpu: replace percpu area map allocator with bitmap allocator Dennis Zhou
2017-07-16 2:23 ` [PATCH 01/10] percpu: pcpu-stats change void buffer to int buffer Dennis Zhou
2017-07-17 14:44 ` Tejun Heo
2017-07-16 2:23 ` [PATCH 02/10] percpu: change the format for percpu_stats output Dennis Zhou
2017-07-17 14:46 ` Tejun Heo
2017-07-16 2:23 ` [PATCH 03/10] percpu: expose pcpu_nr_empty_pop_pages in pcpu_stats Dennis Zhou
2017-07-17 14:47 ` Tejun Heo
2017-07-16 2:23 ` [PATCH 04/10] percpu: update the header comment and pcpu_build_alloc_info comments Dennis Zhou
2017-07-17 14:53 ` Tejun Heo
2017-07-16 2:23 ` [PATCH 05/10] percpu: change reserved_size to end page aligned Dennis Zhou
2017-07-16 4:01 ` kbuild test robot
2017-07-16 5:11 ` kbuild test robot
2017-07-17 16:46 ` Tejun Heo
2017-07-17 19:10 ` Dennis Zhou
2017-07-24 20:04 ` Dennis Zhou
2017-07-16 2:23 ` [PATCH 06/10] percpu: modify base_addr to be region specific Dennis Zhou
2017-07-17 18:57 ` Tejun Heo
2017-07-18 19:26 ` Josef Bacik
2017-07-18 19:36 ` Matthew Wilcox
2017-07-19 14:20 ` Josef Bacik
2017-07-16 2:23 ` [PATCH 07/10] percpu: fix misnomer in schunk/dchunk variable names Dennis Zhou
2017-07-17 19:10 ` Tejun Heo
2017-07-24 20:07 ` Dennis Zhou
2017-07-16 2:23 ` [PATCH 08/10] percpu: change the number of pages marked in the first_chunk bitmaps Dennis Zhou
2017-07-17 19:26 ` Tejun Heo
2017-07-24 20:13 ` Dennis Zhou
2017-07-16 2:23 ` [PATCH 09/10] percpu: replace area map allocator with bitmap allocator Dennis Zhou
2017-07-17 23:27 ` Tejun Heo
2017-07-24 21:37 ` Dennis Zhou
2017-07-19 19:11 ` Josef Bacik
2017-07-19 22:19 ` Dennis Zhou [this message]
2017-07-19 19:16 ` Josef Bacik
2017-07-19 22:13 ` Dennis Zhou
2017-07-16 2:23 ` [PATCH 10/10] percpu: add optimizations on allocation path for the " Dennis Zhou
2017-07-17 23:32 ` Tejun Heo
2017-07-18 19:15 ` [PATCH 00/10] percpu: replace percpu area map allocator with " Josef Bacik
2017-07-24 21:14 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719221901.GA99179@dennisz-mbp.dhcp.thefacebook.com \
--to=dennisz@fb.com \
--cc=cl@linux.com \
--cc=dennisszhou@gmail.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).