From: Michal Hocko <mhocko@kernel.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <zi.yan@cs.rutgers.edu>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Vlastimil Babka <vbabka@suse.cz>,
Andrea Reale <ar@linux.vnet.ibm.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm, numa: rework do_pages_move
Date: Fri, 5 Jan 2018 10:33:01 +0100 [thread overview]
Message-ID: <20180105093301.GK2801@dhcp22.suse.cz> (raw)
In-Reply-To: <ebef70ed-1eff-8406-f26b-3ed260c0db22@linux.vnet.ibm.com>
On Fri 05-01-18 14:50:04, Anshuman Khandual wrote:
> On 01/05/2018 02:44 PM, Michal Hocko wrote:
> > On Fri 05-01-18 09:22:22, Anshuman Khandual wrote:
> > [...]
> >> Hi Michal,
> >>
> >> After slightly modifying your test case (like fixing the page size for
> >> powerpc and just doing simple migration from node 0 to 8 instead of the
> >> interleaving), I tried to measure the migration speed with and without
> >> the patches on mainline. Its interesting....
> >>
> >> 10000 pages | 100000 pages
> >> --------------------------
> >> Mainline 165 ms 1674 ms
> >> Mainline + first patch (move_pages) 191 ms 1952 ms
> >> Mainline + all three patches 146 ms 1469 ms
> >>
> >> Though overall it gives performance improvement, some how it slows
> >> down migration after the first patch. Will look into this further.
> >
> > What are you measuring actually? All pages migrated to the same node?
>
> The mount of time move_pages() system call took to move these many
> pages from node 0 to node 8. Yeah they migrated to the same node.
>
> > Do you have any profiles? How stable are the results?
>
> No, are you referring to perf record kind profile ? Results were
> repeating.
Yes. I am really wondering because there souldn't anything specific to
improve the situation with patch 2 and 3. Likewise the only overhead
from the patch 1 I can see is the reduced batching of the mmap_sem. But
then I am wondering what would compensate that later...
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-05 9:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 8:25 [PATCH 0/3] unclutter thp migration Michal Hocko
2018-01-03 8:25 ` [PATCH 1/3] mm, numa: rework do_pages_move Michal Hocko
2018-01-05 3:52 ` Anshuman Khandual
2018-01-05 9:14 ` Michal Hocko
2018-01-05 9:20 ` Anshuman Khandual
2018-01-05 9:33 ` Michal Hocko [this message]
2018-01-05 17:15 ` Christopher Lameter
2018-01-05 18:09 ` Michal Hocko
2018-01-05 18:41 ` Christopher Lameter
2018-01-05 18:48 ` Michal Hocko
2018-01-05 19:27 ` Christopher Lameter
2018-01-05 19:44 ` Michal Hocko
2018-01-29 22:06 ` Zi Yan
2018-01-29 22:35 ` Andrew Morton
2018-01-29 23:39 ` Zi Yan
2018-01-29 23:48 ` Andrew Morton
2018-01-03 8:25 ` [PATCH 2/3] mm, migrate: remove reason argument from new_page_t Michal Hocko
2018-01-03 9:11 ` Michal Hocko
2018-01-03 14:00 ` Anshuman Khandual
2018-01-03 14:09 ` Michal Hocko
2018-01-03 14:19 ` Anshuman Khandual
2018-01-03 8:25 ` [PATCH 3/3] mm: unclutter THP migration Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105093301.GK2801@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ar@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).