From: Balbir Singh <bsingharora@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Oscar Salvador <OSalvador@suse.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages
Date: Fri, 9 Nov 2018 21:45:41 +1100 [thread overview]
Message-ID: <20181109104541.GE9042@350D> (raw)
In-Reply-To: <20181107130655.GE27423@dhcp22.suse.cz>
On Wed, Nov 07, 2018 at 02:06:55PM +0100, Michal Hocko wrote:
> On Wed 07-11-18 23:53:24, Balbir Singh wrote:
> > On Wed, Nov 07, 2018 at 08:35:48AM +0100, Michal Hocko wrote:
> > > On Wed 07-11-18 07:35:18, Balbir Singh wrote:
> [...]
> > > > The check seems to be quite aggressive and in a loop that iterates
> > > > pages, but has nothing to do with the page, did you mean to make
> > > > the check
> > > >
> > > > zone_idx(page_zone(page)) == ZONE_MOVABLE
> > >
> > > Does it make any difference? Can we actually encounter a page from a
> > > different zone here?
> > >
> >
> > Just to avoid page state related issues, do we want to go ahead
> > with the migration if zone_idx(page_zone(page)) != ZONE_MOVABLE.
>
> Could you be more specific what kind of state related issues you have in
> mind?
>
I was wondering if page_zone() is setup correctly, but it's setup
upfront, so I don't think that is ever an issue.
> > > > it also skips all checks for pinned pages and other checks
> > >
> > > Yes, this is intentional and the comment tries to explain why. I wish we
> > > could be add a more specific checks for movable pages - e.g. detect long
> > > term pins that would prevent migration - but we do not have any facility
> > > for that. Please note that the worst case of a false positive is a
> > > repeated migration failure and user has a way to break out of migration
> > > by a signal.
> > >
> >
> > Basically isolate_pages() will fail as opposed to hotplug failing upfront.
> > The basic assertion this patch makes is that all ZONE_MOVABLE pages that
> > are not reserved are hotpluggable.
>
> Yes, that is correct.
>
I wonder if it is easier to catch a __SetPageReserved() on ZONE_MOVABLE memory
at set time, the downside is that we never know if that memory will ever be
hot(un)plugged. The patch itself, I think is OK
Acked-by: Balbir Singh <bsingharora@gmail.com>
Balbir Singh.
next prev parent reply other threads:[~2018-11-09 10:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 9:55 [PATCH] mm, memory_hotplug: check zone_movable in has_unmovable_pages Michal Hocko
2018-11-06 11:00 ` osalvador
2018-11-06 20:35 ` Balbir Singh
2018-11-07 7:35 ` Michal Hocko
2018-11-07 7:40 ` Michal Hocko
2018-11-07 7:55 ` osalvador
2018-11-07 8:14 ` Michal Hocko
2018-11-07 12:53 ` Balbir Singh
2018-11-07 13:06 ` Michal Hocko
2018-11-09 10:45 ` Balbir Singh [this message]
2018-11-15 3:13 ` Baoquan He
2018-11-15 3:18 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109104541.GE9042@350D \
--to=bsingharora@gmail.com \
--cc=OSalvador@suse.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).