From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, gorcunov@virtuozzo.com
Subject: Re: [PATCH v3] ksm: React on changing "sleep_millisecs" parameter faster
Date: Tue, 11 Dec 2018 18:19:57 +0300 [thread overview]
Message-ID: <20181211151957.GJ2342@uranus.lan> (raw)
In-Reply-To: <154454107680.3258.3558002210423531566.stgit@localhost.localdomain>
On Tue, Dec 11, 2018 at 06:11:25PM +0300, Kirill Tkhai wrote:
> ksm thread unconditionally sleeps in ksm_scan_thread()
> after each iteration:
>
> schedule_timeout_interruptible(
> msecs_to_jiffies(ksm_thread_sleep_millisecs))
>
> The timeout is configured in /sys/kernel/mm/ksm/sleep_millisecs.
>
> In case of user writes a big value by a mistake, and the thread
> enters into schedule_timeout_interruptible(), it's not possible
> to cancel the sleep by writing a new smaler value; the thread
> is just sleeping till timeout expires.
>
> The patch fixes the problem by waking the thread each time
> after the value is updated.
>
> This also may be useful for debug purposes; and also for userspace
> daemons, which change sleep_millisecs value in dependence of
> system load.
>
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>
> v3: Do not use mutex: to acquire it may take much time in case long
> list of ksm'able mm and pages.
> v2: Use wait_event_interruptible_timeout() instead of unconditional
> schedule_timeout().
Looks ok to me, thanks!
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
prev parent reply other threads:[~2018-12-11 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 16:06 [PATCH] ksm: React on changing "sleep_millisecs" parameter faster Kirill Tkhai
2018-12-10 20:10 ` Cyrill Gorcunov
2018-12-11 9:23 ` Kirill Tkhai
2018-12-11 10:03 ` Cyrill Gorcunov
2018-12-11 10:26 ` [PATCH v2] " Kirill Tkhai
2018-12-11 11:13 ` Cyrill Gorcunov
2018-12-11 12:22 ` Kirill Tkhai
2018-12-11 12:34 ` Cyrill Gorcunov
2018-12-11 14:15 ` Kirill Tkhai
2018-12-11 15:11 ` [PATCH v3] " Kirill Tkhai
2018-12-11 15:19 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211151957.GJ2342@uranus.lan \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@virtuozzo.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).