From: Andrew Morton <akpm@linux-foundation.org>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Thomas Garnier <thgarnie@google.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
Steven Rostedt <rostedt@goodmis.org>,
Joel Fernandes <joelaf@google.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH v2 0/1] improve vmap allocation
Date: Thu, 21 Mar 2019 15:01:06 -0700 [thread overview]
Message-ID: <20190321150106.198f70e1e949e2cb8cc06f1c@linux-foundation.org> (raw)
In-Reply-To: <20190321190327.11813-1-urezki@gmail.com>
On Thu, 21 Mar 2019 20:03:26 +0100 "Uladzislau Rezki (Sony)" <urezki@gmail.com> wrote:
> Hello.
>
> This is the v2 of the https://lkml.org/lkml/2018/10/19/786 rework. Instead of
> referring you to that link, i will go through it again describing the improved
> allocation method and provide changes between v1 and v2 in the end.
>
> ...
>
> Performance analysis
> --------------------
Impressive numbers. But this is presumably a worst-case microbenchmark.
Are you able to describe the benefits which are observed in some
real-world workload which someone cares about?
It's a lot of new code. I t looks decent and I'll toss it in there for
further testing. Hopefully someone will be able to find the time for a
detailed review.
Trivial point: the code uses "inline" a lot. Nowadays gcc cheerfully
ignores that and does its own thing. You might want to look at the
effects of simply deleting all that. Is the generated code better or
worse or the same? If something really needs to be inlined then use
__always_inline, preferably with a comment explaining why it is there.
next prev parent reply other threads:[~2019-03-21 22:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 19:03 [RFC PATCH v2 0/1] improve vmap allocation Uladzislau Rezki (Sony)
2019-03-21 19:03 ` [RFC PATCH v2 1/1] mm/vmap: keep track of free blocks for " Uladzislau Rezki (Sony)
2019-03-22 21:54 ` Roman Gushchin
2019-03-25 17:20 ` Uladzislau Rezki
2019-03-26 14:51 ` Uladzislau Rezki
2019-03-27 0:41 ` Roman Gushchin
2019-03-27 17:52 ` Uladzislau Rezki
2019-03-21 22:01 ` Andrew Morton [this message]
2019-03-22 16:52 ` [RFC PATCH v2 0/1] improve " Uladzislau Rezki
2019-03-22 17:47 ` Joel Fernandes
2019-04-01 11:03 ` Uladzislau Rezki
2019-04-01 22:59 ` Andrew Morton
2019-04-02 8:48 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321150106.198f70e1e949e2cb8cc06f1c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@elte.hu \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=tj@kernel.org \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).