From: Zi Yan <zi.yan@sent.com>
To: Dave Hansen <dave.hansen@linux.intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Keith Busch <keith.busch@intel.com>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>,
Michal Hocko <mhocko@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
John Hubbard <jhubbard@nvidia.com>,
Mark Hairgrove <mhairgrove@nvidia.com>,
Nitin Gupta <nigupta@nvidia.com>,
Javier Cabezas <jcabezas@nvidia.com>,
David Nellans <dnellans@nvidia.com>, Zi Yan <ziy@nvidia.com>
Subject: [RFC PATCH 25/25] memory manage: use exchange pages to memory manage to improve throughput.
Date: Wed, 3 Apr 2019 19:00:46 -0700 [thread overview]
Message-ID: <20190404020046.32741-26-zi.yan@sent.com> (raw)
In-Reply-To: <20190404020046.32741-1-zi.yan@sent.com>
From: Zi Yan <ziy@nvidia.com>
1. Exclude file-backed base pages from exchanging.
2. Split THP in exchange pages if THP support is disabled.
3. if THP migration is supported, only exchange THPs.
Signed-off-by: Zi Yan <ziy@nvidia.com>
---
mm/memory_manage.c | 173 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 173 insertions(+)
diff --git a/mm/memory_manage.c b/mm/memory_manage.c
index 8b76fcf..d3d07b7 100644
--- a/mm/memory_manage.c
+++ b/mm/memory_manage.c
@@ -7,6 +7,7 @@
#include <linux/mempolicy.h>
#include <linux/memcontrol.h>
#include <linux/migrate.h>
+#include <linux/exchange.h>
#include <linux/mm_inline.h>
#include <linux/nodemask.h>
#include <linux/rmap.h>
@@ -253,6 +254,147 @@ static int putback_overflow_pages(unsigned long max_nr_base_pages,
huge_page_list, nr_huge_pages);
}
+static int add_pages_to_exchange_list(struct list_head *from_pagelist,
+ struct list_head *to_pagelist, struct exchange_page_info *info_list,
+ struct list_head *exchange_list, unsigned long info_list_size)
+{
+ unsigned long info_list_index = 0;
+ LIST_HEAD(failed_from_list);
+ LIST_HEAD(failed_to_list);
+
+ while (!list_empty(from_pagelist) && !list_empty(to_pagelist)) {
+ struct page *from_page, *to_page;
+ struct exchange_page_info *one_pair = &info_list[info_list_index];
+ int rc;
+
+ from_page = list_first_entry_or_null(from_pagelist, struct page, lru);
+ to_page = list_first_entry_or_null(to_pagelist, struct page, lru);
+
+ if (!from_page || !to_page)
+ break;
+
+ if (!thp_migration_supported() && PageTransHuge(from_page)) {
+ lock_page(from_page);
+ rc = split_huge_page_to_list(from_page, &from_page->lru);
+ unlock_page(from_page);
+ if (rc) {
+ list_move(&from_page->lru, &failed_from_list);
+ continue;
+ }
+ }
+
+ if (!thp_migration_supported() && PageTransHuge(to_page)) {
+ lock_page(to_page);
+ rc = split_huge_page_to_list(to_page, &to_page->lru);
+ unlock_page(to_page);
+ if (rc) {
+ list_move(&to_page->lru, &failed_to_list);
+ continue;
+ }
+ }
+
+ if (hpage_nr_pages(from_page) != hpage_nr_pages(to_page)) {
+ if (!(hpage_nr_pages(from_page) == 1 && hpage_nr_pages(from_page) == HPAGE_PMD_NR)) {
+ list_del(&from_page->lru);
+ list_add(&from_page->lru, &failed_from_list);
+ }
+ if (!(hpage_nr_pages(to_page) == 1 && hpage_nr_pages(to_page) == HPAGE_PMD_NR)) {
+ list_del(&to_page->lru);
+ list_add(&to_page->lru, &failed_to_list);
+ }
+ continue;
+ }
+
+ /* Exclude file-backed pages, exchange it concurrently is not
+ * implemented yet. */
+ if (page_mapping(from_page)) {
+ list_del(&from_page->lru);
+ list_add(&from_page->lru, &failed_from_list);
+ continue;
+ }
+ if (page_mapping(to_page)) {
+ list_del(&to_page->lru);
+ list_add(&to_page->lru, &failed_to_list);
+ continue;
+ }
+
+ list_del(&from_page->lru);
+ list_del(&to_page->lru);
+
+ one_pair->from_page = from_page;
+ one_pair->to_page = to_page;
+
+ list_add_tail(&one_pair->list, exchange_list);
+
+ info_list_index++;
+ if (info_list_index >= info_list_size)
+ break;
+ }
+ list_splice(&failed_from_list, from_pagelist);
+ list_splice(&failed_to_list, to_pagelist);
+
+ return info_list_index;
+}
+
+static unsigned long exchange_pages_between_nodes(unsigned long nr_from_pages,
+ unsigned long nr_to_pages, struct list_head *from_page_list,
+ struct list_head *to_page_list, int batch_size,
+ bool huge_page, enum migrate_mode mode)
+{
+ struct exchange_page_info *info_list;
+ unsigned long info_list_size = min_t(unsigned long,
+ nr_from_pages, nr_to_pages) / (huge_page?HPAGE_PMD_NR:1);
+ unsigned long added_size = 0;
+ bool migrate_concur = mode & MIGRATE_CONCUR;
+ LIST_HEAD(exchange_list);
+
+ /* non concurrent does not need to split into batches */
+ if (!migrate_concur || batch_size <= 0)
+ batch_size = info_list_size;
+
+ /* prepare for huge page split */
+ if (!thp_migration_supported() && huge_page) {
+ batch_size = batch_size * HPAGE_PMD_NR;
+ info_list_size = info_list_size * HPAGE_PMD_NR;
+ }
+
+ info_list = kvzalloc(sizeof(struct exchange_page_info)*batch_size,
+ GFP_KERNEL);
+ if (!info_list)
+ return 0;
+
+ while (!list_empty(from_page_list) && !list_empty(to_page_list)) {
+ unsigned long nr_added_pages;
+ INIT_LIST_HEAD(&exchange_list);
+
+ nr_added_pages = add_pages_to_exchange_list(from_page_list, to_page_list,
+ info_list, &exchange_list, batch_size);
+
+ /*
+ * Nothing to exchange, we bail out.
+ *
+ * In case from_page_list and to_page_list both only have file-backed
+ * pages left */
+ if (!nr_added_pages)
+ break;
+
+ added_size += nr_added_pages;
+
+ VM_BUG_ON(added_size > info_list_size);
+
+ if (migrate_concur)
+ exchange_pages_concur(&exchange_list, mode, MR_SYSCALL);
+ else
+ exchange_pages(&exchange_list, mode, MR_SYSCALL);
+
+ memset(info_list, 0, sizeof(struct exchange_page_info)*batch_size);
+ }
+
+ kvfree(info_list);
+
+ return info_list_size;
+}
+
static int do_mm_manage(struct task_struct *p, struct mm_struct *mm,
const nodemask_t *slow, const nodemask_t *fast,
unsigned long nr_pages, int flags)
@@ -261,6 +403,7 @@ static int do_mm_manage(struct task_struct *p, struct mm_struct *mm,
bool migrate_concur = flags & MPOL_MF_MOVE_CONCUR;
bool migrate_dma = flags & MPOL_MF_MOVE_DMA;
bool move_hot_and_cold_pages = flags & MPOL_MF_MOVE_ALL;
+ bool migrate_exchange_pages = flags & MPOL_MF_EXCHANGE;
struct mem_cgroup *memcg = mem_cgroup_from_task(p);
int err = 0;
unsigned long nr_isolated_slow_pages;
@@ -338,6 +481,35 @@ static int do_mm_manage(struct task_struct *p, struct mm_struct *mm,
&nr_isolated_fast_base_pages, &nr_isolated_fast_huge_pages,
move_hot_and_cold_pages?ISOLATE_HOT_AND_COLD_PAGES:ISOLATE_COLD_PAGES);
+ if (migrate_exchange_pages) {
+ unsigned long nr_exchange_pages;
+
+ /*
+ * base pages can include file-backed ones, we do not handle them
+ * at the moment
+ */
+ if (!thp_migration_supported()) {
+ nr_exchange_pages = exchange_pages_between_nodes(nr_isolated_slow_base_pages,
+ nr_isolated_fast_base_pages, &slow_base_page_list,
+ &fast_base_page_list, migration_batch_size, false, mode);
+
+ nr_isolated_fast_base_pages -= nr_exchange_pages;
+ }
+
+ /* THP page exchange */
+ nr_exchange_pages = exchange_pages_between_nodes(nr_isolated_slow_huge_pages,
+ nr_isolated_fast_huge_pages, &slow_huge_page_list,
+ &fast_huge_page_list, migration_batch_size, true, mode);
+
+ /* split THP above, so we do not need to multiply the counter */
+ if (!thp_migration_supported())
+ nr_isolated_fast_huge_pages -= nr_exchange_pages;
+ else
+ nr_isolated_fast_huge_pages -= nr_exchange_pages * HPAGE_PMD_NR;
+
+ goto migrate_out;
+ } else {
+migrate_out:
/* Migrate pages to slow node */
/* No multi-threaded migration for base pages */
nr_isolated_fast_base_pages -=
@@ -347,6 +519,7 @@ static int do_mm_manage(struct task_struct *p, struct mm_struct *mm,
nr_isolated_fast_huge_pages -=
migrate_to_node(&fast_huge_page_list, slow_nid, mode,
migration_batch_size);
+ }
}
if (nr_isolated_fast_base_pages != ULONG_MAX &&
--
2.7.4
next prev parent reply other threads:[~2019-04-04 2:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 2:00 [RFC PATCH 00/25] Accelerate page migration and use memcg for PMEM management Zi Yan
2019-04-04 2:00 ` [RFC PATCH 01/25] mm: migrate: Change migrate_mode to support combination migration modes Zi Yan
2019-04-04 2:00 ` [RFC PATCH 02/25] mm: migrate: Add mode parameter to support future page copy routines Zi Yan
2019-04-04 2:00 ` [RFC PATCH 03/25] mm: migrate: Add a multi-threaded page migration function Zi Yan
2019-04-04 2:00 ` [RFC PATCH 04/25] mm: migrate: Add copy_page_multithread into migrate_pages Zi Yan
2019-04-04 2:00 ` [RFC PATCH 05/25] mm: migrate: Add vm.accel_page_copy in sysfs to control page copy acceleration Zi Yan
2019-04-04 2:00 ` [RFC PATCH 06/25] mm: migrate: Make the number of copy threads adjustable via sysctl Zi Yan
2019-04-04 2:00 ` [RFC PATCH 07/25] mm: migrate: Add copy_page_dma to use DMA Engine to copy pages Zi Yan
2019-04-04 2:00 ` [RFC PATCH 08/25] mm: migrate: Add copy_page_dma into migrate_page_copy Zi Yan
2019-04-04 2:00 ` [RFC PATCH 09/25] mm: migrate: Add copy_page_lists_dma_always to support copy a list of pages Zi Yan
2019-04-04 2:00 ` [RFC PATCH 10/25] mm: migrate: copy_page_lists_mt() to copy a page list using multi-threads Zi Yan
2019-04-04 2:00 ` [RFC PATCH 11/25] mm: migrate: Add concurrent page migration into move_pages syscall Zi Yan
2019-04-04 2:00 ` [RFC PATCH 12/25] exchange pages: new page migration mechanism: exchange_pages() Zi Yan
2019-04-04 2:00 ` [RFC PATCH 13/25] exchange pages: add multi-threaded exchange pages Zi Yan
2019-04-04 2:00 ` [RFC PATCH 14/25] exchange pages: concurrent " Zi Yan
2019-04-04 2:00 ` [RFC PATCH 15/25] exchange pages: exchange anonymous page and file-backed page Zi Yan
2019-04-04 2:00 ` [RFC PATCH 16/25] exchange page: Add THP exchange support Zi Yan
2019-04-04 2:00 ` [RFC PATCH 17/25] exchange page: Add exchange_page() syscall Zi Yan
2019-04-04 2:00 ` [RFC PATCH 18/25] memcg: Add per node memory usage&max stats in memcg Zi Yan
2019-04-04 2:00 ` [RFC PATCH 19/25] mempolicy: add MPOL_F_MEMCG flag, enforcing memcg memory limit Zi Yan
2019-04-04 2:00 ` [RFC PATCH 20/25] memory manage: Add memory manage syscall Zi Yan
2019-04-04 2:00 ` [RFC PATCH 21/25] mm: move update_lru_sizes() to mm_inline.h for broader use Zi Yan
2019-04-04 2:00 ` [RFC PATCH 22/25] memory manage: active/inactive page list manipulation in memcg Zi Yan
2019-04-04 2:00 ` [RFC PATCH 23/25] memory manage: page migration based page manipulation between NUMA nodes Zi Yan
2019-04-04 2:00 ` [RFC PATCH 24/25] memory manage: limit migration batch size Zi Yan
2019-04-04 2:00 ` Zi Yan [this message]
2019-04-04 7:13 ` [RFC PATCH 00/25] Accelerate page migration and use memcg for PMEM management Michal Hocko
2019-04-05 0:32 ` Yang Shi
2019-04-05 17:20 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404020046.32741-26-zi.yan@sent.com \
--to=zi.yan@sent.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=dnellans@nvidia.com \
--cc=fengguang.wu@intel.com \
--cc=jcabezas@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=keith.busch@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhairgrove@nvidia.com \
--cc=mhocko@kernel.org \
--cc=nigupta@nvidia.com \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).