Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

From: kbuild test robot <lkp@intel.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org,
	catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
	mhocko@suse.com, david@redhat.com, cai@lca.pw,
	logang@deltatee.com, cpandya@codeaurora.org,
	arunks@codeaurora.org, dan.j.williams@intel.com,
	mgorman@techsingularity.net, osalvador@suse.de,
	ard.biesheuvel@arm.com, steve.capper@arm.com, broonie@kernel.org,
	valentin.schneider@arm.com, Robin.Murphy@arm.com,
	steven.price@arm.com, suzuki.poulose@arm.com,
	ira.weiny@intel.com
Subject: Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove
Date: Tue, 24 Sep 2019 01:39:46 +0800	[thread overview]
Message-ID: <201909240135.Y7nq2bo7%lkp@intel.com> (raw)
In-Reply-To: <1569217425-23777-3-git-send-email-anshuman.khandual@arm.com>

[-- Attachment #1: Type: text/plain, Size: 4334 bytes --]

Hi Anshuman,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Anshuman-Khandual/arm64-mm-Hold-memory-hotplug-lock-while-walking-for-kernel-page-table-dump/20190923-134733
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> mm/memremap.c:16:0: warning: "SECTION_MASK" redefined
    #define SECTION_MASK ~((1UL << PA_SECTION_SHIFT) - 1)

   In file included from arch/arm64/include/asm/processor.h:34:0,
                    from include/linux/mutex.h:19,
                    from include/linux/kernfs.h:12,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/device.h:16,
                    from mm/memremap.c:3:
   arch/arm64/include/asm/pgtable-hwdef.h:79:0: note: this is the location of the previous definition
    #define SECTION_MASK  (~(SECTION_SIZE-1))

>> mm/memremap.c:17:0: warning: "SECTION_SIZE" redefined
    #define SECTION_SIZE (1UL << PA_SECTION_SHIFT)

   In file included from arch/arm64/include/asm/processor.h:34:0,
                    from include/linux/mutex.h:19,
                    from include/linux/kernfs.h:12,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/device.h:16,
                    from mm/memremap.c:3:
   arch/arm64/include/asm/pgtable-hwdef.h:78:0: note: this is the location of the previous definition
    #define SECTION_SIZE  (_AC(1, UL) << SECTION_SHIFT)

vim +/SECTION_MASK +16 mm/memremap.c

7d3dcf26a6559f kernel/memremap.c Christoph Hellwig 2015-08-10  @3  #include <linux/device.h>
92281dee825f6d kernel/memremap.c Dan Williams      2015-08-10   4  #include <linux/io.h>
0207df4fa1a869 kernel/memremap.c Andrey Ryabinin   2018-08-17   5  #include <linux/kasan.h>
41e94a851304f7 kernel/memremap.c Christoph Hellwig 2015-08-17   6  #include <linux/memory_hotplug.h>
bcfa4b72111c9a kernel/memremap.c Matthew Wilcox    2018-08-15   7  #include <linux/mm.h>
bcfa4b72111c9a kernel/memremap.c Matthew Wilcox    2018-08-15   8  #include <linux/pfn_t.h>
5042db43cc26f5 kernel/memremap.c Jérôme Glisse     2017-09-08   9  #include <linux/swap.h>
5042db43cc26f5 kernel/memremap.c Jérôme Glisse     2017-09-08  10  #include <linux/swapops.h>
bcfa4b72111c9a kernel/memremap.c Matthew Wilcox    2018-08-15  11  #include <linux/types.h>
e7638488434415 kernel/memremap.c Dan Williams      2018-05-16  12  #include <linux/wait_bit.h>
bcfa4b72111c9a kernel/memremap.c Matthew Wilcox    2018-08-15  13  #include <linux/xarray.h>
92281dee825f6d kernel/memremap.c Dan Williams      2015-08-10  14  
bcfa4b72111c9a kernel/memremap.c Matthew Wilcox    2018-08-15  15  static DEFINE_XARRAY(pgmap_array);
9476df7d80dfc4 kernel/memremap.c Dan Williams      2016-01-15 @16  #define SECTION_MASK ~((1UL << PA_SECTION_SHIFT) - 1)
9476df7d80dfc4 kernel/memremap.c Dan Williams      2016-01-15 @17  #define SECTION_SIZE (1UL << PA_SECTION_SHIFT)
9476df7d80dfc4 kernel/memremap.c Dan Williams      2016-01-15  18  

:::::: The code at line 16 was first introduced by commit
:::::: 9476df7d80dfc425b37bfecf1d89edf8ec81fcb6 mm: introduce find_dev_pagemap()

:::::: TO: Dan Williams <dan.j.williams@intel.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67082 bytes --]