From: Mike Rapoport <rppt@linux.ibm.com>
To: Adam Ford <aford173@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
etnaviv@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/21] Refine memblock API
Date: Wed, 25 Sep 2019 09:42:15 +0300 [thread overview]
Message-ID: <20190925064214.GB1857@linux.ibm.com> (raw)
In-Reply-To: <CAHCN7x+Jv7yGPoB0Gm=TJ30ObLJduw2XomHkd++KqFEURYQcGg@mail.gmail.com>
(updated CC)
Hi,
On Tue, Sep 24, 2019 at 12:52:35PM -0500, Adam Ford wrote:
> On Mon, Jan 21, 2019 at 2:05 AM Mike Rapoport <rppt@linux.ibm.com> wrote:
> >
> > Hi,
> >
> > v2 changes:
> > * replace some more %lu with %zu
> > * remove panics where they are not needed in s390 and in printk
> > * collect Acked-by and Reviewed-by.
> >
> >
> > Christophe Leroy (1):
> > powerpc: use memblock functions returning virtual address
> >
> > Mike Rapoport (20):
> > openrisc: prefer memblock APIs returning virtual address
> > memblock: replace memblock_alloc_base(ANYWHERE) with memblock_phys_alloc
> > memblock: drop memblock_alloc_base_nid()
> > memblock: emphasize that memblock_alloc_range() returns a physical address
> > memblock: memblock_phys_alloc_try_nid(): don't panic
> > memblock: memblock_phys_alloc(): don't panic
> > memblock: drop __memblock_alloc_base()
> > memblock: drop memblock_alloc_base()
> > memblock: refactor internal allocation functions
> > memblock: make memblock_find_in_range_node() and choose_memblock_flags() static
> > arch: use memblock_alloc() instead of memblock_alloc_from(size, align, 0)
> > arch: don't memset(0) memory returned by memblock_alloc()
> > ia64: add checks for the return value of memblock_alloc*()
> > sparc: add checks for the return value of memblock_alloc*()
> > mm/percpu: add checks for the return value of memblock_alloc*()
> > init/main: add checks for the return value of memblock_alloc*()
> > swiotlb: add checks for the return value of memblock_alloc*()
> > treewide: add checks for the return value of memblock_alloc*()
> > memblock: memblock_alloc_try_nid: don't panic
> > memblock: drop memblock_alloc_*_nopanic() variants
> >
> I know it's rather late, but this patch broke the Etnaviv 3D graphics
> in my i.MX6Q.
Can you identify the exact patch from the series that caused the
regression?
> When I try to use the 3D, it returns some errors and the dmesg log
> shows some memory allocation errors too:
> [ 3.682347] etnaviv etnaviv: bound 130000.gpu (ops gpu_ops)
> [ 3.688669] etnaviv etnaviv: bound 134000.gpu (ops gpu_ops)
> [ 3.695099] etnaviv etnaviv: bound 2204000.gpu (ops gpu_ops)
> [ 3.700800] etnaviv-gpu 130000.gpu: model: GC2000, revision: 5108
> [ 3.723013] etnaviv-gpu 130000.gpu: command buffer outside valid
> memory window
> [ 3.731308] etnaviv-gpu 134000.gpu: model: GC320, revision: 5007
> [ 3.752437] etnaviv-gpu 134000.gpu: command buffer outside valid
> memory window
> [ 3.760583] etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215
> [ 3.766766] etnaviv-gpu 2204000.gpu: Ignoring GPU with VG and FE2.0
> [ 3.776131] [drm] Initialized etnaviv 1.2.0 20151214 for etnaviv on minor 0
>
> # glmark2-es2-drm
> Error creating gpu
> Error: eglCreateWindowSurface failed with error: 0x3009
> Error: eglCreateWindowSurface failed with error: 0x3009
> Error: CanvasGeneric: Invalid EGL state
> Error: main: Could not initialize canvas
>
>
> Before this patch:
>
> [ 3.691995] etnaviv etnaviv: bound 130000.gpu (ops gpu_ops)
> [ 3.698356] etnaviv etnaviv: bound 134000.gpu (ops gpu_ops)
> [ 3.704792] etnaviv etnaviv: bound 2204000.gpu (ops gpu_ops)
> [ 3.710488] etnaviv-gpu 130000.gpu: model: GC2000, revision: 5108
> [ 3.733649] etnaviv-gpu 134000.gpu: model: GC320, revision: 5007
> [ 3.756115] etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215
> [ 3.762250] etnaviv-gpu 2204000.gpu: Ignoring GPU with VG and FE2.0
> [ 3.771432] [drm] Initialized etnaviv 1.2.0 20151214 for etnaviv on minor 0
>
> and the 3D gemos work without this.
>
> I don't know enough about the i.MX6 nor the 3D accelerator to know how
> to fix it.
> I am hoping someone in the know might have some suggestions.
Can you please add "memblock=debug" to your kernel command line and send
kernel logs for both working and failing versions?
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-09-25 6:42 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 8:03 [PATCH v2 00/21] Refine memblock API Mike Rapoport
2019-01-21 8:03 ` [PATCH v2 01/21] openrisc: prefer memblock APIs returning virtual address Mike Rapoport
2019-01-27 3:07 ` Stafford Horne
2019-01-21 8:03 ` [PATCH v2 02/21] powerpc: use memblock functions " Mike Rapoport
2019-01-29 9:52 ` Michael Ellerman
2019-01-21 8:03 ` [PATCH v2 03/21] memblock: replace memblock_alloc_base(ANYWHERE) with memblock_phys_alloc Mike Rapoport
2019-01-21 8:03 ` [PATCH v2 04/21] memblock: drop memblock_alloc_base_nid() Mike Rapoport
2019-01-21 8:03 ` [PATCH v2 05/21] memblock: emphasize that memblock_alloc_range() returns a physical address Mike Rapoport
2019-01-21 8:03 ` [PATCH v2 06/21] memblock: memblock_phys_alloc_try_nid(): don't panic Mike Rapoport
2019-01-25 17:45 ` Catalin Marinas
2019-01-25 19:32 ` Mike Rapoport
2019-01-29 9:56 ` Michael Ellerman
2019-01-29 9:58 ` Michael Ellerman
2019-01-21 8:03 ` [PATCH v2 07/21] memblock: memblock_phys_alloc(): " Mike Rapoport
2019-01-21 8:03 ` [PATCH v2 08/21] memblock: drop __memblock_alloc_base() Mike Rapoport
2019-01-21 8:03 ` [PATCH v2 09/21] memblock: drop memblock_alloc_base() Mike Rapoport
2019-01-29 10:29 ` Michael Ellerman
2019-01-21 8:03 ` [PATCH v2 10/21] memblock: refactor internal allocation functions Mike Rapoport
2019-02-03 9:39 ` Michael Ellerman
2019-02-03 10:04 ` Mike Rapoport
2019-02-03 11:39 ` Mike Rapoport
2019-02-04 8:45 ` Michael Ellerman
2019-02-04 23:08 ` Stephen Rothwell
2019-01-21 8:03 ` [PATCH v2 11/21] memblock: make memblock_find_in_range_node() and choose_memblock_flags() static Mike Rapoport
2019-01-21 8:03 ` [PATCH v2 12/21] arch: use memblock_alloc() instead of memblock_alloc_from(size, align, 0) Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 13/21] arch: don't memset(0) memory returned by memblock_alloc() Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 14/21] ia64: add checks for the return value of memblock_alloc*() Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 15/21] sparc: " Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 16/21] mm/percpu: " Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 17/21] init/main: " Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 18/21] swiotlb: " Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 19/21] treewide: " Mike Rapoport
2019-01-21 8:39 ` Geert Uytterhoeven
2019-01-21 8:39 ` Geert Uytterhoeven
2019-01-21 17:18 ` Rob Herring
2019-01-31 6:07 ` Christophe Leroy
2019-01-31 6:41 ` Mike Rapoport
2019-01-31 6:44 ` Christophe Leroy
2019-01-31 7:07 ` Christophe Leroy
2019-01-31 7:14 ` Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 20/21] memblock: memblock_alloc_try_nid: don't panic Mike Rapoport
2019-01-21 8:04 ` [PATCH v2 21/21] memblock: drop memblock_alloc_*_nopanic() variants Mike Rapoport
2019-01-30 13:38 ` Petr Mladek
2019-09-24 17:52 ` [PATCH v2 00/21] Refine memblock API Adam Ford
2019-09-25 6:42 ` Mike Rapoport [this message]
2019-09-25 12:12 ` Fabio Estevam
2019-09-25 12:17 ` Adam Ford
2019-09-25 15:17 ` Fabio Estevam
2019-09-26 13:09 ` Adam Ford
2019-09-26 16:04 ` Mike Rapoport
2019-09-26 19:35 ` Adam Ford
2019-09-28 7:33 ` Mike Rapoport
2019-09-29 13:33 ` Adam Ford
2019-10-02 0:14 ` Adam Ford
2019-10-02 7:36 ` Mike Rapoport
2019-10-02 11:14 ` Adam Ford
2019-10-03 5:34 ` Mike Rapoport
2019-10-03 8:49 ` Russell King - ARM Linux admin
2019-10-03 11:30 ` Mike Rapoport
2019-10-03 13:17 ` Lucas Stach
2019-10-04 9:27 ` Russell King - ARM Linux admin
2019-10-04 13:21 ` Lucas Stach
2019-10-04 13:58 ` Adam Ford
2019-10-04 17:10 ` Mike Rapoport
2019-10-04 17:29 ` Mike Rapoport
2019-10-03 14:46 ` Chris Healy
2019-10-04 9:12 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925064214.GB1857@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=aford173@gmail.com \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).