From: Will Deacon <will@kernel.org>
To: Jia He <justin.he@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>, Marc Zyngier <maz@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Punit Agrawal <punitagrawal@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
hejianet@gmail.com, Kaly Xin <Kaly.Xin@arm.com>
Subject: Re: [PATCH v10 1/3] arm64: cpufeature: introduce helper cpu_has_hw_af()
Date: Tue, 1 Oct 2019 13:54:47 +0100 [thread overview]
Message-ID: <20191001125446.gknoofnm7az4wqf5@willie-the-truck> (raw)
In-Reply-To: <20190930015740.84362-2-justin.he@arm.com>
On Mon, Sep 30, 2019 at 09:57:38AM +0800, Jia He wrote:
> We unconditionally set the HW_AFDBM capability and only enable it on
> CPUs which really have the feature. But sometimes we need to know
> whether this cpu has the capability of HW AF. So decouple AF from
> DBM by new helper cpu_has_hw_af().
>
> Signed-off-by: Jia He <justin.he@arm.com>
> Suggested-by: Suzuki Poulose <Suzuki.Poulose@arm.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> arch/arm64/include/asm/cpufeature.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
> index 9cde5d2e768f..949bc7c85030 100644
> --- a/arch/arm64/include/asm/cpufeature.h
> +++ b/arch/arm64/include/asm/cpufeature.h
> @@ -659,6 +659,16 @@ static inline u32 id_aa64mmfr0_parange_to_phys_shift(int parange)
> default: return CONFIG_ARM64_PA_BITS;
> }
> }
> +
> +/* Check whether hardware update of the Access flag is supported */
> +static inline bool cpu_has_hw_af(void)
> +{
> + if (IS_ENABLED(CONFIG_ARM64_HW_AFDBM))
> + return read_cpuid(ID_AA64MMFR1_EL1) & 0xf;
0xf? I think we should have a mask in sysreg.h for this constant.
Will
next prev parent reply other threads:[~2019-10-01 12:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 1:57 [PATCH v10 0/3] fix double page fault on arm64 Jia He
2019-09-30 1:57 ` [PATCH v10 1/3] arm64: cpufeature: introduce helper cpu_has_hw_af() Jia He
2019-10-01 12:54 ` Will Deacon [this message]
2019-10-01 13:18 ` Marc Zyngier
2019-10-08 1:12 ` Justin He (Arm Technology China)
2019-10-08 15:32 ` Suzuki K Poulose
2019-10-09 6:29 ` Jia He
2019-09-30 1:57 ` [PATCH v10 2/3] arm64: mm: implement arch_faults_on_old_pte() on arm64 Jia He
2019-10-01 12:50 ` Will Deacon
2019-10-01 13:32 ` Marc Zyngier
2019-10-08 1:55 ` Justin He (Arm Technology China)
2019-10-08 2:30 ` Justin He (Arm Technology China)
2019-10-08 7:46 ` Marc Zyngier
2019-09-30 1:57 ` [PATCH v10 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared Jia He
2019-10-01 12:54 ` Will Deacon
2019-10-08 2:19 ` Justin He (Arm Technology China)
2019-10-08 12:39 ` Will Deacon
2019-10-08 12:58 ` Justin He (Arm Technology China)
2019-10-08 14:32 ` Kirill A. Shutemov
2019-10-16 23:21 ` Palmer Dabbelt
2019-10-16 23:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001125446.gknoofnm7az4wqf5@willie-the-truck \
--to=will@kernel.org \
--cc=Kaly.Xin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=hejianet@gmail.com \
--cc=james.morse@arm.com \
--cc=justin.he@arm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=punitagrawal@gmail.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).