From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9D6C47404 for ; Fri, 11 Oct 2019 09:55:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EBE0920679 for ; Fri, 11 Oct 2019 09:55:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gkNHqsjQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBE0920679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E81B8E0007; Fri, 11 Oct 2019 05:55:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 998978E0001; Fri, 11 Oct 2019 05:55:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D5E18E0007; Fri, 11 Oct 2019 05:55:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 6FD998E0001 for ; Fri, 11 Oct 2019 05:55:09 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 08D851E06E for ; Fri, 11 Oct 2019 09:55:09 +0000 (UTC) X-FDA: 76031045538.15.tramp38_671c578824d36 X-HE-Tag: tramp38_671c578824d36 X-Filterd-Recvd-Size: 2382 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Oct 2019 09:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cFNx4WelrZkKlW7Ty3H+V6/wo9BQwgoSI66x0VapOuY=; b=gkNHqsjQPLZeZpKgRcC/H6AIO ePIX2BZBFGLFq7GsiXbNUK6RLVBdmFRM5ITX4gxt8FgkTvYMrezemuzA/5SL1uzbr5bGBrgAm7KXU oD7tESe9o6CbIeXnZncr3pLa4OgWQV69UBFOmVJL8Z6XDogBjxugdVzs9IiovifNGqDLGPv7qQL64 51CHWPUDCrGb/XKlmGRABLejAm0ZrBpz0NLl+QuL4ZR0Az3RQkq9HDsadkMMXE7APfxxn/t9IH2h/ rEsUCIwxiJCbzZXGa61LnJewFlm4xObvTQw+G0MU+SQbrGjWFH6EEjdNvz37lpfMJ0GL8cRIFcPoT cyco7Fy0Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIrdb-0003DA-9o; Fri, 11 Oct 2019 09:55:07 +0000 Date: Fri, 11 Oct 2019 02:55:07 -0700 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 26/26] xfs: use xfs_ail_push_all_sync in xfs_reclaim_inodes Message-ID: <20191011095507.GA8692@infradead.org> References: <20191009032124.10541-1-david@fromorbit.com> <20191009032124.10541-27-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009032124.10541-27-david@fromorbit.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > @@ -1106,6 +1111,9 @@ xfs_reclaim_inodes( > /* push the AIL to clean dirty reclaimable inodes */ > xfs_ail_push_all(mp->m_ail); > > + /* push the AIL to clean dirty reclaimable inodes */ > + xfs_ail_push_all(mp->m_ail); > + This is adding the third xfs_ail_push_all in a row with no comments why we'd want to do it multiple times. Is that a merge error or is there a good reason for that?