From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B345CA9EC9 for ; Fri, 1 Nov 2019 08:26:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 195E82067D for ; Fri, 1 Nov 2019 08:26:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eYGsULVy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 195E82067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A63686B0005; Fri, 1 Nov 2019 04:26:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EE2A6B0006; Fri, 1 Nov 2019 04:26:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 865956B0007; Fri, 1 Nov 2019 04:26:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 5EAB16B0005 for ; Fri, 1 Nov 2019 04:26:44 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 07254181AEF1E for ; Fri, 1 Nov 2019 08:26:44 +0000 (UTC) X-FDA: 76107027528.22.way03_74f13fe3b424b X-HE-Tag: way03_74f13fe3b424b X-Filterd-Recvd-Size: 4502 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 Nov 2019 08:26:43 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id 15so6034398pgt.7 for ; Fri, 01 Nov 2019 01:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oh98aFnZRorcgBP9rDlhbsNHmCQIwQJD1onE6tzClUk=; b=eYGsULVyapRvnlWj6s0n+wvktQgBnT8ppzZ5wbaoq71VC0NWjE8x3jMrzuZTxPLvaF x6cuKODCAz73Oy/gvltnDQPY75lDoxr2qZCpNEnn8PNGtrbDn7bbyfSlgm5vLOc9ANV2 ZPUTxzq+Q9HcW+pDdfxUdkpYhn9ppWsj0eBGKN4oaaJmV3mHdksayNmjPnWr0GMbm7Yt o3Cj9aaBm16S9tzfIyv1RoDyiLUxOAp7q3RMbKGtDFHiwSkV58qtENDiyHZp28B0RdXq mWli0ArGxHaSsRohs7y1Z6RhpXbpYg01UV2uJBNPB2llk/1FpkDCjEYsAjIoHRrjZdnK i7+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oh98aFnZRorcgBP9rDlhbsNHmCQIwQJD1onE6tzClUk=; b=XJjFRN27A/nLugabHtJgdwYVQZIGf8SeV3fzPACaTMu11uWqnDhoGqaz2mDtLXb14J DLlK1a0Q9UlLOXky0tgW+Ha561Cxg6Vfl1irE6EgITExFxPhphrMxMHiAIsfMet4BSro jL9k6X9AS7YaYcrrKKEywPCwUBkWg25DIz/oHJbabHqcq+s4PFRhEQSzc0yaa2NBQCWG SvMQrUpXhvjYQib3WrMaYsnCaafBIX1v/EMq2KABcio7HoqJk4vUVfsln0afM8zgJll4 zDBh+Zaei1cYgpbWw0N6YXiqMVOl7wM9bksVkYECez6MkTaeYUaepjtsdG6JfcHX4AYs poCg== X-Gm-Message-State: APjAAAU4EEot+99FghNVCDHxR86eYh0hmzaIgSvGz3YUQfRtQJtpIhEq WpIZLVu48xXxsa5obmszk7o= X-Google-Smtp-Source: APXvYqziwmYXovKIWSSfOr2J4r9be7mcMaizG4hJTPJHn35Zoy+Yv1hPIf1A1GPxFfPLwNdX+lkRDQ== X-Received: by 2002:a63:4b52:: with SMTP id k18mr11643600pgl.394.1572596802409; Fri, 01 Nov 2019 01:26:42 -0700 (PDT) Received: from localhost ([2401:fa00:8f:203:250d:e71d:5a0a:9afe]) by smtp.gmail.com with ESMTPSA id g38sm5862052pgb.27.2019.11.01.01.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Nov 2019 01:26:41 -0700 (PDT) Date: Fri, 1 Nov 2019 17:26:39 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: glider@google.com, Andrew Morton , Greg Kroah-Hartman , Eric Dumazet , Wolfram Sang , Vegard Nossum , Dmitry Vyukov , linux-mm@kvack.org, viro@zeniv.linux.org.uk, aryabinin@virtuozzo.com, luto@kernel.org, ard.biesheuvel@linaro.org, arnd@arndb.de, hch@lst.de, dmitry.torokhov@gmail.com, ericvh@gmail.com, harry.wentland@amd.com, herbert@gondor.apana.org.au, mingo@elte.hu, axboe@kernel.dk, martin.petersen@oracle.com, schwidefsky@de.ibm.com, mst@redhat.com, monstr@monstr.eu, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, tiwai@suse.com, tytso@mit.edu, tglx@linutronix.de, gor@linux.ibm.com, iii@linux.ibm.com, mark.rutland@arm.com, willy@infradead.org, rdunlap@infradead.org, andreyknvl@google.com, elver@google.com Subject: Re: [PATCH RFC v2 18/25] kmsan: call KMSAN hooks where needed Message-ID: <20191101082639.GA19790@google.com> References: <20191030142237.249532-1-glider@google.com> <20191030142237.249532-19-glider@google.com> <20191031114916.ikz3phubs4jqdmnf@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031114916.ikz3phubs4jqdmnf@pathway.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (19/10/31 12:49), Petr Mladek wrote: > > Please, separate the two comments with an empty line instead of using > */ and /*. > > > + * If any of vscnprintf() arguments is uninitialized, KMSAN will report > > + * one or more errors and also probably mark text_len as uninitialized. > > + * Initialize |text_len| to prevent the errors from spreading further. > > + */ > > + text_len = KMSAN_INIT_VALUE(vscnprintf(text, sizeof(textbuf), fmt, > > + args)); Or maybe this can be text_len = vscnprintf(text, sizeof(textbuf), fmt, args); + KMSAN_INIT_VALUE(text_len); -ss