From: "Li Xinhai" <lixinhai.lxh@gmail.com>
To: "linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: akpm <akpm@linux-foundation.org>, mhocko <mhocko@suse.com>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
yang.shi <yang.shi@linux.alibaba.com>,
n-horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH 2/2] mm/mempolicy: Skip walking HUGETLB vma if MPOL_MF_STRICT is specified alone
Date: Tue, 14 Jan 2020 22:09:25 +0800 [thread overview]
Message-ID: <2020011422092314671410@gmail.com> (raw)
In-Reply-To: 1578993378-10860-2-git-send-email-lixinhai.lxh@gmail.com
Add cc to
Yang Shi <yang.shi@linux.alibaba.com>
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
, who has been worked on this part
On 2020-01-14 at 17:16 Li Xinhai wrote:
>Checking MPOL_MF_STRICT is ignored for HUGETLB vma according to mbind man
>page:
>
>Notes
>MPOL_MF_STRICT is ignored on huge page mappings.
>
>If MPOL_MF_STRICT is specified alone without any MOVE flag, we should
>indicate, from test_walk, that walking this vma should be skipped even if
>there are misplaced pages.
>
>Signed-off-by: Li Xinhai <lixinhai.lxh@gmail.com>
>Cc: Michal Hocko <mhocko@suse.com>
>Cc: Mike Kravetz <mike.kravetz@oracle.com>
>---
> mm/mempolicy.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/mm/mempolicy.c b/mm/mempolicy.c
>index 067cf7d..c117b5f 100644
>--- a/mm/mempolicy.c
>+++ b/mm/mempolicy.c
>@@ -656,6 +656,13 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
> return 1;
> }
>
>+ /* MPOL_MF_STRICT is ignored for huge page, skip checking
>+ * misplaced pages
>+ */
>+ if ((flags & MPOL_MF_VALID) == MPOL_MF_STRICT &&
>+ is_vm_hugetlb_page(vma))
>+ return 1;
>+
> /* queue pages from current vma */
> if (flags & MPOL_MF_VALID)
> return 0;
>--
>1.8.3.1
>
next prev parent reply other threads:[~2020-01-14 14:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 9:16 [PATCH 1/2] mm/mempolicy: Checking hstate for hugetlbfs page in vma_migratable Li Xinhai
2020-01-14 9:16 ` [PATCH 2/2] mm/mempolicy: Skip walking HUGETLB vma if MPOL_MF_STRICT is specified alone Li Xinhai
2020-01-14 14:09 ` Li Xinhai [this message]
2020-01-14 18:27 ` Yang Shi
2020-01-15 1:07 ` Mike Kravetz
2020-01-15 1:24 ` Yang Shi
2020-01-15 4:28 ` Mike Kravetz
2020-01-15 5:23 ` Yang Shi
2020-01-15 7:36 ` Li Xinhai
2020-01-15 17:16 ` Yang Shi
2020-01-15 21:07 ` Mike Kravetz
2020-01-15 21:30 ` Yang Shi
2020-01-15 21:45 ` Mike Kravetz
2020-01-15 21:59 ` Yang Shi
2020-01-16 8:07 ` HORIGUCHI NAOYA(堀口 直也)
2020-01-16 15:32 ` Li Xinhai
2020-01-16 7:59 ` Michal Hocko
2020-01-16 19:22 ` Mike Kravetz
2020-01-17 2:32 ` Yang Shi
2020-01-17 2:38 ` Li Xinhai
2020-01-17 7:57 ` Michal Hocko
2020-01-17 12:05 ` Li Xinhai
2020-01-17 15:20 ` Michal Hocko
2020-01-17 15:46 ` Li Xinhai
2020-01-20 12:45 ` Michal Hocko
2020-01-21 14:15 ` Li Xinhai
2020-01-21 14:53 ` Michal Hocko
2020-01-22 13:55 ` Li Xinhai
2020-01-14 19:12 ` [PATCH 1/2] mm/mempolicy: Checking hstate for hugetlbfs page in vma_migratable Mike Kravetz
2020-01-15 1:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2020011422092314671410@gmail.com \
--to=lixinhai.lxh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).