From: <sjpark@amazon.com>
To: Qian Cai <cai@lca.pw>
Cc: <sjpark@amazon.com>, <akpm@linux-foundation.org>,
SeongJae Park <sjpark@amazon.de>, <sj38.park@gmail.com>,
<acme@kernel.org>, <amit@kernel.org>, <brendan.d.gregg@gmail.com>,
<corbet@lwn.net>, <dwmw@amazon.com>, <mgorman@suse.de>,
<rostedt@goodmis.org>, <kirill@shutemov.name>,
<brendanhiggins@google.com>, <colin.king@canonical.com>,
<minchan@kernel.org>, <vdavydov.dev@gmail.com>,
<vdavydov@parallels.com>, <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH v2 0/9] Introduce Data Access MONitor (DAMON)
Date: Tue, 28 Jan 2020 11:49:42 +0100 [thread overview]
Message-ID: <20200128104942.11419-1-sjpark@amazon.com> (raw)
In-Reply-To: <D20B234E-04EE-4410-9B27-FF63AB3E1808@lca.pw> (raw)
On Tue, 28 Jan 2020 05:20:35 -0500 Qian Cai <cai@lca.pw> wrote:
>
>
> > On Jan 28, 2020, at 3:58 AM, sjpark@amazon.com wrote:
> >
> > This patchset introduces a new kernel module for practical monitoring of data
> > accesses, namely DAMON.
> >
> > The patches are organized in the following sequence. The first four patches
> > implements the core logic of DAMON one by one. After that, the fifth patch
> > implements DAMON's debugfs interface for users. To provide a minimal reference
> > to the low level interface and for more convenient use/tests of the DAMON, the
> > sixth patch implements an user space tool. The seventh patch adds a document
> > for administrators of DAMON, and the eightth patch provides DAMON's kunit
> > tests. Finally, the ninth patch implements a tracepoint for DAMON. As the
> > tracepoint prints every monitoring results, it will be easily integrated with
> > other tracers supporting tracepoints including perf.
>
> I am a bit surprised that this patchset did not include perf maintainers which makes me wonder if there is any attempt to discuss first if we actually need a whole new subsystem for it or a existing tool can be enhanced.
For the comments from perf maintainers, I added Steven Rostedt and Arnaldo
Carvalho de Melo first, but I might missed someone. If you recommend some more
people, I will add them to recipients.
I made DAMON as a new subsystem because I think no existing subsystem fits well
to be a base of DAMON, due to DAMON's unique goals and mechanisms described
below in the original cover letter.
The existing subsystem that most similar to DAMON might be 'mm/page_idle.c'.
However, there are many conceptual differences with DAMON. One biggest
difference I think is the target. 'page_idle' deals with physical page frames
while DAMON deals with virtual address of specific processes.
Nevertheless, if you have some different opinion, please let me know.
Thanks,
SeongJae Park
next prev parent reply other threads:[~2020-01-28 10:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 8:57 [PATCH v2 0/9] Introduce Data Access MONitor (DAMON) sjpark
2020-01-28 8:57 ` [PATCH v2 1/9] mm: " sjpark
2020-01-28 16:06 ` Randy Dunlap
2020-01-28 16:09 ` sjpark
2020-01-30 23:58 ` Brendan Higgins
2020-01-31 4:38 ` SeongJae Park
2020-01-28 8:57 ` [PATCH v2 2/9] mm/damon: Implement region based sampling sjpark
2020-01-28 8:57 ` [PATCH v2 3/9] mm/damon: Adaptively adjust regions sjpark
2020-01-28 8:57 ` [PATCH v2 4/9] mm/damon: Apply dynamic memory mapping changes sjpark
2020-01-28 8:59 ` [PATCH v2 5/9] mm/damon: Add debugfs interface sjpark
2020-01-28 9:00 ` [PATCH v2 6/9] mm/damon: Add minimal user-space tools sjpark
2020-01-31 0:02 ` Brendan Higgins
2020-01-31 4:44 ` SeongJae Park
2020-02-01 8:52 ` SeongJae Park
2020-01-28 9:00 ` [PATCH v2 7/9] Documentation/admin-guide/mm: Add a document for DAMON sjpark
2020-01-28 9:01 ` [PATCH v2 8/9] mm/damon: Add kunit tests sjpark
2020-01-31 0:14 ` Brendan Higgins
2020-01-31 4:55 ` SeongJae Park
2020-01-28 9:01 ` [PATCH v2 9/9] mm/damon: Add a tracepoint for result buffer writing sjpark
2020-01-28 10:20 ` [PATCH v2 0/9] Introduce Data Access MONitor (DAMON) Qian Cai
2020-01-28 10:49 ` sjpark [this message]
2020-01-28 11:20 ` Qian Cai
2020-01-28 12:00 ` sjpark
2020-01-29 12:56 ` Peter Zijlstra
2020-01-29 14:37 ` sjpark
2020-01-29 18:07 ` Peter Zijlstra
2020-01-29 19:06 ` SeongJae Park
2020-01-29 19:36 ` Peter Zijlstra
2020-01-29 19:59 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128104942.11419-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=amit@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=brendanhiggins@google.com \
--cc=cai@lca.pw \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=dwmw@amazon.com \
--cc=kirill@shutemov.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=vdavydov.dev@gmail.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).