From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C636C35240 for ; Wed, 29 Jan 2020 19:07:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D81720708 for ; Wed, 29 Jan 2020 19:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="roHPqOct" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D81720708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C11246B028B; Wed, 29 Jan 2020 14:07:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE8156B028C; Wed, 29 Jan 2020 14:07:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFE006B028D; Wed, 29 Jan 2020 14:07:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 98AA16B028B for ; Wed, 29 Jan 2020 14:07:02 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4DF5045BB for ; Wed, 29 Jan 2020 19:07:02 +0000 (UTC) X-FDA: 76431604284.13.ants53_779750293a61a X-HE-Tag: ants53_779750293a61a X-Filterd-Recvd-Size: 5848 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jan 2020 19:07:01 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id m16so731734wrx.11 for ; Wed, 29 Jan 2020 11:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=al7sS8M/717VVwE5/5undtsrujO0rBt1ejoTK551OXU=; b=roHPqOct4H2fUnD1pHVGmgmSikEmDQNoEYZkr6TOdKdwQEtvlV+qs5evNQE98ZWUAD VRKeTtA7jci2d9tKD/kkRkO2+uJ+hAzyc2SPdAQnVP78nGVlesuEqpcFMrODYP1OE81I G9Px2zca/2/XI9FjUS1YcTpaEHobU5Zc6iVp/q1nkCQ7mo969s1NLZYSM2R3cssius5F qsQHUkdpC1g4GvEbBjn3wfvSwRU3UXsXbkviMhc2LPwRvp/c2Ry12AzUfZxlJLhGs6JI 8ysXin9KRNZjjCD8yCip8Y9cdyTQFpXd9erT6mwd7e6MDOZEz184ea30jKLHCa3/OOtx wOKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=al7sS8M/717VVwE5/5undtsrujO0rBt1ejoTK551OXU=; b=VPqDylhShoUkSyMabg2ekKuG6V4XCTU2CUQkldzPOScLpiLHMM64UxI/PcEsdQRXS7 dIET+N/T+D9RRebpWMtuPMCkJlTsd3enWgO2q+B6r+/+jAFZfSGUixHmV4bDO4JII+zD lkOlbrPqkan7GnVWzePSEoagpdfP6lhcJW0R8YdwY/kNFIuiRYoLzRcYw6AYrwEuwdoJ Zq78d115PIT9HpwTIW4rCeJgpUJTKR0mXZYdfuCuAd7h0YBc9B/r53xeeZQKwlTbVale R6otfsQY+y84cAM+CEiAFllpRRob6D3YdIOZjb58cN07cV9ER0XSE+HAw2Us/reAVeqv sXpg== X-Gm-Message-State: APjAAAV+ECw1zFVcg5ZZAy0Kdwb+AjTNm11iollmNf5W3f/mUKuPTzOl o9APgKRmVZGyt6nb5jBnU4U= X-Google-Smtp-Source: APXvYqxsho39zIYkW621J2+3KehlPpfaeZRm1g1ckm9qtB1a/J+Ibv7yleSTCW/ngxMKmpetgLZC/A== X-Received: by 2002:adf:e3cd:: with SMTP id k13mr310720wrm.338.1580324820489; Wed, 29 Jan 2020 11:07:00 -0800 (PST) Received: from localhost.localdomain ([2a02:2450:10d2:194d:8f9:806b:30e8:a48e]) by smtp.gmail.com with ESMTPSA id a9sm3301053wmm.15.2020.01.29.11.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 11:06:59 -0800 (PST) From: SeongJae Park To: Peter Zijlstra Cc: sjpark@amazon.com, akpm@linux-foundation.org, SeongJae Park , sj38.park@gmail.com, acme@kernel.org, amit@kernel.org, brendan.d.gregg@gmail.com, corbet@lwn.net, dwmw@amazon.com, mgorman@suse.de, rostedt@goodmis.org, kirill@shutemov.name, brendanhiggins@google.com, colin.king@canonical.com, minchan@kernel.org, vdavydov.dev@gmail.com, vdavydov@parallels.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim Subject: Re: Re: Re: Re: [PATCH v2 0/9] Introduce Data Access MONitor (DAMON) Date: Wed, 29 Jan 2020 20:06:45 +0100 Message-Id: <20200129190645.2137-1-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200129180709.GS14879@hirez.programming.kicks-ass.net> (raw) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 29 Jan 2020 19:07:09 +0100 Peter Zijlstra wrote: > On Wed, Jan 29, 2020 at 03:37:58PM +0100, sjpark@amazon.com wrote: > > On Wed, 29 Jan 2020 13:56:15 +0100 Peter Zijlstra wrote: > > > > > On Tue, Jan 28, 2020 at 01:00:33PM +0100, sjpark@amazon.com wrote: > > > > > > > I worried whether it could be a bother to send the mail to everyone in the > > > > section, but seems it was an unnecessary worry. Adding those to recipients. > > > > You can get the original thread of this patchset from > > > > https://lore.kernel.org/linux-mm/20200128085742.14566-1-sjpark@amazon.com/ > > > > > > I read first patch (the document) and still have no friggin clue. > > > > Do you mean the document has insufficient description only? If so, could you > > please point me me which information do you want to be added? > > There was a lot of words; but I'm still not sure what it actually does. Sorry for my bad writing skill. Will restructure and wordsmith it for next spin. > > I've read some of the code that followed; is it simply sampling the > page-table access bit? It did some really weird things though, like that > whole 3 regions thing. Because simple Accessed bit sampling cannot preserve the accuracy of the monitored access patterns, we use the mechanism called 'region based sampling'. The patch introducing the mechanism would seems weird, mainly because it relies on another mechanism follows the patch. I should mentioned about it with the patch. I will add the description in next spin so people can understand that. > > Also, you wrote you wanted feedback from perf people; but it doesn't use > perf, what are you asking? DAMON aims to be another source of data that perf, other profiling tools, or even other kernel space code can use. Therefore I wanted to get some opinions about whether this data seems useful and how perf developers want the interface of DAMON to be shaped for co-operation with perf. Will make this more clear with next spin's cover letter. > > Perf can do address based sampling of memops, I suspect you can create > something using that. If you're saying implementing DAMON in 'perf mem', I think it would conflict with abovely explained DAMON's goal. Else, if you're saying it would be the right place to handle the DAMON generated data, I agree, thank you for pointing me that. Will keep it in mind while shaping the interface of DAMON. Thanks, SeongJae Park