From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0671C3F68F for ; Thu, 6 Feb 2020 08:04:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC032214AF for ; Thu, 6 Feb 2020 08:04:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC032214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7DFF36B0007; Thu, 6 Feb 2020 03:04:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78F6E6B0008; Thu, 6 Feb 2020 03:04:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A5606B000A; Thu, 6 Feb 2020 03:04:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 5226B6B0007 for ; Thu, 6 Feb 2020 03:04:41 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EB392180AD802 for ; Thu, 6 Feb 2020 08:04:40 +0000 (UTC) X-FDA: 76458965520.24.room75_28d4219c78757 X-HE-Tag: room75_28d4219c78757 X-Filterd-Recvd-Size: 1858 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 6 Feb 2020 08:04:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id ACCC6B221; Thu, 6 Feb 2020 08:04:38 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 91B721E0E31; Thu, 6 Feb 2020 09:04:38 +0100 (CET) Date: Thu, 6 Feb 2020 09:04:38 +0100 From: Jan Kara To: John Hubbard Cc: Jan Kara , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 8/8] xarray: Don't clear marks in xas_store() Message-ID: <20200206080438.GC14001@quack2.suse.cz> References: <20200204142514.15826-1-jack@suse.cz> <20200204142514.15826-9-jack@suse.cz> <8ea2682b-7240-dca3-b123-2df7d0c994ba@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ea2682b-7240-dca3-b123-2df7d0c994ba@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 05-02-20 14:19:34, John Hubbard wrote: > On 2/4/20 6:25 AM, Jan Kara wrote: > > When storing NULL in xarray, xas_store() has been clearing all marks > > because it could otherwise confuse xas_for_each_marked(). That is > > however no longer true and no current user relies on this behavior. > > > However, let's not forget that the API was also documented to behave > in this way--it's not an accidental detail. Below... Yeah, we'll need to sort out details how we want the API to be used but thanks for reminding me I should update the documentation :). It was on my radar but then I forgot... Honza -- Jan Kara SUSE Labs, CR