From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6415CC352A2 for ; Thu, 6 Feb 2020 14:40:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A79D2082E for ; Thu, 6 Feb 2020 14:40:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A79D2082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D468B6B0008; Thu, 6 Feb 2020 09:40:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCEB36B000A; Thu, 6 Feb 2020 09:40:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE51C6B000C; Thu, 6 Feb 2020 09:40:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id A49026B0008 for ; Thu, 6 Feb 2020 09:40:30 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4FC6A249F for ; Thu, 6 Feb 2020 14:40:30 +0000 (UTC) X-FDA: 76459963020.30.skirt14_45e78d45fe2c X-HE-Tag: skirt14_45e78d45fe2c X-Filterd-Recvd-Size: 2032 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 6 Feb 2020 14:40:29 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 898B8ADAD; Thu, 6 Feb 2020 14:40:28 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 85E87DA952; Thu, 6 Feb 2020 15:40:15 +0100 (CET) Date: Thu, 6 Feb 2020 15:40:15 +0100 From: David Sterba To: Jan Kara Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/8] mm: Speedup page cache truncation Message-ID: <20200206144015.GY2654@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Jan Kara , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20200204142514.15826-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200204142514.15826-1-jack@suse.cz> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 04, 2020 at 03:25:06PM +0100, Jan Kara wrote: > Hello, > > conversion of page cache to xarray (commit 69b6c1319b6 "mm: Convert truncate to > XArray" in particular) has regressed performance of page cache truncation > by about 10% (see my original report here [1]). This patch series aims at > improving the truncation to get some of that regression back. > > The first patch fixes a long standing bug with xas_for_each_marked() that I've > uncovered when debugging my patches. The remaining patches then work towards > the ability to stop clearing marks in xas_store() which improves truncation > performance by about 6%. > > The patches have passed radix_tree tests in tools/testing and also fstests runs > for ext4 & xfs. I've tested the patchset on btrfs too, no problems found.