From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43916C2BA83 for ; Thu, 13 Feb 2020 09:10:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 060A421734 for ; Thu, 13 Feb 2020 09:10:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="nCCsff84" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 060A421734 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D21B6B0526; Thu, 13 Feb 2020 04:10:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8828C6B0527; Thu, 13 Feb 2020 04:10:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 770846B0528; Thu, 13 Feb 2020 04:10:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id 5BBFE6B0526 for ; Thu, 13 Feb 2020 04:10:14 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 00594181AEF09 for ; Thu, 13 Feb 2020 09:10:13 +0000 (UTC) X-FDA: 76484532348.27.order08_16aa2ee1482a X-HE-Tag: order08_16aa2ee1482a X-Filterd-Recvd-Size: 5489 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 09:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1581585010; x=1613121010; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=5zK64KITLcQjS6f6/zvuoFVwDohflsNQOJAoV/nzry0=; b=nCCsff84U0Fa+gXTcjR+uyjb4gjGA18k6kIAJkKVmzeg6cVxX74+KHHE jN3KXh2PFAdC7gXdjXurTMPRV8OD6QfCsPWSXt8exSFPWPTaDTYw0ZnLN GWDiyp5ONuDxqhYPbfTEIibmmahOfE1ZNFE5iZK/2EjtgA4civPRFiGMd s=; IronPort-SDR: 3+SNpXZS1vv6k+McXcBL93v+BWSeBf4hX7OpFmadPl/isR6s0UEw/8BDFRt5AeB1LVWMgIRs3S gGb6YZZOw2Jw== X-IronPort-AV: E=Sophos;i="5.70,436,1574121600"; d="scan'208";a="26169876" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2a-f14f4a47.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 13 Feb 2020 09:10:06 +0000 Received: from EX13MTAUEA002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2a-f14f4a47.us-west-2.amazon.com (Postfix) with ESMTPS id 25895A18BA; Thu, 13 Feb 2020 09:10:05 +0000 (UTC) Received: from EX13D31EUA001.ant.amazon.com (10.43.165.15) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Thu, 13 Feb 2020 09:10:04 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.160.92) by EX13D31EUA001.ant.amazon.com (10.43.165.15) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 13 Feb 2020 09:09:53 +0000 From: SeongJae Park To: kbuild test robot CC: , , , SeongJae Park , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: Re: [PATCH v4 05/11] mm/damon: Implement kernel space API Date: Thu, 13 Feb 2020 10:09:37 +0100 Message-ID: <20200213090937.9368-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <202002130710.3P1Y98f7%lkp@intel.com> (raw) MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.160.92] X-ClientProxiedBy: EX13D23UWC003.ant.amazon.com (10.43.162.81) To EX13D31EUA001.ant.amazon.com (10.43.165.15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 13 Feb 2020 07:21:37 +0800 kbuild test robot wrote: > [-- Attachment #1: Type: text/plain, Size: 937 bytes --] > > Hi, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on d5226fa6dbae0569ee43ecfc08bdcd6770fc4755] > > url: https://github.com/0day-ci/linux/commits/sjpark-amazon-com/Introduce-Data-Access-MONitor-DAMON/20200213-003254 > base: d5226fa6dbae0569ee43ecfc08bdcd6770fc4755 > config: m68k-allmodconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 7.5.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.5.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > >> ERROR: "lookup_page_ext" [mm/damon.ko] undefined! Thank you for finding this problem, kbuild! This problem comes when `CONFIG_DAMON=m` and `CONFIG_64BIT` unset because `lookup_page_ext()`, which is used by `page_idle.h` if `CONFIG_64BIT` unset, is not exported. Most simple fix would be avoiding module build of DAMON as below:: diff --git a/mm/Kconfig b/mm/Kconfig index b279ab9c78d0..f24dd670baad 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -740,7 +740,7 @@ config MAPPING_DIRTY_HELPERS bool config DAMON - tristate "Data Access Monitor" + bool "Data Access Monitor" depends on MMU default n help Or, exporting the symbol as below:: diff --git a/mm/page_ext.c b/mm/page_ext.c index 4ade843ff588..e6e6b7e625e4 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -131,6 +131,7 @@ struct page_ext *lookup_page_ext(const struct page *page) MAX_ORDER_NR_PAGES); return get_entry(base, index); } +EXPORT_SYMBOL(lookup_page_ext); static int __init alloc_node_page_ext(int nid) { I of course prefer this fix but unsure whether exporting this symbol is ok or not. May I ask your opinions? Thanks, SeongJae Park > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > [-- Attachment #2: .config.gz --] > [-- Type: application/gzip, Size: 51870 bytes --]