From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan.c: only adjust related kswapd cpu affinity when online cpu
Date: Thu, 13 Feb 2020 21:32:07 -0800 [thread overview]
Message-ID: <20200213213207.34b2aa0e0c2c92a09b700e96@linux-foundation.org> (raw)
In-Reply-To: <20200128003942.GC20624@richard>
On Tue, 28 Jan 2020 08:39:42 +0800 Wei Yang <richardw.yang@linux.intel.com> wrote:
> >Is there ever a situation where the cpu to be onlined would have appeared
> >in the cpumask of another node and so a different kswapd's cpumask would
> >now include an off-node cpu?
>
> No, I don't think so.
>
> Per my understanding, kswapd_cpu_online() will be invoked when a cpu is
> onlined. And the particular cpu belongs to a particular numa node. So it is
> not necessary to iterate on every nodes.
>
> And current code use cpumask_and_any() to do the check. If my understanding is
> correct, the check would return true if this node has any online cpu. This is
> likely to be true.
>
> This is why I want to make the logic clear.
Please resend with a changelog which explains the above?
prev parent reply other threads:[~2020-02-14 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 13:20 [PATCH] mm/vmscan.c: only adjust related kswapd cpu affinity when online cpu Wei Yang
2020-01-26 22:44 ` David Rientjes
2020-01-28 0:39 ` Wei Yang
2020-02-14 5:32 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213213207.34b2aa0e0c2c92a09b700e96@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).