From: Christoph Hellwig <hch@infradead.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
linux-api@vger.kernel.org, oleksandr@redhat.com,
Suren Baghdasaryan <surenb@google.com>,
Tim Murray <timmurray@google.com>,
Daniel Colascione <dancol@google.com>,
Sandeep Patil <sspatil@google.com>,
Sonny Rao <sonnyrao@google.com>,
Brian Geffon <bgeffon@google.com>, Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
John Dias <joaodias@google.com>,
Joel Fernandes <joel@joelfernandes.org>,
sj38.park@gmail.com, alexander.h.duyck@linux.intel.com,
Jann Horn <jannh@google.com>,
Christian Brauner <christian@brauner.io>
Subject: Re: [PATCH v5 4/7] pid: export pidfd_get_pid
Date: Sun, 16 Feb 2020 23:59:40 -0800 [thread overview]
Message-ID: <20200217075940.GA10342@infradead.org> (raw)
In-Reply-To: <20200214170520.160271-5-minchan@kernel.org>
On Fri, Feb 14, 2020 at 09:05:17AM -0800, Minchan Kim wrote:
> process_madvise syscall needs pidfd_get_pid function to translate
> pidfd to pid so this patch exports the function.
For that it should not need to exported, but then again the actual
patch doesn't export it anyway, so this is just a commit log issue.
> extern struct pid *pidfd_pid(const struct file *file);
> +extern struct pid *pidfd_get_pid(unsigned int fd);
... and there is no need for the extern keyword on prototypes in
headers.
next prev parent reply other threads:[~2020-02-17 7:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 17:05 [PATCH v5 0/7] introduce memory hinting API for external process Minchan Kim
2020-02-14 17:05 ` [PATCH v5 1/7] mm: pass task and mm to do_madvise Minchan Kim
2020-02-14 17:25 ` Jann Horn
2020-02-14 18:22 ` Jens Axboe
2020-02-14 18:45 ` Minchan Kim
2020-02-14 19:09 ` Jens Axboe
2020-02-14 19:31 ` Minchan Kim
2020-02-14 17:05 ` [PATCH v5 2/7] mm: introduce external memory hinting API Minchan Kim
2020-02-14 17:05 ` [PATCH v5 3/7] mm: check fatal signal pending of target process Minchan Kim
2020-02-14 17:05 ` [PATCH v5 4/7] pid: export pidfd_get_pid Minchan Kim
2020-02-17 7:59 ` Christoph Hellwig [this message]
2020-02-19 1:02 ` Minchan Kim
2020-02-14 17:05 ` [PATCH v5 5/7] mm: support both pid and pidfd for process_madvise Minchan Kim
2020-02-14 17:05 ` [PATCH v5 6/7] mm/madvise: employ mmget_still_valid for write lock Minchan Kim
2020-02-14 17:05 ` [PATCH v5 7/7] mm/madvise: allow KSM hints for remote API Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217075940.GA10342@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=bgeffon@google.com \
--cc=christian@brauner.io \
--cc=dancol@google.com \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=joaodias@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oleksandr@redhat.com \
--cc=shakeelb@google.com \
--cc=sj38.park@gmail.com \
--cc=sonnyrao@google.com \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=timmurray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).