From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D1FC11D0C for ; Thu, 20 Feb 2020 15:54:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 68D1B24656 for ; Thu, 20 Feb 2020 15:54:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="STo0szeH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68D1B24656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5E16C6B0008; Thu, 20 Feb 2020 10:54:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8636B000A; Thu, 20 Feb 2020 10:54:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457DA6B000C; Thu, 20 Feb 2020 10:54:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 2BC136B0008 for ; Thu, 20 Feb 2020 10:54:09 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D364B180AD81D for ; Thu, 20 Feb 2020 15:54:08 +0000 (UTC) X-FDA: 76510951776.26.steel23_6ffdde8bf42c X-HE-Tag: steel23_6ffdde8bf42c X-Filterd-Recvd-Size: 10440 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Feb 2020 15:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582214047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z3v3MgEXYlq++fxyWt1LWB1BeQqvPhledSlVojmQND0=; b=STo0szeHI796a0LomOorskJ0sJGw9fY/sjJg8eZhXik3CIew7qwN+L/s3CMpCNEkT3/8o3 aegY1wiEcQJaRaRQF50L5ijeUpKgKkuiPH6zQc4xI7Y3alIhOsV6vssNnKPc8YdbR+spmT KWgar9kRcT6HEsQXGk05TKaXA5Ata18= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-wvoMgAiKOWSCnNVRFgoN-g-1; Thu, 20 Feb 2020 10:53:57 -0500 X-MC-Unique: wvoMgAiKOWSCnNVRFgoN-g-1 Received: by mail-qt1-f199.google.com with SMTP id l1so2847755qtp.21 for ; Thu, 20 Feb 2020 07:53:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bt1+d0titgQLhNFh5svjyDyx7KYPhkET1LH3nLMC49s=; b=tBcpUGZwpJhn4mFM2ONxRFkCTCD5qu4IQ1jUoFguV4cE0/qxnu5ynrgCYZH1bjlvMC AiW8htG6JgncN1H7E+yYmP2+sfvJVy39sErpCF5KMPOAKO9IvamXwq/cyOTEfOutIELa b/FQbmXkMmU/cOhGvd8rAHRaJ2uvEQ3CyUntL4tjyVKZVpgdErPHA/nUKP17HWqjguDL El1WrPCyJvMOOShIDdD6FHaKt+/AnQ4xBdVD7j+ADI8BhFxLZ6bq5r38dem91c8JIMye 0JuFgzQHaKGJ/SAbIRRCKtacDxzfEcCj8GAE+WdAErTfCWefnd68atKPBsIkgUzltAIU ooiQ== X-Gm-Message-State: APjAAAV6KZgiC8hibxHiO+d3Cq6xugfUOW6h+TLztRRKA3PZIC7Eaw4+ /FnGycUVFtM03tBw6wfecTkl7eIauuVDkQFrf0XumxGaMlDB9HFyrzPoMCb9ep2af+eV++ouOSG xaTONnhm8SG4= X-Received: by 2002:a37:742:: with SMTP id 63mr28733626qkh.31.1582214036640; Thu, 20 Feb 2020 07:53:56 -0800 (PST) X-Google-Smtp-Source: APXvYqw9VCY2D+VSq59waXKZrbNuFOOodktVtmIMdjUJndOOkfNMPF5sQK84kzKhe5Pjf4jsVs0qLg== X-Received: by 2002:a37:742:: with SMTP id 63mr28733594qkh.31.1582214036304; Thu, 20 Feb 2020 07:53:56 -0800 (PST) Received: from xz-x1.redhat.com ([104.156.64.75]) by smtp.gmail.com with ESMTPSA id h20sm1807430qkk.64.2020.02.20.07.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 07:53:55 -0800 (PST) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Andrea Arcangeli , Martin Cracauer , Linus Torvalds , Mike Rapoport , "Kirill A . Shutemov" , Johannes Weiner , "Dr . David Alan Gilbert" , David Hildenbrand , Bobby Powers , Maya Gokhale , Jerome Glisse , Mike Kravetz , Matthew Wilcox , Marty McFadden , Mel Gorman , peterx@redhat.com, Hugh Dickins , Brian Geffon , Denis Plotnikov , Pavel Emelyanov Subject: [PATCH RESEND v6 00/16] mm: Page fault enhancements Date: Thu, 20 Feb 2020 10:53:37 -0500 Message-Id: <20200220155353.8676-1-peterx@redhat.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [Resend v6] This is v6 of the series. It is majorly a rebase to 5.6-rc2, nothing else to be expected (plus some tests after the rebase). Instead of rewrite the cover letter I decided to use what we have for v5. Adding extra CCs for both Bobby Powers and Brian Geffon . Online repo: https://github.com/xzpeter/linux/tree/mm-pf-signal-retry Any review comment is appreciated. Thanks, =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D v5 cover letter =3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This is v5 of the series. As Matthew suggested, I split the previous patch "mm: Return faster for non-fatal signals in user mode faults" into a few smaller ones: 1. One patch to introduce fatal_signal_pending(), and use it in archs that can directly apply 2. A few more patches to let the rest archs to use the new helper. With that we can have an unified entry for signal detection 3. One last patch to change fatal_signal_pending() to detect userspace non-fatal signal Nothing should have changed in the rest patches. Because the fault retry patches will depend on the previous ones, I decided to simply repost all the patches. Here's the new patchset layout: Patch 1-2: cleanup, and potential bugfix of hugetlbfs on fault retry Patch 3-9: let page fault to respond to non-fatal signals faster Patch 10: remove the userfaultfd NOPAGE emulation Patch 11-14: allow page fault to retry more than once Patch 15-16: let gup code to use FAULT_FLAG_KILLABLE too I would really appreciate any review comments for the series, especially for the first two patches which IMHO are even not related to this patchset and they should either cleanup or fix things. Smoke tested on x86 only. Thanks, v5: - split "mm: Return faster for non-fatal signals in user mode faults" into a few more patches, let all archs to use an unified entry for fast signal handling (fatal_signal_pending) v4: - use lore.kernel.org for all the links in commit messages [Kirill] - one more patch ("mm/gup: Fix __get_user_pages() on fault retry of hugetlb") to fix hugetlb path on fault retry - one more patch ("mm/gup: Allow to react to fatal signals") to: - use down_read_killable() properly [Linus] - pass in FAULT_FLAG_KILLABLE for all GUP [Linus] - one more patch ("mm/userfaultfd: Honor FAULT_FLAG_KILLABLE in fault path") to let handle_userfaultfd() respect FAULT_FLAG_KILLABLE. Should have no functional change after previous two new patches. v3: - check fatal signals in __get_user_page_locked() [Linus] - add r-bs v2: - resent previous version, rebase only =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D v1 cover letter =3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D This series is split out of userfaultfd-wp series to only cover the general page fault changes, since it seems to make sense itself. Basically it does two things: (a) Allows the page fault handlers to be more interactive on not only SIGKILL, but also the rest of userspace signals (especially for user-mode faults), and, (b) Allows the page fault retry (VM_FAULT_RETRY) to happen for more than once. I'm keeping the CC list as in uffd-wp v5, hopefully I'm not sending too much spams... And, instead of writting again the cover letter, I'm just copy-pasting my previous link here which has more details on why we do this: https://patchwork.kernel.org/cover/10691991/ The major change from that latest version should be that we introduced a new page fault flag FAULT_FLAG_INTERRUPTIBLE as suggested by Linus [1] to represents that we would like the fault handler to respond to non-fatal signals. Also, we're more careful now on when to do the immediate return of the page fault for such signals. For example, now we'll only check against signal_pending() for user-mode page faults and we keep the kernel-mode page fault patch untouched for it. More information can be found in separate patches. The patchset is only lightly tested on x86. All comments are greatly welcomed. Thanks, [1] https://lkml.org/lkml/2019/6/25/1382 Peter Xu (16): mm/gup: Rename "nonblocking" to "locked" where proper mm/gup: Fix __get_user_pages() on fault retry of hugetlb mm: Introduce fault_signal_pending() x86/mm: Use helper fault_signal_pending() arc/mm: Use helper fault_signal_pending() arm64/mm: Use helper fault_signal_pending() powerpc/mm: Use helper fault_signal_pending() sh/mm: Use helper fault_signal_pending() mm: Return faster for non-fatal signals in user mode faults userfaultfd: Don't retake mmap_sem to emulate NOPAGE mm: Introduce FAULT_FLAG_DEFAULT mm: Introduce FAULT_FLAG_INTERRUPTIBLE mm: Allow VM_FAULT_RETRY for multiple times mm/gup: Allow VM_FAULT_RETRY for multiple times mm/gup: Allow to react to fatal signals mm/userfaultfd: Honor FAULT_FLAG_KILLABLE in fault path arch/alpha/mm/fault.c | 6 +-- arch/arc/mm/fault.c | 35 +++++-------- arch/arm/mm/fault.c | 7 +-- arch/arm64/mm/fault.c | 26 +++------ arch/hexagon/mm/vm_fault.c | 5 +- arch/ia64/mm/fault.c | 5 +- arch/m68k/mm/fault.c | 7 +-- arch/microblaze/mm/fault.c | 5 +- arch/mips/mm/fault.c | 5 +- arch/nds32/mm/fault.c | 5 +- arch/nios2/mm/fault.c | 7 +-- arch/openrisc/mm/fault.c | 5 +- arch/parisc/mm/fault.c | 8 ++- arch/powerpc/mm/fault.c | 20 ++----- arch/riscv/mm/fault.c | 9 +--- arch/s390/mm/fault.c | 10 ++-- arch/sh/mm/fault.c | 13 +++-- arch/sparc/mm/fault_32.c | 5 +- arch/sparc/mm/fault_64.c | 5 +- arch/um/kernel/trap.c | 3 +- arch/unicore32/mm/fault.c | 8 ++- arch/x86/mm/fault.c | 30 +++++------ arch/xtensa/mm/fault.c | 5 +- drivers/gpu/drm/ttm/ttm_bo_vm.c | 12 +++-- fs/userfaultfd.c | 62 ++++++++++------------ include/linux/mm.h | 81 ++++++++++++++++++++++++---- include/linux/sched/signal.h | 14 +++++ mm/filemap.c | 2 +- mm/gup.c | 93 +++++++++++++++++++++------------ mm/hugetlb.c | 17 +++--- mm/internal.h | 6 +-- 31 files changed, 281 insertions(+), 240 deletions(-) --=20 2.24.1