From: SeongJae Park <sjpark@amazon.com>
To: SeongJae Park <sjpark@amazon.com>
Cc: <akpm@linux-foundation.org>, SeongJae Park <sjpark@amazon.de>,
<acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
<amit@kernel.org>, <brendan.d.gregg@gmail.com>,
<brendanhiggins@google.com>, <cai@lca.pw>,
<colin.king@canonical.com>, <corbet@lwn.net>, <dwmw@amazon.com>,
<jolsa@redhat.com>, <kirill@shutemov.name>,
<mark.rutland@arm.com>, <mgorman@suse.de>, <minchan@kernel.org>,
<mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
<rdunlap@infradead.org>, <rostedt@goodmis.org>,
<shuah@kernel.org>, <sj38.park@gmail.com>,
<vdavydov.dev@gmail.com>, <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 02/14] mm/damon: Implement region based sampling
Date: Fri, 21 Feb 2020 14:51:42 +0100 [thread overview]
Message-ID: <20200221135142.8182-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200217102544.29012-3-sjpark@amazon.com> (raw)
On Mon, 17 Feb 2020 11:25:32 +0100 SeongJae Park <sjpark@amazon.com> wrote:
> From: SeongJae Park <sjpark@amazon.de>
>
> This commit implements DAMON's basic access check and region based
> sampling mechanisms. This change would seems make no sense, mainly
> because it is only a part of the DAMON's logics. Following two commits
> will make more sense.
>
[...]
> +/*
> + * Check whether the given region has accessed since the last check
> + *
> + * mm 'mm_struct' for the given virtual address space
> + * r the region to be checked
> + */
> +static void kdamond_check_access(struct damon_ctx *ctx,
> + struct mm_struct *mm, struct damon_region *r)
> +{
> + pte_t *pte = NULL;
> + pmd_t *pmd = NULL;
> + spinlock_t *ptl;
> +
> + if (follow_pte_pmd(mm, r->sampling_addr, NULL, &pte, &pmd, &ptl))
> + goto mkold;
> +
> + /* Read the page table access bit of the page */
> + if (pte && pte_young(*pte))
> + r->nr_accesses++;
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> + else if (pmd && pmd_young(*pmd))
> + r->nr_accesses++;
> +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> +
> + spin_unlock(ptl);
> +
> +mkold:
> + /* mkold next target */
> + r->sampling_addr = damon_rand(ctx, r->vm_start, r->vm_end);
> +
> + if (follow_pte_pmd(mm, r->sampling_addr, NULL, &pte, &pmd, &ptl))
> + return;
> +
> + if (pte) {
> + if (pte_young(*pte)) {
> + clear_page_idle(pte_page(*pte));
> + set_page_young(pte_page(*pte));
> + }
> + *pte = pte_mkold(*pte);
> + }
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> + else if (pmd) {
> + if (pmd_young(*pmd)) {
> + clear_page_idle(pmd_page(*pmd));
> + set_page_young(pte_page(*pte));
Oops, This should be `set_page_young(pmd_page(*pmd))`. Will fix in next spin.
Thanks,
SeongJae Park
next prev parent reply other threads:[~2020-02-21 13:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 10:25 [PATCH v5 00/14] Introduce Data Access MONitor (DAMON) SeongJae Park
2020-02-17 10:25 ` [PATCH v5 01/14] mm: " SeongJae Park
2020-02-17 10:25 ` [PATCH v5 02/14] mm/damon: Implement region based sampling SeongJae Park
2020-02-21 13:51 ` SeongJae Park [this message]
2020-02-17 10:25 ` [PATCH v5 03/14] mm/damon: Adaptively adjust regions SeongJae Park
2020-02-17 10:25 ` [PATCH v5 04/14] mm/damon: Apply dynamic memory mapping changes SeongJae Park
2020-02-17 10:25 ` [PATCH v5 05/14] mm/damon: Implement callbacks SeongJae Park
2020-02-17 10:25 ` [PATCH v5 06/14] mm/damon: Implement access pattern recording SeongJae Park
2020-02-17 10:25 ` [PATCH v5 07/14] mm/damon: Implement kernel space API SeongJae Park
2020-02-17 10:25 ` [PATCH v5 08/14] mm/damon: Add debugfs interface SeongJae Park
2020-02-17 10:25 ` [PATCH v5 09/14] mm/damon: Add a tracepoint for result writing SeongJae Park
2020-02-17 10:28 ` [PATCH v5 10/14] tools: Add a minimal user-space tool for DAMON SeongJae Park
2020-02-17 10:29 ` [PATCH v5 11/14] Documentation/admin-guide/mm: Add a document " SeongJae Park
2020-02-17 10:30 ` [PATCH v5 12/14] mm/damon: Add kunit tests SeongJae Park
2020-02-17 10:30 ` [PATCH v5 13/14] mm/damon: Add user selftests SeongJae Park
2020-02-17 10:31 ` [PATCH v5 14/14] MAINTAINERS: Update for DAMON SeongJae Park
2020-02-20 8:17 ` [PATCH v5 00/14] Introduce Data Access MONitor (DAMON) SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221135142.8182-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=brendanhiggins@google.com \
--cc=cai@lca.pw \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=dwmw@amazon.com \
--cc=jolsa@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).