From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50952C3F2CD for ; Tue, 3 Mar 2020 04:32:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03A2120717 for ; Tue, 3 Mar 2020 04:32:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cLv/cJBv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03A2120717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 999836B0005; Mon, 2 Mar 2020 23:32:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 922BD6B0007; Mon, 2 Mar 2020 23:32:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 839596B0008; Mon, 2 Mar 2020 23:32:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 67E7B6B0005 for ; Mon, 2 Mar 2020 23:32:45 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4FE10181AC9CC for ; Tue, 3 Mar 2020 04:32:45 +0000 (UTC) X-FDA: 76552780290.06.meat70_8c7088ad28f26 X-HE-Tag: meat70_8c7088ad28f26 X-Filterd-Recvd-Size: 2486 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Mar 2020 04:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=KeJDyl+aFgN+H04n3I81zlG+0DNdFvUScnKafy5Eh78=; b=cLv/cJBvZy8bMGbs9xVdXZ/Qlo UjGmg99Y2VGW86iJ/2cyXqtYdb3TPX7QPAMXBKlmZi6rUv7wSSugh52wHSlK+4Rmsji8WyvTue87V 27So66iexb3iaC/Kkz68/uYmQbsXqbJBiD9JWdI5sx8THEGkKWBUHrkFTDva0LDCRStlywt6lY9Kb QPbCqT6vxmZ3JHJL347r71/OE2J2Fg6iNpvtyj4Z69RgD8c8QKBKFEsPgc4Xoz/s+RILfIfOAbZWZ FXEzy6wiVEuHCZR87l3PcfyI3FRpByyMPkrKEdb9McNJHAh87OUbSkzmKUGntTW2jOyseuHvBu2t8 JOvy0S1g==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8ytz-00053U-JZ; Tue, 03 Mar 2020 04:11:27 +0000 From: Matthew Wilcox To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Christoph Hellwig , "Kirill A . Shutemov" Subject: [PATCH 4/6] mm: Use VM_BUG_ON_PAGE in clear_page_dirty_for_io Date: Mon, 2 Mar 2020 20:11:23 -0800 Message-Id: <20200303041125.19358-5-willy@infradead.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200303041125.19358-1-willy@infradead.org> References: <20200303041125.19358-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" Dumping the page information in this circumstance helps for debugging. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig Acked-by: Kirill A. Shutemov --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 2caf780a42e7..9173c25cf8e6 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2655,7 +2655,7 @@ int clear_page_dirty_for_io(struct page *page) struct address_space *mapping =3D page_mapping(page); int ret =3D 0; =20 - BUG_ON(!PageLocked(page)); + VM_BUG_ON_PAGE(!PageLocked(page), page); =20 if (mapping && mapping_cap_account_dirty(mapping)) { struct inode *inode =3D mapping->host; --=20 2.25.1