From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E800C18E5A for ; Mon, 9 Mar 2020 13:41:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04A4620866 for ; Mon, 9 Mar 2020 13:41:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KnSDw4bi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04A4620866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A47796B0003; Mon, 9 Mar 2020 09:41:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D10F6B0006; Mon, 9 Mar 2020 09:41:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BF826B0007; Mon, 9 Mar 2020 09:41:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 6F62A6B0003 for ; Mon, 9 Mar 2020 09:41:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0A364181AC9CC for ; Mon, 9 Mar 2020 13:41:17 +0000 (UTC) X-FDA: 76575935394.21.act82_28458acd7830d X-HE-Tag: act82_28458acd7830d X-Filterd-Recvd-Size: 3151 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Mar 2020 13:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583761276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4uy9CPfIqXcf46TOPmKwmRnzrgWZ4Kr2u3iJ+yoWqIA=; b=KnSDw4biTEE/1RlSacBJL9a7Ra51Auq0B+9ImfJtnybCVq/mSFG0trltky47sbDsxX8tUw OrWzxA5Q6FocGwunrETxyRGJVtPhd851CfkJc7Fw98UVGr1tZmyTOi/2iihGxFySHk9BuU 4WZYA6mkaoT7Zwhd1tKh6hc9ybtATIo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-92_W189bMEeVf_UIchAFGg-1; Mon, 09 Mar 2020 09:41:12 -0400 X-MC-Unique: 92_W189bMEeVf_UIchAFGg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D65F1107ACCC; Mon, 9 Mar 2020 13:41:10 +0000 (UTC) Received: from localhost (ovpn-12-179.pek2.redhat.com [10.72.12.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 320C55D9C5; Mon, 9 Mar 2020 13:41:07 +0000 (UTC) Date: Mon, 9 Mar 2020 21:41:04 +0800 From: Baoquan He To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com, dan.j.williams@intel.com, osalvador@suse.de, rppt@linux.ibm.com Subject: Re: [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together Message-ID: <20200309134104.GE27711@MiWiFi-R3L-srv> References: <20200307084229.28251-1-bhe@redhat.com> <20200307084229.28251-7-bhe@redhat.com> <8462ca2b-822f-52c0-5986-93377d252fac@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8462ca2b-822f-52c0-5986-93377d252fac@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/09/20 at 10:08am, David Hildenbrand wrote: > On 07.03.20 09:42, Baoquan He wrote: > > No functional change. > > > > Signed-off-by: Baoquan He > > --- > > mm/sparse.c | 134 +++++++++++++++++++++++++--------------------------- > > 1 file changed, 65 insertions(+), 69 deletions(-) > > IMHO, we don't need this patch - but just my personal opinion. Change > itself looks good on a quick glance. I personally like seeing function set operating on one data structure being put together. To me, I use vi+ctags+cscope to jump to called funtion easily. When try to get a picture of a data and handling, e.g here the subsection map and the relevant functions, putting them together is better to understand code. I am also fine to discard this patch, no patch has dependency on this one in this series, it's easy to not pick it if no one like it.