From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swap_slots.c: don't reset the cache slot after use
Date: Wed, 11 Mar 2020 09:17:15 +0800 [thread overview]
Message-ID: <20200311011715.GA47198@L-31X9LVDL-1304.local> (raw)
In-Reply-To: <d851c5c9-7fc0-0959-e5c9-1a62f0341cb7@linux.intel.com>
On Tue, Mar 10, 2020 at 04:03:07PM -0700, Tim Chen wrote:
>On 3/10/20 3:20 PM, Wei Yang wrote:
>> On Tue, Mar 10, 2020 at 11:13:13AM -0700, Tim Chen wrote:
>>> On 3/9/20 5:48 PM, Andrew Morton wrote:
>>>> On Mon, 9 Mar 2020 17:09:40 +0800 Wei Yang <richard.weiyang@linux.alibaba.com> wrote:
>>>>
>>>>> Currently we would clear the cache slot if it is used. While this is not
>>>>> necessary, since this entry would not be used until refilled.
>>>>>
>>>>> Leave it untouched and assigned the value directly to entry which makes
>>>>> the code little more neat.
>>>>>
>>>>> Also this patch merges the else and if, since this is the only case we
>>>>> refill and repeat swap cache.
>>>>
>>>> cc Tim, who can hopefully remember how this code works ;)
>>>>
>>>>> --- a/mm/swap_slots.c
>>>>> +++ b/mm/swap_slots.c
>>>>> @@ -309,7 +309,7 @@ int free_swap_slot(swp_entry_t entry)
>>>>>
>>>>> swp_entry_t get_swap_page(struct page *page)
>>>>> {
>>>>> - swp_entry_t entry, *pentry;
>>>>> + swp_entry_t entry;
>>>>> struct swap_slots_cache *cache;
>>>>>
>>>>> entry.val = 0;
>>>>> @@ -336,13 +336,10 @@ swp_entry_t get_swap_page(struct page *page)
>>>>> if (cache->slots) {
>>>>> repeat:
>>>>> if (cache->nr) {
>>>>> - pentry = &cache->slots[cache->cur++];
>>>>> - entry = *pentry;
>>>>> - pentry->val = 0;
>>>
>>> The cache entry was cleared after assignment for defensive programming, So there's
>>> little chance I will be using a slot that has been assigned to someone else.
>>> When I wrote swap_slots.c, this code was new and I want to make sure
>>> that if something went wrong, and I assigned a swap slot that I shouldn't,
>>> I will be able to detect quickly as I will only be stepping on entry 0.
>>>
>>> Otherwise such bug will be harder to detect as we will have two users of some random
>>> swap slot stepping on each other.
>>>
>>> I'm okay if we want to get rid of this logic, now that the code has been
>>> working correctly long enough. But I think is good hygiene to clear the
>>> cached entry after it has been assigned.
>>>
>>
>> This is fine to keep the logic, while I am wondering whether we need to do
>> this through pointer. cache->slots[] contain the value, we can get and reset
>> without pointer.
>>
>> The following code looks more obvious about the logic.
>>
>> entry = cache->slots[cache->cur];
>> cache->slots[cache->cur++].val = 0;
>
>Yes, this looks pretty good.
Thanks, I would rephrase v2.
>
>Thanks.
>
>Tim
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2020-03-11 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 9:09 [PATCH] mm/swap_slots.c: don't reset the cache slot after use Wei Yang
2020-03-10 0:48 ` Andrew Morton
2020-03-10 18:13 ` Tim Chen
2020-03-10 22:20 ` Wei Yang
2020-03-10 23:03 ` Tim Chen
2020-03-11 1:17 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311011715.GA47198@L-31X9LVDL-1304.local \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).