From: Wei Yang <richard.weiyang@gmail.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/page_alloc.c: leverage compiler to zero out used_mask
Date: Fri, 27 Mar 2020 13:27:22 +0000 [thread overview]
Message-ID: <20200327132722.rovaz5hghl5vhhl7@master> (raw)
In-Reply-To: <20200326223604.GP20941@ziepe.ca>
On Thu, Mar 26, 2020 at 07:36:04PM -0300, Jason Gunthorpe wrote:
>On Thu, Mar 26, 2020 at 10:24:44PM +0000, Wei Yang wrote:
>> Since we always clear used_mask before getting node order, we can
>> leverage compiler to do this instead of at run time.
>>
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> mm/page_alloc.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 0e823bca3f2f..2144b6ceb119 100644
>> +++ b/mm/page_alloc.c
>> @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat)
>> {
>> static int node_order[MAX_NUMNODES];
>> int node, load, nr_nodes = 0;
>> - nodemask_t used_mask;
>> + nodemask_t used_mask = {.bits = {0}};
>
>If this style is to be done it should just be '= {}';
>
>This case demonstrates why the popular '= {0}' idiom is not such a
>good idea, as it only works if the first member is an integral type.
>
Thanks for your comment. I think David found a better solution.
>Jason
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-03-27 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 22:24 [PATCH 1/2] mm/page_alloc.c: leverage compiler to zero out used_mask Wei Yang
2020-03-26 22:24 ` [PATCH 2/2] mm/page_alloc.c: define node_order with all zero Wei Yang
2020-03-26 22:36 ` [PATCH 1/2] mm/page_alloc.c: leverage compiler to zero out used_mask Jason Gunthorpe
2020-03-27 13:27 ` Wei Yang [this message]
2020-03-27 9:32 ` David Hildenbrand
2020-03-27 13:21 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327132722.rovaz5hghl5vhhl7@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).