From: Jason Gunthorpe <jgg@mellanox.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [GIT PULL] Please pull HMM changes
Date: Mon, 30 Mar 2020 17:08:23 -0300 [thread overview]
Message-ID: <20200330200823.GH8514@mellanox.com> (raw)
In-Reply-To: <20200330195403.GA35797@ubuntu-m2-xlarge-x86>
On Mon, Mar 30, 2020 at 12:54:03PM -0700, Nathan Chancellor wrote:
> > Jason Gunthorpe (17):
> > mm/hmm: add missing unmaps of the ptep during hmm_vma_handle_pte()
> > mm/hmm: do not call hmm_vma_walk_hole() while holding a spinlock
> > mm/hmm: add missing pfns set to hmm_vma_walk_pmd()
> > mm/hmm: add missing call to hmm_range_need_fault() before returning EFAULT
> > mm/hmm: reorganize how !pte_present is handled in hmm_vma_handle_pte()
> > mm/hmm: return -EFAULT when setting HMM_PFN_ERROR on requested valid pages
> > mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling
> > mm/hmm: do not check pmd_protnone twice in hmm_vma_handle_pmd()
> > mm/hmm: remove pgmap checking for devmap pages
> > mm/hmm: return the fault type from hmm_pte_need_fault()
> > mm/hmm: remove unused code and tidy comments
> > mm/hmm: remove HMM_FAULT_SNAPSHOT
> > mm/hmm: remove the CONFIG_TRANSPARENT_HUGEPAGE #ifdef
>
> This patch causes an error on arm32 all{mod,yes}config because pmd_pfn
> is only defined when CONFIG_ARM_LPAE is set, which is a dependency of
> CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE and CONFIG_TRANSPARENT_HUGEPAGE.
Oh! I'm again surprised 0-day did not catch on to this. linux-next
surely would have, but things got there later than I would have
preferred due to the world being upside down right now :(
> https://elixir.bootlin.com/linux/v5.6/source/arch/arm/include/asm/pgtable-3level.h#L236
> https://elixir.bootlin.com/linux/v5.6/source/arch/arm/include/asm/pgtable.h#L29
> https://elixir.bootlin.com/linux/v5.6/source/arch/arm/Kconfig#L1579
>
> No idea how to rectify that but thought I would let you know.
I'll just drop the patch. Next cycle we can add some comment here as
this requirement is a hard to notice.
The for-linus-hmm tag is updated now to reflect this.
Thanks a lot,
Jason
next prev parent reply other threads:[~2020-03-30 20:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 17:57 [GIT PULL] Please pull HMM changes Jason Gunthorpe
2020-03-30 19:54 ` Nathan Chancellor
2020-03-30 20:08 ` Jason Gunthorpe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-04 15:06 [GIT PULL] Please pull hmm changes Jason Gunthorpe
2020-08-05 20:33 ` pr-tracker-bot
2020-06-01 18:25 Jason Gunthorpe
2020-06-02 22:20 ` pr-tracker-bot
2019-11-25 20:42 Jason Gunthorpe
2019-11-30 18:03 ` Linus Torvalds
2019-11-30 18:23 ` Linus Torvalds
2019-12-03 2:42 ` Jason Gunthorpe
2019-12-05 16:03 ` Jerome Glisse
2019-12-11 22:57 ` Jason Gunthorpe
2019-12-13 10:19 ` Daniel Vetter
2019-12-18 14:59 ` Jason Gunthorpe
2019-12-18 16:53 ` Linus Torvalds
2019-12-18 18:37 ` Jason Gunthorpe
2019-12-18 19:33 ` Linus Torvalds
2019-12-05 23:03 ` John Hubbard
2019-12-11 22:47 ` Jason Gunthorpe
2019-11-30 18:35 ` Linus Torvalds
2019-07-30 11:58 Jason Gunthorpe
2019-07-30 20:40 ` pr-tracker-bot
2019-07-09 19:24 Jason Gunthorpe
2019-07-15 2:48 ` Linus Torvalds
2019-07-15 3:00 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330200823.GH8514@mellanox.com \
--to=jgg@mellanox.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=natechancellor@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).