From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B02C43331 for ; Thu, 2 Apr 2020 04:11:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C0906206E9 for ; Thu, 2 Apr 2020 04:11:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YEPXIFL9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0906206E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FCB68E0098; Thu, 2 Apr 2020 00:11:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AF458E000D; Thu, 2 Apr 2020 00:11:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59E0B8E0098; Thu, 2 Apr 2020 00:11:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 34E2C8E000D for ; Thu, 2 Apr 2020 00:11:50 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 06CEC181AC9CC for ; Thu, 2 Apr 2020 04:11:50 +0000 (UTC) X-FDA: 76661591580.17.jeans14_6749865c41722 X-HE-Tag: jeans14_6749865c41722 X-Filterd-Recvd-Size: 2800 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 04:11:49 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB469208E4; Thu, 2 Apr 2020 04:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585800709; bh=+OaHsGtQg0azFWgehIVCx5eZZfyHBJI+cTdlN7SmvRE=; h=Date:From:To:Subject:In-Reply-To:From; b=YEPXIFL9YzkxeVBcDGd/o0qUpqz3k3NN/mQup5M88KosEqClCoiNCNv1UFm5OsKqE F8l0OXftpXZ7zO5BU4I+6j9CNCMVfTeCsO15tk4A2NYdVioja8rjSZLxx9M1ahVEQ/ OaT9+Z3lj7TJHUEtRaJ+tuxszWVTpnncy9bTKZJo= Date: Wed, 01 Apr 2020 21:11:48 -0700 From: Andrew Morton To: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, mike.kravetz@oracle.com, mm-commits@vger.kernel.org, nehaagarwal@google.com, rientjes@google.com, torvalds@linux-foundation.org, vbabka@suse.cz Subject: [patch 152/155] mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge() Message-ID: <20200402041148.jDH6duv6H%akpm@linux-foundation.org> In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Vlastimil Babka Subject: mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge() Commit f1e61557f023 ("mm: pack compound_dtor and compound_order into one word in struct page") changed compound_dtor from a pointer to an array index in order to pack it. To check if page has the hugeltbfs compound_dtor, we can just compare the index directly without fetching the function pointer. Said commit did that with PageHuge() and we can do the same with PageHeadHuge() to make the code a bit smaller and faster. Link: http://lkml.kernel.org/r/20200311172440.6988-1-vbabka@suse.cz Signed-off-by: Vlastimil Babka Reviewed-by: Mike Kravetz Acked-by: David Rientjes Acked-by: Kirill A. Shutemov Cc: Neha Agarwal Signed-off-by: Andrew Morton --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/hugetlb.c~mm-hugetlb-remove-unnecessary-memory-fetch-in-pageheadhuge +++ a/mm/hugetlb.c @@ -1528,7 +1528,7 @@ int PageHeadHuge(struct page *page_head) if (!PageHead(page_head)) return 0; - return get_compound_page_dtor(page_head) == free_huge_page; + return page_head[1].compound_dtor == HUGETLB_PAGE_DTOR; } /* _