From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F092C2BB86 for ; Tue, 14 Apr 2020 11:32:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E1E12072D for ; Tue, 14 Apr 2020 11:32:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E1E12072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 08E668E000A; Tue, 14 Apr 2020 07:32:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0125C8E0005; Tue, 14 Apr 2020 07:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D58B68E0008; Tue, 14 Apr 2020 07:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id B8B958E0001 for ; Tue, 14 Apr 2020 07:32:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 862261269 for ; Tue, 14 Apr 2020 11:32:30 +0000 (UTC) X-FDA: 76706247660.26.crate18_8a458e03c6e1e X-HE-Tag: crate18_8a458e03c6e1e X-Filterd-Recvd-Size: 4001 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 11:32:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 80E37AEC3; Tue, 14 Apr 2020 11:32:27 +0000 (UTC) From: Vlastimil Babka To: Andrew Morton , Luis Chamberlain , Kees Cook , Iurii Zaikin Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner , Masami Hiramatsu , Vlastimil Babka Subject: [PATCH v2 3/3] kernel/hung_task convert hung_task_panic boot parameter to sysctl Date: Tue, 14 Apr 2020 13:32:22 +0200 Message-Id: <20200414113222.16959-4-vbabka@suse.cz> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200414113222.16959-1-vbabka@suse.cz> References: <20200414113222.16959-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can now handle sysctl parameters on kernel command line and have infrastructure to convert legacy command line options that duplicate sysc= tl to become a sysctl alias. This patch converts the hung_task_panic parameter. Note that the sysctl h= andler is more strict and allows only 0 and 1, while the legacy parameter allowe= d any non-zero value. But there is little reason anyone would not be using = 1. Signed-off-by: Vlastimil Babka Reviewed-by: Kees Cook --- Documentation/admin-guide/kernel-parameters.txt | 2 +- fs/proc/proc_sysctl.c | 1 + kernel/hung_task.c | 10 ---------- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat= ion/admin-guide/kernel-parameters.txt index fd38f1e8a2bf..e60478d9d377 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -1491,7 +1491,7 @@ [KNL] Should the hung task detector generate panics. Format: =20 - A nonzero value instructs the kernel to panic when a + A value of 1 instructs the kernel to panic when a hung task is detected. The default value is controlled by the CONFIG_BOOTPARAM_HUNG_TASK_PANIC build-time option. The value selected by this boot parameter can diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 209ad03e1b82..e8f97bd65909 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -1710,6 +1710,7 @@ struct sysctl_alias { */ static const struct sysctl_alias sysctl_aliases[] =3D { {"numa_zonelist_order", "vm.numa_zonelist_order" }, + {"hung_task_panic", "kernel.hung_task_panic" }, { } }; =20 diff --git a/kernel/hung_task.c b/kernel/hung_task.c index 14a625c16cb3..b22b5eeab3cb 100644 --- a/kernel/hung_task.c +++ b/kernel/hung_task.c @@ -63,16 +63,6 @@ static struct task_struct *watchdog_task; unsigned int __read_mostly sysctl_hung_task_panic =3D CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE; =20 -static int __init hung_task_panic_setup(char *str) -{ - int rc =3D kstrtouint(str, 0, &sysctl_hung_task_panic); - - if (rc) - return rc; - return 1; -} -__setup("hung_task_panic=3D", hung_task_panic_setup); - static int hung_task_panic(struct notifier_block *this, unsigned long event, void *= ptr) { --=20 2.26.0