From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D6AC2BB1D for ; Wed, 15 Apr 2020 01:24:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 458332084D for ; Wed, 15 Apr 2020 01:24:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JZfORDVr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 458332084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D82778E0005; Tue, 14 Apr 2020 21:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D330C8E0001; Tue, 14 Apr 2020 21:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C491B8E0005; Tue, 14 Apr 2020 21:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id AAB2D8E0001 for ; Tue, 14 Apr 2020 21:24:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 728682C04 for ; Wed, 15 Apr 2020 01:24:32 +0000 (UTC) X-FDA: 76708344384.05.fly25_7ee37c160491e X-HE-Tag: fly25_7ee37c160491e X-Filterd-Recvd-Size: 5270 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 01:24:31 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC0E320784; Wed, 15 Apr 2020 01:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586913871; bh=Jttip+q2gFr6gM6I9moyxzeHwN0fQYq8HT40g3rs6lY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JZfORDVrzKDLJirpGb9+s3ZEwYKVe+1aQi9jJl2B4EpQVaHqvSofy1OkreFy5zrFl RCxeBGgCWqZFUHLEM0eGRWY/W9G0TMmU5gAJWZ6tiYxOQUeBw7pp/0bYOUsSQpOxzD G3UkU16EORnqkD1GE3SmIGEbCJt+D/foJ5zsK4hw= Date: Tue, 14 Apr 2020 18:24:30 -0700 From: Andrew Morton To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Linux MM , Hugh Dickins Subject: Re: linux-next: Tree for Apr 14 (mm/shmem.c) Message-Id: <20200414182430.c5af29ddb1735f5fd0083983@linux-foundation.org> In-Reply-To: <200c608a-8159-18ce-b44e-cad2022e23e2@infradead.org> References: <20200414123900.4f97a83f@canb.auug.org.au> <200c608a-8159-18ce-b44e-cad2022e23e2@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Apr 2020 07:18:01 -0700 Randy Dunlap w= rote: > On 4/13/20 7:39 PM, Stephen Rothwell wrote: > > Hi all, > >=20 > > Changes since 20200413: > >=20 > > New tree: mhi > >=20 > > My fixes tree contains: > >=20 > > 6b038bdcd3d1 sh: mm: Fix build error > >=20 > > Non-merge commits (relative to Linus' tree): 1154 > > 1160 files changed, 31764 insertions(+), 13498 deletions(-) > >=20 > > ---------------------------------------------------------------------= ------- >=20 > on x86_64: > # CONFIG_TRANSPARENT_HUGEPAGE is not set Thanks. hm, this took a long time to be discovered. > In file included from ../include/linux/export.h:43:0, > from ../include/linux/linkage.h:7, > from ../include/linux/fs.h:5, > from ../mm/shmem.c:24: > ../mm/shmem.c: In function =E2=80=98shmem_undo_range=E2=80=99: > ../include/linux/compiler.h:394:38: error: call to =E2=80=98__compileti= me_assert_110=E2=80=99 declared with attribute error: BUILD_BUG failed > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER_= _) > ^ > ../include/linux/compiler.h:69:3: note: in definition of macro =E2=80=98= __trace_if_value=E2=80=99 > (cond) ? \ > ^~~~ > ../include/linux/compiler.h:56:28: note: in expansion of macro =E2=80=98= __trace_if_var=E2=80=99 > #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) )= ) > ^~~~~~~~~~~~~~ > ../mm/shmem.c:960:6: note: in expansion of macro =E2=80=98if=E2=80=99 > if (index < > ^~ > ../include/linux/kernel.h:71:36: note: in expansion of macro =E2=80=98_= _round_mask=E2=80=99 > #define round_up(x, y) ((((x)-1) | __round_mask(x, y))+1) > ^~~~~~~~~~~~ > ../mm/shmem.c:961:10: note: in expansion of macro =E2=80=98round_up=E2=80= =99 > round_up(start, HPAGE_PMD_NR)) > ^~~~~~~~ > ../include/linux/compiler.h:382:2: note: in expansion of macro =E2=80=98= __compiletime_assert=E2=80=99 > __compiletime_assert(condition, msg, prefix, suffix) > ^~~~~~~~~~~~~~~~~~~~ > ../include/linux/compiler.h:394:2: note: in expansion of macro =E2=80=98= _compiletime_assert=E2=80=99 > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER_= _) > ^~~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:39:37: note: in expansion of macro =E2=80=98= compiletime_assert=E2=80=99 > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ../include/linux/build_bug.h:59:21: note: in expansion of macro =E2=80=98= BUILD_BUG_ON_MSG=E2=80=99 > #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") > ^~~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:319:28: note: in expansion of macro =E2=80=98= BUILD_BUG=E2=80=99 > #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) > ^~~~~~~~~ > ../include/linux/huge_mm.h:115:26: note: in expansion of macro =E2=80=98= HPAGE_PMD_SHIFT=E2=80=99 > #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) > ^~~~~~~~~~~~~~~ > ../include/linux/huge_mm.h:116:26: note: in expansion of macro =E2=80=98= HPAGE_PMD_ORDER=E2=80=99 > #define HPAGE_PMD_NR (1< ^~~~~~~~~~~~~~~ > ../mm/shmem.c:961:26: note: in expansion of macro =E2=80=98HPAGE_PMD_NR= =E2=80=99 > round_up(start, HPAGE_PMD_NR)) > ^~~~~~~~~~~~ >=20 That's if (index < round_up(start, HPAGE_PMD_NR)) start =3D index + 1; from Hugh's 71725ed10c40696 ("mm: huge tmpfs: try to split_huge_page() when punching hole").