From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F33C2BB1D for ; Tue, 14 Apr 2020 22:55:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 02E8D2074D for ; Tue, 14 Apr 2020 22:55:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="qUOTrLKP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02E8D2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8EC148E0005; Tue, 14 Apr 2020 18:55:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89D628E0001; Tue, 14 Apr 2020 18:55:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78B1D8E0005; Tue, 14 Apr 2020 18:55:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 5F4E48E0001 for ; Tue, 14 Apr 2020 18:55:28 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2949140D3 for ; Tue, 14 Apr 2020 22:55:28 +0000 (UTC) X-FDA: 76707968736.04.kite17_8702bf6e2d300 X-HE-Tag: kite17_8702bf6e2d300 X-Filterd-Recvd-Size: 3851 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 22:55:27 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id h26so5144071wrb.7 for ; Tue, 14 Apr 2020 15:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c8qoDjMoKh8m7k69YSal4t9Yzh8UqpaGOqxo2kh4+H4=; b=qUOTrLKP5lkD+hzSEZLpsh2KQaBFsVU/EEodUWabGWRaIAOxSAA6Fky7NKOSZ1UPR3 KWeEOVeGQt5g+r3W8cYBFDYtCbD3yqd4wkOln8yW3EbPswE3I0zAIvmvIAuKKrHLRf8j YNCY0b2m8MjDExYGkz21fWnOsPZs4GHRqaZdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c8qoDjMoKh8m7k69YSal4t9Yzh8UqpaGOqxo2kh4+H4=; b=YaqejAiKJJO0WLw9Lyf8cFU+B2iYCjzS6l52J+L5pu0LgdzN2FWrO5BPTir9JGTEzV f5Q4yIkm6mSnphtGErjRSzp4nJAvk3z/EoNI2HhyX0oDrz3mejKxSjBPUdMRlV5dnlg5 A2fV7w7C9Zl4IdinxITC2fsLibn5iAqMXoVv3GCYIRaDDgOUYMVmpsbGpKGbYtBwvE0p TRAzOdCInTI1AJf2TWA6+xBy1cUhQTgbXY3eMF4Wfz9FWYXdBzKJpd7FBUhjh8cCfzN/ Sx0jNfr3i8rvgYqxeQ4LqseERvZw8UeN0MtN3ZNNUSf1YFeMTd3V9gO1w/q6Y/1MLK91 WsXg== X-Gm-Message-State: AGi0PuZ04ivLafDqNlPC7Ik+wTs3flgDG114Vi4BbdyCHfcJm/GdOpR/ cqx52e4EbwzH/jqX3YZ6dHYTRA== X-Google-Smtp-Source: APiQypJ6O4aookb/rRY4LDzvhk4cVYhjiK8tQJBOUQvu8zJJrPOFWvoVk8qrVg2FQLDrNSc+7Hmokg== X-Received: by 2002:adf:ef01:: with SMTP id e1mr966160wro.182.1586904926418; Tue, 14 Apr 2020 15:55:26 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:fa59:71ff:fe7e:8d21]) by smtp.gmail.com with ESMTPSA id w83sm21173847wmb.37.2020.04.14.15.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 15:55:25 -0700 (PDT) Date: Tue, 14 Apr 2020 23:55:25 +0100 From: Chris Down To: svc_lmoiseichuk@magicleap.com Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, tj@kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, akpm@linux-foundation.org, rientjes@google.com, minchan@kernel.org, vinmenon@codeaurora.org, andriy.shevchenko@linux.intel.com, anton.vorontsov@linaro.org, penberg@kernel.org, linux-mm@kvack.org, Leonid Moiseichuk Subject: Re: [PATCH 1/2] memcg: expose vmpressure knobs Message-ID: <20200414225525.GA1892067@chrisdown.name> References: <20200413215750.7239-1-lmoiseichuk@magicleap.com> <20200413215750.7239-2-lmoiseichuk@magicleap.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200413215750.7239-2-lmoiseichuk@magicleap.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: svc_lmoiseichuk@magicleap.com writes: >From: Leonid Moiseichuk > >Populating memcg vmpressure controls with legacy defaults: >- memory.pressure_window (512 or SWAP_CLUSTER_MAX * 16) >- memory.pressure_level_critical_prio (3) >- memory.pressure_level_medium (60) >- memory.pressure_level_critical (95) > >Signed-off-by: Leonid Moiseichuk I'm against this even in the abstract, cgroup v1 is deprecated and its interface frozen, and vmpressure is pretty much already supplanted by PSI, which actually works (whereas vmpressure often doesn't since it mostly ends up just measuring reclaim efficiency, rather than actual memory pressure). Without an extremely compelling reason to expose these, this just muddles the situation.