From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5513CC2BA19 for ; Wed, 15 Apr 2020 10:01:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EDCA920768 for ; Wed, 15 Apr 2020 10:01:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDCA920768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D3448E0003; Wed, 15 Apr 2020 06:01:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 483D48E0001; Wed, 15 Apr 2020 06:01:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C05A8E0003; Wed, 15 Apr 2020 06:01:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 219F38E0001 for ; Wed, 15 Apr 2020 06:01:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CE2278E63 for ; Wed, 15 Apr 2020 10:01:50 +0000 (UTC) X-FDA: 76709647980.27.quill25_847e1ee6fc83b X-HE-Tag: quill25_847e1ee6fc83b X-Filterd-Recvd-Size: 4258 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 10:01:50 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id o81so11101961wmo.2 for ; Wed, 15 Apr 2020 03:01:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ik9SzoJG23HyWV3EJZBDw9KnoLZv3eWb0eYaCp2cs4I=; b=fkhhSfBK5sFJ9bGO0CFdLaPa60Yzva0jpj3hhHPU2FKFJ0Ok1txcWGcB1NHQEiqUFK Zrl7CYNapSdHVzQ2b0NDLBQK+q9xik4/ypO7DPvGu8H+jiM3RibUu7Drao49QuOcoyEn b7oHf2k0AuKnFYrLjNE/cRF4+1pjM45Xy4mMmbsoc4lz4Q4F6fqEZO+ak6R6DVjycJwh Xv4/pNIns9Nn9Qvp+yzQwd32SluwCWqGZS1kliGL8hAhD/AONN6fbfLMdStwzxOCea+P idrn2+gWJ2IsJMKH4FIcf1XyL3UfekQ34UG5X3VW1fJOWEsGuk+Yc1dQGWGzavFEFaGX 67tQ== X-Gm-Message-State: AGi0Pua1HxBa5xPrNr4+gp1m8gWo1Pui9vxOV/ojI54CHEBKvQv7UMyR WgjLlmcaIl+JG8ii9Rf1XZI= X-Google-Smtp-Source: APiQypKJVaGGm0WlX/P9D+5uZGAAwOwvoL0TgNtVED/ZyGRV1UePRP4N+INs4Ka7TCh9PUHB/SON9w== X-Received: by 2002:a1c:3d83:: with SMTP id k125mr4767806wma.177.1586944909281; Wed, 15 Apr 2020 03:01:49 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id 1sm21770489wmi.0.2020.04.15.03.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 03:01:48 -0700 (PDT) Date: Wed, 15 Apr 2020 12:01:46 +0200 From: Michal Hocko To: Vlastimil Babka Cc: Masami Hiramatsu , Andrew Morton , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH v2 0/3] support setting sysctl parameters from kernel command line Message-ID: <20200415100146.GC4629@dhcp22.suse.cz> References: <20200414113222.16959-1-vbabka@suse.cz> <20200415122359.939364e2c54c389c6b3f6457@kernel.org> <3fc1303a-cb57-b96e-ce77-7ff6407ab538@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3fc1303a-cb57-b96e-ce77-7ff6407ab538@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 15-04-20 10:56:35, Vlastimil Babka wrote: > On 4/15/20 5:23 AM, Masami Hiramatsu wrote: > > Hi Vlastimil, > > > > On Tue, 14 Apr 2020 13:32:19 +0200 > > Vlastimil Babka wrote: > > > >> This series adds support for something that seems like many people always > >> wanted but nobody added it yet, so here's the ability to set sysctl parameters > >> via kernel command line options in the form of sysctl.vm.something=1 > > > > Sounds good. And would you consider to use the bootconfig instead of (or > > in addition to) the kernel command line, because it is too short to describe > > the sysctl options? > > "Instead of" - no, as that would defeat the scenario of "I just want to set this > one sysctl in grub (possibly interactively) and not update initrd for that". If > constructing bootconfig is of similar effort of loading sysctl.conf from initrd, > then I see little benefit? > > "in addition to" - sure! but I hoped that's what already happens as it seemed to > me that options from bootconfig are appended to the command line that's then > parsed by everyone else, no? But I'll try it to be sure. Completely agreed! Btw. patches look sensible to me so feel free to add Acked-by: Michal Hocko -- Michal Hocko SUSE Labs