From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62599C2BB1D for ; Wed, 15 Apr 2020 03:24:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2469A20784 for ; Wed, 15 Apr 2020 03:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SfgtJRTc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2469A20784 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E60728E0008; Tue, 14 Apr 2020 23:24:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E18EB8E0001; Tue, 14 Apr 2020 23:24:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFFB28E0008; Tue, 14 Apr 2020 23:24:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id B5A4B8E0001 for ; Tue, 14 Apr 2020 23:24:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 77A7A181AEF15 for ; Wed, 15 Apr 2020 03:24:07 +0000 (UTC) X-FDA: 76708645734.23.end16_6dd1a3823b63 X-HE-Tag: end16_6dd1a3823b63 X-Filterd-Recvd-Size: 3333 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 03:24:07 +0000 (UTC) Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A6FA72076C; Wed, 15 Apr 2020 03:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586921046; bh=wTVTBdIHEqCex23yW6xwI9OoQMcfzXT4+ioyVchFUpQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SfgtJRTcjPqkS72/m2sKOzvm1oR0MQnLje3I7RBxdagvdugW7f21nTRsWItsS62Om 4ua6aAcdc1lphqCNXdIWozTCflGDucinEtWwGZ75IfujdrkhsLsMIVb4xDpJfWp3dM eTGgBBUrs5bYS3IBK1IWiTLhp6ohQbxOCpdf5iG8= Date: Wed, 15 Apr 2020 12:23:59 +0900 From: Masami Hiramatsu To: Vlastimil Babka Cc: Andrew Morton , Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner , Masami Hiramatsu Subject: Re: [PATCH v2 0/3] support setting sysctl parameters from kernel command line Message-Id: <20200415122359.939364e2c54c389c6b3f6457@kernel.org> In-Reply-To: <20200414113222.16959-1-vbabka@suse.cz> References: <20200414113222.16959-1-vbabka@suse.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vlastimil, On Tue, 14 Apr 2020 13:32:19 +0200 Vlastimil Babka wrote: > This series adds support for something that seems like many people always > wanted but nobody added it yet, so here's the ability to set sysctl parameters > via kernel command line options in the form of sysctl.vm.something=1 Sounds good. And would you consider to use the bootconfig instead of (or in addition to) the kernel command line, because it is too short to describe the sysctl options? With the bootconfig, you can describe the sysctl parameters in an independent file as same as /etc/sysctl.conf. It is easy to convert form sysctl.conf to bootconfig because bootconfig format is simply enhanced structured sysctl.conf :). What we just need is; (echo "sysctl {"; cat "/etc/sysctl.conf"; echo "}") >> sysctl.bconf bootconfig -a sysctl.bconf /boot/initrd.img Even with only your patch, since bootconfig can pass the options which start with "kernel." prefix to kernel command line, so; (echo "kernel.sysctl {"; cat "/etc/sysctl.conf"; echo "}") >> sysctl.bconf bootconfig -a sysctl.bconf /boot/initrd.img should work. Thank you, -- Masami Hiramatsu