From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499ADC3A5A0 for ; Thu, 16 Apr 2020 00:56:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 16DD0208E0 for ; Thu, 16 Apr 2020 00:56:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16DD0208E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 939F18E005E; Wed, 15 Apr 2020 20:56:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EAEF8E0001; Wed, 15 Apr 2020 20:56:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B2218E005E; Wed, 15 Apr 2020 20:56:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 639FF8E0001 for ; Wed, 15 Apr 2020 20:56:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1B7575DC9 for ; Thu, 16 Apr 2020 00:56:40 +0000 (UTC) X-FDA: 76711902960.21.berry67_57487604c630c X-HE-Tag: berry67_57487604c630c X-Filterd-Recvd-Size: 4183 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Apr 2020 00:56:39 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id v2so704792plp.9 for ; Wed, 15 Apr 2020 17:56:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eO9sNPLfM7z72dEgAo+/qu9o3q8PbtexT1d+8SrfwsA=; b=E2r+7irpoXp8mpeUNBjiPgQOc1KBCq79FqjG/g+1vt9LB4O4CfL6tcZrs2YMBoYHTO UsXvAkA3bydBddlvC//l1MXkMMI7y47Ze4XMcilgv04XGhlQBSbpXLs2+qbBYTB2/Bpy j6BJOkF6cmfl5fRWd/d1nPdhFeizOhnTsmu5Lg2H0AFsKJmzQgnVF+yxlwIYcPV4ZKVn wm1ZVr3pcmGE6K/STGITeaqUn/A0jRd6v2xt3kAfo6O9jnYqbWFSKKMuFLVqWFKsD+Is XfDFzQC4G8ceuRBHINY17pOgQl7rVz1XPaz5B+kQY2veeM76k9rJLM1H07cyNXJvYCOj XcyA== X-Gm-Message-State: AGi0PuadtNa4qcKbqtIky3yIJgZ62xJ3jC7P0JhrbrE8BibnJM8zMboZ Cbb1VPB5NkXYPV4rTRSI4Po= X-Google-Smtp-Source: APiQypLTnLjPDNnNSqH+28hBHDSVc+roLpy3QPduruGp0bWr41DL6u4FpH1sWq/opGKxLvN3EFlJxw== X-Received: by 2002:a17:90a:276a:: with SMTP id o97mr2095369pje.194.1586998598514; Wed, 15 Apr 2020 17:56:38 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id p11sm12753364pff.173.2020.04.15.17.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 17:56:37 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 7781640277; Thu, 16 Apr 2020 00:56:36 +0000 (UTC) Date: Thu, 16 Apr 2020 00:56:36 +0000 From: Luis Chamberlain To: Eric Sandeen Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Omar Sandoval , Hannes Reinecke , Michal Hocko , syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com Subject: Re: [PATCH 2/5] blktrace: fix debugfs use after free Message-ID: <20200416005636.GA11244@42.do-not-panic.com> References: <20200414041902.16769-1-mcgrof@kernel.org> <20200414041902.16769-3-mcgrof@kernel.org> <55401e02-f61c-25eb-271c-3ec7baf35e28@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55401e02-f61c-25eb-271c-3ec7baf35e28@sandeen.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 15, 2020 at 12:38:26PM -0500, Eric Sandeen wrote: > On 4/13/20 11:18 PM, Luis Chamberlain wrote: > > On commit 6ac93117ab00 ("blktrace: use existing disk debugfs directory") > > merged on v4.12 Omar fixed the original blktrace code for request-based > > drivers (multiqueue). This however left in place a possible crash, if you > > happen to abuse blktrace in a way it was not intended. > > > > Namely, if you loop adding a device, setup the blktrace with BLKTRACESETUP, > > forget to BLKTRACETEARDOWN, and then just remove the device you end up > > with a panic: > > I think this patch makes this all cleaner anyway, but - without the apparent > loop bug mentioned by Bart which allows removal of the loop device while blktrace > is active (if I read that right), can this still happen? I have not tested that, but some modifications of the break-blktrace program could enable us to test that, however I don't think the race would be possible after patch 3/5 "blktrace: refcount the request_queue during ioctl" is merged, as removal then a pending blktrace would refcount the request_queue and the removal would have to wait until the refcount is decremeneted, until after the blktrace ioctl. Luis