From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F4BC2BA19 for ; Thu, 16 Apr 2020 01:29:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 586112076D for ; Thu, 16 Apr 2020 01:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 586112076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 048408E0068; Wed, 15 Apr 2020 21:29:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F12CB8E0001; Wed, 15 Apr 2020 21:29:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB4068E0068; Wed, 15 Apr 2020 21:29:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id C0B258E0001 for ; Wed, 15 Apr 2020 21:29:35 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7ADBC181AC9BF for ; Thu, 16 Apr 2020 01:29:35 +0000 (UTC) X-FDA: 76711985910.25.cows19_53b55028e4c25 X-HE-Tag: cows19_53b55028e4c25 X-Filterd-Recvd-Size: 4540 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Apr 2020 01:29:35 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id m16so744780pls.4 for ; Wed, 15 Apr 2020 18:29:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PnF7XX+HBiChqiEIw8vxgcw83sjsqf5rskmR8bV1uhE=; b=q+Yv/Z9f9XFUr1LNBkf7J5tk63mdIN93z03KAXcIkGMqvgcXp2KkVPIbhZmiGvQcEC uKpV7KmpYxb/gO2HjovLrt4iGyAxCA0GCOpyH2gnE7Gl1xtADiAtN1KOL0qhySJtZci8 /yi4NJHzSrERYtEAfBhtRNwqukKIhJU07bUmNh+y5oeVGisHN/jJdFW9W5AwLlNdvcG8 T07gkvQ5jn6c1XQtBQB8ASAhnVZKwtzVAH76in1i1xwj6zFvlIM81SKWHw8olFKEyvlU FcavpLl5sg2mbRZVqQlTOwPWKpDgY3Em9a5nEjf2wWR4g6X8v0nuTv7Dy0zeLRMxcS5r 19Ag== X-Gm-Message-State: AGi0PuYb10WBy+DXNd9+OB1B1xVmHjhSKxcFthHnq+KO6wsJaiHusFr8 t2TyY1V4hnZV8Ez/Jy+ANsk= X-Google-Smtp-Source: APiQypL1Zry+M+f03DM3k+FuGlRfqeq4ZVim5hUX+tX4P9pE4l69kAMRnRCmwP6mQT5TXwK/Pbzv0g== X-Received: by 2002:a17:902:441:: with SMTP id 59mr7374218ple.339.1587000574181; Wed, 15 Apr 2020 18:29:34 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id a136sm12241605pfa.99.2020.04.15.18.29.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 18:29:32 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id C0B9240277; Thu, 16 Apr 2020 01:29:31 +0000 (UTC) Date: Thu, 16 Apr 2020 01:29:31 +0000 From: Luis Chamberlain To: Masami Hiramatsu Cc: Vlastimil Babka , Andrew Morton , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH v2 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <20200416012931.GE11244@42.do-not-panic.com> References: <20200414113222.16959-1-vbabka@suse.cz> <20200414113222.16959-2-vbabka@suse.cz> <20200415180355.00bc828ea726c421638db871@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200415180355.00bc828ea726c421638db871@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 15, 2020 at 06:03:55PM +0900, Masami Hiramatsu wrote: > On Tue, 14 Apr 2020 13:32:20 +0200 > Vlastimil Babka wrote: > > diff --git a/init/main.c b/init/main.c > > index a48617f2e5e5..7b43118215d6 100644 > > --- a/init/main.c > > +++ b/init/main.c > > @@ -1372,6 +1372,8 @@ static int __ref kernel_init(void *unused) > > > > rcu_end_inkernel_boot(); > > > > + do_sysctl_args(); > > + > > Ah, I see. Since the sysctl is designed to be called after all __init calls were > done, it shouldn't use bootconfig directly because bootconfig is full of __init > call. The idea is bootconfig would be useful in the sense of a library set of helpers which could be modified to remove __init, and then used to instrument the cmdline depending on certain debugging kconfig entries. We currently have no way to purposely extend / break the cmdline for debugging purposes, so, bootconfig's parsers, since it already has a way to extend the cmdlineline, might make it much easier to do this later. Without bootconfig, if we wanted to add new kconfig to, for example, add new funny cmdline arguments to test they worked or not, we'd have to devise our own set of helpers now. ie, new functionality. bootconfig however already has existing functionality to tweak the cmdline, and so some code could be leveraged there for this purpose. Luis