From: Michal Hocko <mhocko@kernel.org>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"david@redhat.com" <david@redhat.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3] mm/memory_hotplug: refrain from adding memory into an impossible node
Date: Thu, 16 Apr 2020 08:19:07 +0200 [thread overview]
Message-ID: <20200416061907.GA26707@dhcp22.suse.cz> (raw)
In-Reply-To: <7a37b7c03e983ceb32337325fa2a724fa614607b.camel@intel.com>
On Wed 15-04-20 20:32:00, Verma, Vishal L wrote:
> On Wed, 2020-04-15 at 12:43 +0200, Michal Hocko wrote:
> > On Tue 14-04-20 17:58:12, Vishal Verma wrote:
> > [...]
> > > +static int check_hotplug_node(int nid)
> > > +{
> > > + int alt_nid;
> > > +
> > > + if (node_possible(nid))
> > > + return nid;
> > > +
> > > + alt_nid = numa_map_to_online_node(nid);
> > > + if (alt_nid == NUMA_NO_NODE)
> > > + alt_nid = first_online_node;
> > > + WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND,
> > > + "node %d expected, but was absent from the node_possible_map, using %d instead\n",
> > > + nid, alt_nid);
> >
> > I really do not like this. Why should we try to be clever and change the
> > node id requested by the caller? I would just stick with node_possible
> > check and be done with this.
>
> Hi Michal,
>
> Being clever allows us to still use the memory even if it is in a non-
> optimal configuration. Failing here leaves the user no path to add this
> memory until the firmware is fixed. It is the tradeoff between some
> usability vs. how loud we want to be for the failure.
Doing that papers over something that is clearly a FW issue and makes
it "my performance is suboptimal" deal with it OS problem. Really, is
this something we have to care about. Your changelog talks about a Qemu
misconfiguration which is trivial to fix. Has this ever been observed
with a real HW?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-04-16 6:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 23:58 [PATCH v3] mm/memory_hotplug: refrain from adding memory into an impossible node Vishal Verma
2020-04-15 7:39 ` David Hildenbrand
2020-04-15 7:44 ` David Hildenbrand
2020-04-15 10:43 ` Michal Hocko
2020-04-15 20:32 ` Verma, Vishal L
2020-04-16 6:19 ` Michal Hocko [this message]
2020-04-16 16:13 ` Verma, Vishal L
2020-04-16 16:16 ` David Hildenbrand
2020-04-16 16:18 ` Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416061907.GA26707@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).