From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>, Zi Yan <ziy@nvidia.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
Ralph Campbell <rcampbell@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
William Kucharski <william.kucharski@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 4/8] khugepaged: Drain LRU add pagevec after swapin
Date: Thu, 16 Apr 2020 21:41:45 -0700 [thread overview]
Message-ID: <20200416214145.bfbb1afcc7a632e8cafdf203@linux-foundation.org> (raw)
In-Reply-To: <20200416160026.16538-5-kirill.shutemov@linux.intel.com>
On Thu, 16 Apr 2020 19:00:22 +0300 "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
> __collapse_huge_page_isolate() may fail due to extra pin in the LRU add
> pagevec. It's pretty common for swapin case: we swap in pages just to
> fail due to the extra pin.
>
> Drain LRU add pagevec on successful swapin.
I don't see how this patch can do anything to prevent
__collapse_huge_page_isolate() from failing, which is what the
changelog implies.
Can we have a more detailed changelog, please?
next prev parent reply other threads:[~2020-04-17 4:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 16:00 [PATCHv4 0/8] thp/khugepaged improvements and CoW semantics Kirill A. Shutemov
2020-04-16 16:00 ` [PATCHv4 1/8] khugepaged: Add self test Kirill A. Shutemov
2020-04-16 16:00 ` [PATCHv4 2/8] khugepaged: Do not stop collapse if less than half PTEs are referenced Kirill A. Shutemov
2020-04-16 16:00 ` [PATCHv4 3/8] khugepaged: Drain all LRU caches before scanning pages Kirill A. Shutemov
2020-04-16 16:00 ` [PATCHv4 4/8] khugepaged: Drain LRU add pagevec after swapin Kirill A. Shutemov
2020-04-17 4:41 ` Andrew Morton [this message]
2020-04-17 14:59 ` Kirill A. Shutemov
2020-04-16 16:00 ` [PATCHv4 5/8] khugepaged: Allow to collapse a page shared across fork Kirill A. Shutemov
2020-04-16 16:00 ` [PATCHv4 6/8] khugepaged: Allow to collapse PTE-mapped compound pages Kirill A. Shutemov
2020-04-16 16:00 ` [PATCHv4 7/8] thp: Change CoW semantics for anon-THP Kirill A. Shutemov
2020-04-21 0:48 ` [thp] fd80f22b29: vm-scalability.median 10.3% improvement kernel test robot
2020-04-16 16:00 ` [PATCHv4 8/8] khugepaged: Introduce 'max_ptes_shared' tunable Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416214145.bfbb1afcc7a632e8cafdf203@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=william.kucharski@oracle.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).