From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A75AC2BB55 for ; Fri, 17 Apr 2020 06:31:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4F442137B for ; Fri, 17 Apr 2020 06:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4F442137B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 517248E0003; Fri, 17 Apr 2020 02:31:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C71F8E0001; Fri, 17 Apr 2020 02:31:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B4E98E0003; Fri, 17 Apr 2020 02:31:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 2066C8E0001 for ; Fri, 17 Apr 2020 02:31:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D5EFB180ACF75 for ; Fri, 17 Apr 2020 06:31:06 +0000 (UTC) X-FDA: 76716374532.04.mist53_9a9179c4e33d X-HE-Tag: mist53_9a9179c4e33d X-Filterd-Recvd-Size: 2377 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Apr 2020 06:31:06 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CB09368BEB; Fri, 17 Apr 2020 08:31:02 +0200 (CEST) Date: Fri, 17 Apr 2020 08:31:02 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Linus Torvalds , Andrew Morton , Al Viro , Felix Kuehling , Alex Deucher , Zhenyu Wang , Zhi Wang , Felipe Balbi , "Michael S. Tsirkin" , Jason Wang , Jens Axboe , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: improve use_mm / unuse_mm v2 Message-ID: <20200417063102.GA18556@lst.de> References: <20200416053158.586887-1-hch@lst.de> <20200417031744.GI5820@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417031744.GI5820@bombadil.infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 16, 2020 at 08:17:44PM -0700, Matthew Wilcox wrote: > On Thu, Apr 16, 2020 at 07:31:55AM +0200, Christoph Hellwig wrote: > > this series improves the use_mm / unuse_mm interface by better > > documenting the assumptions, and my taking the set_fs manipulations > > spread over the callers into the core API. > > I appreciate all the work you're doing here. > > Do you have plans to introduce a better-named API than set_fs() / get_fs()? Eventually. For now I just plan to kill as many as possible. > Also, having set_fs() return the previous value of 'fs' would simplify > a lot of the callers. One thing that should go relatively soon is the need to store the previous value because we'll have so few callers left that we know we can't recurse. We should be able to get there around 5.9 / 5.10.